Skip to content

If a module dependency is in core it assumes it's on contrib #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
herbdool opened this issue May 23, 2024 · 2 comments · Fixed by #383
Closed

If a module dependency is in core it assumes it's on contrib #382

herbdool opened this issue May 23, 2024 · 2 comments · Fixed by #383
Assignees
@yorkshire-pudding
Labels
type: bug

Comments

@herbdool
Copy link
Contributor

I've got a module that depends on the core list module. Either bee is assuming all dependencies are in contrib, or it can't find some modules if they're embedded in another module. list is inside of field.
@yorkshire-pudding yorkshire-pudding self-assigned this May 23, 2024
yorkshire-pudding added a commit to yorkshire-pudding/bee that referenced this issue May 23, 2024
@yorkshire-pudding
Issue backdrop-contrib#382: Fix failure to check core submodule depen…
0ee1b6b 
…dencies
@yorkshire-pudding yorkshire-pudding mentioned this issue May 23, 2024
Merged
@yorkshire-pudding yorkshire-pudding added pr: needs review pr: needs testing A pull request has been linked to the issue and requires testing. and removed status: work in progress labels May 23, 2024
@yorkshire-pudding
Copy link
Collaborator

@herbdool - I've been able to reproduce this and have created a PR that fixes this. Please can you test.

@herbdool
Copy link
Contributor Author

@yorkshire-pudding thanks! I've tested and it works. Also reviewed the PR. RTBC

@yorkshire-pudding yorkshire-pudding added pr: needs work and removed pr: needs review pr: needs testing A pull request has been linked to the issue and requires testing. labels May 23, 2024
yorkshire-pudding added a commit that referenced this issue May 23, 2024
@yorkshire-pudding
Issue #382: Fix failure to check core submodule dependencies (#383)
a26e570
@yorkshire-pudding yorkshire-pudding mentioned this issue Jun 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yorkshire-pudding yorkshire-pudding

Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #382: Fix failure to check core submodule dependencies yorkshire-pudding/bee
2 participants
@herbdool @yorkshire-pudding