-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple bug fixes #745
Merged
Merged
Multiple bug fixes #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… option when channel is of wrong type
teddychao
reviewed
Jul 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the issue of pspm_init in PR 746.
teddychao
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple bugs and improvements identified during beta testing.
pspm_init
(duplicated path removal, no warning if only required paths are already on the path)pspm_dcm
/pspm_dcm_inv
(argument valueinf
is not recognised asint
bypspm_options
)pspm_extract_segments
(normalisation with missing values,sr
for glm)pspm_glm
(wrong sample rate)pspm_trim
(usepspm_load_channel
and fix help text)pspm_glm
(remove unnecessary and impossible orthogonalisation in edge case)pspm_get_timing
andpspm_trim
pspm_convert_hb2hp
andpspm_resp_pp
by using nearest neighbour instead of linear extrapolation (including a new regression test)pspm_multi2index
pspm_pupil_pp
by using a different criterion for the decision on whether to combine pupils