Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple bug fixes #745

Merged
merged 25 commits into from
Jul 29, 2024
Merged

Multiple bug fixes #745

merged 25 commits into from
Jul 29, 2024

Conversation

dominikbach
Copy link
Contributor

@dominikbach dominikbach commented Jul 18, 2024

Multiple bugs and improvements identified during beta testing.

  • fixes bugs in channel index handling
  • fixes bugs in pspm_init (duplicated path removal, no warning if only required paths are already on the path)
  • fixes a bug in a new functionality of pspm_dcm/pspm_dcm_inv (argument value inf is not recognised as int by pspm_options)
  • fixes a bug in pspm_extract_segments (normalisation with missing values, sr for glm)
  • fixes a bug in pspm_glm (wrong sample rate)
  • improves pspm_trim (use pspm_load_channel and fix help text)
  • improves pspm_glm (remove unnecessary and impossible orthogonalisation in edge case)
  • catch an edge case in epoch definition (negative epoch onsets) in pspm_get_timing and pspm_trim
  • improve interpolation in pspm_convert_hb2hp and pspm_resp_pp by using nearest neighbour instead of linear extrapolation (including a new regression test)
  • fixes a bug (missing index for a vector) in pspm_multi2index
  • improve pspm_pupil_pp by using a different criterion for the decision on whether to combine pupils

@dominikbach dominikbach self-assigned this Jul 18, 2024
@dominikbach dominikbach added the Bug Something isn't working label Jul 18, 2024
@dominikbach dominikbach added this to the v7.0 milestone Jul 18, 2024
@dominikbach dominikbach added the Completed & Waiting for Review Completed and waiting for review label Jul 18, 2024
@dominikbach dominikbach changed the title bugfix channel index behaviour Multiple bug fixes Jul 18, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the issue of pspm_init in PR 746.

@teddychao teddychao added Approved The pull request has been approved and can be checked and then merged. and removed Completed & Waiting for Review Completed and waiting for review labels Jul 29, 2024
@dominikbach dominikbach merged commit 6c8c5b5 into develop Jul 29, 2024
1 check passed
@dominikbach dominikbach deleted the fix-channel-index branch July 29, 2024 10:45
@Huaiyu-Liu Huaiyu-Liu restored the fix-channel-index branch July 30, 2024 13:27
@dominikbach dominikbach deleted the fix-channel-index branch August 2, 2024 04:30
@teddychao teddychao removed Bug Something isn't working Approved The pull request has been approved and can be checked and then merged. labels Aug 5, 2024
@Huaiyu-Liu Huaiyu-Liu restored the fix-channel-index branch August 7, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants