Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 335 - pspm_scr_pp #336

Merged
merged 6 commits into from
Dec 21, 2021
Merged

Fix issue 335 - pspm_scr_pp #336

merged 6 commits into from
Dec 21, 2021

Conversation

teddychao
Copy link
Contributor

@teddychao teddychao commented Dec 9, 2021

Fixes #335.

Changes proposed in this pull request:

  • Update pspm_scr_pp: users now can specify whether processed data and missing epochs are saved respectively.
  • Update pspm_scr_pp_test: testing if processed data and missing epochs can be specifically saved.

@teddychao teddychao self-assigned this Dec 9, 2021
Copy link
Contributor

@dominikbach dominikbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github messes up the diff (not sure why), could you briefly say what has changed?

@teddychao
Copy link
Contributor Author

teddychao commented Dec 11, 2021

github messes up the diff (not sure why), could you briefly say what has changed?

Hi Dom,

Sorry I did not state the modifications clearly before asking you to check.
For pspm_scr_pp, I only sorted the help text.
For pspm_scr_pp_test, I only make to code to verify if a channel is added when users want to add a channel to save the modified scr signal, in Line 57 of pspm_scr_pp_test.
I am a little confused about the issue because the code will save the modified scr signal when missing epochs are not saved. This is consistent to pspm_pupil_pp. I have contacted Carlos for further information about the issue.

Thanks.

@teddychao teddychao changed the title Fix issue 335 Fix issue 335 - pspm_scr_pp Dec 12, 2021
@teddychao teddychao marked this pull request as draft December 13, 2021 19:35
@teddychao
Copy link
Contributor Author

@dominikbach Hi Dom, may I know if you would suggest to expand the current data saving method to other related functions, e.g. pspm_pupil_pp? Users may prefer to save data files and missing epochs at the same time from other functions I assume, but I could be wrong.

@teddychao teddychao marked this pull request as ready for review December 14, 2021 17:55
@teddychao teddychao added Discussion Further information is requested Improvement A minor improvement to the project Waiting for Approval labels Dec 14, 2021
@teddychao teddychao added this to the v5.1.2 milestone Dec 18, 2021
@teddychao teddychao removed the Discussion Further information is requested label Dec 21, 2021
@teddychao teddychao merged commit 8d64008 into develop Dec 21, 2021
@teddychao teddychao modified the milestones: v5.1.2, v6.0.0 Jan 24, 2022
@teddychao teddychao mentioned this pull request Jul 12, 2022
@dominikbach dominikbach deleted the Fix-issue-335 branch December 13, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement A minor improvement to the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pspm_scr_pp may not write out data successfully
2 participants