Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DX Improvement: Job Error Feedback and Node Capabilities #403

Closed
philwinder opened this issue Jul 22, 2022 · 3 comments
Closed

DX Improvement: Job Error Feedback and Node Capabilities #403

philwinder opened this issue Jul 22, 2022 · 3 comments
Labels
type/enhancement Type: New features or enhancements to existing features

Comments

@philwinder
Copy link
Contributor

philwinder commented Jul 22, 2022 •
edited by aronchick
Loading

ETA: 2023Q2

Not entirely sure how to structure this request; it may be more than one thing when we sketch it out.

There are several problems that are related:

  • Job specifications can be invalid, like non-existant data, invalid commands, bad resource requests, or requesting an A100 when it doesn't exist. When this happens the job will be stuck in waiting, with no way of knowing what's happening.
  • For GPU jobs, specifically, there's a wide selection of valid permutations to the request, like GPU type, required CUDA memory, CUDA library version, etc. How can we develop the code in a scalable way to allow jobs select the right options?
  • If a node takes a GPU job but the container is old, it will fail because of a version mismatch. I think (untested) the job will error, but it would be nice to do this check BEFORE running the job?
  • Is it possible for jobs to check for validity on the network at submission time, rather than runtime?

We need to have a planning session about this to figure out how we can split up and solve some of these issues.
@philwinder philwinder added the type/enhancement Type: New features or enhancements to existing features label Jul 22, 2022
@lukemarsden
Copy link
Contributor

relates to #404

@wdbaruni
Copy link
Member

related to #342

@aronchick aronchick changed the title Job Error Feedback and Node Capabilities DX Improvement: Job Error Feedback and Node Capabilities Nov 21, 2022
@philwinder philwinder mentioned this issue Jan 17, 2023
Closed
8 tasks
github-actions bot pushed a commit that referenced this issue Oct 18, 2023
@dependabot
Bump pluggy from 1.0 to 1.3.0 in /integration (#2933)
25ff31e 
Bumps [pluggy](https://github.com/pytest-dev/pluggy) from 1.0 to 1.3.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/pytest-dev/pluggy/blob/main/CHANGELOG.rst">pluggy's
changelog</a>.</em></p>
<blockquote>
<h1>pluggy 1.3.0 (2023-08-26)</h1>
<h2>Deprecations and Removals</h2>
<ul>
<li><code>[#426](pytest-dev/pluggy#426)
&lt;https://github.com/pytest-dev/pluggy/issues/426&gt;</code>_: Python
3.7 is no longer supported.</li>
</ul>
<h2>Features</h2>
<ul>
<li>
<p><code>[#428](pytest-dev/pluggy#428)
&lt;https://github.com/pytest-dev/pluggy/issues/428&gt;</code>_: Pluggy
now exposes its typings to static type checkers.</p>
<p>As part of this, the following changes are made:</p>
<ul>
<li>Renamed <code>_Result</code> to <code>Result</code>, and exported as
:class:<code>pluggy.Result</code>.</li>
<li>Renamed <code>_HookRelay</code> to <code>HookRelay</code>, and
exported as :class:<code>pluggy.HookRelay</code>.</li>
<li>Renamed <code>_HookCaller</code> to <code>HookCaller</code>, and
exported as :class:<code>pluggy.HookCaller</code>.</li>
<li>Exported <code>HookImpl</code> as
:class:<code>pluggy.HookImpl</code>.</li>
<li>Renamed <code>_HookImplOpts</code> to <code>HookimplOpts</code>, and
exported as :class:<code>pluggy.HookimplOpts</code>.</li>
<li>Renamed <code>_HookSpecOpts</code> to <code>HookspecOpts</code>, and
exported as :class:<code>pluggy.HookspecOpts</code>.</li>
<li>Some fields and classes are marked <code>Final</code> and
<code>@Final</code>.</li>
<li>The :ref:<code>api-reference</code> is updated to clearly delineate
pluggy's public API.</li>
</ul>
<p>Compatibility aliases are put in place for the renamed types.
We do not plan to remove the aliases, but we strongly recommend to only
import from <code>pluggy.*</code> to ensure future compatibility.</p>
<p>Please note that pluggy is currently unable to provide strong typing
for hook calls, e.g. <code>pm.hook.my_hook(...)</code>,
nor to statically check that a hook implementation matches the hook
specification's type.</p>
</li>
</ul>
<h1>pluggy 1.2.0 (2023-06-21)</h1>
<h2>Features</h2>
<ul>
<li><code>[#405](pytest-dev/pluggy#405)
&lt;https://github.com/pytest-dev/pluggy/issues/405&gt;</code>_: The
new-style hook wrappers, added in the yanked 1.1.0 release, now require
an explicit <code>wrapper=True</code> designation in the
<code>@hookimpl()</code> decorator.</li>
</ul>
<h1>pluggy 1.1.0 (YANKED)</h1>
<p>.. note::</p>
<p>This release was yanked because unfortunately the implicit new-style
hook wrappers broke some downstream projects.
See <code>[#403](pytest-dev/pluggy#403)
&lt;https://github.com/pytest-dev/pluggy/issues/403&gt;</code>__ for
more information.
This was rectified in the 1.2.0 release.</p>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/e13a58c5039bf7a8aa6a46a77244aea48b210510"><code>e13a58c</code></a>
Preparing release 1.3.0</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/c53af988873187089224fa3d774d0d89f659f285"><code>c53af98</code></a>
Merge pull request <a
href="https://github.com/pytest-dev/pluggy/issues/434">#434</a>
from bluetech/typing4</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/62da97c2d6cc0821774bc3cb2fa210f8592f7d13"><code>62da97c</code></a>
Export pluggy's typing</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/973fb561869c315a269281817f3b3de4be6f9c43"><code>973fb56</code></a>
tracing: more compatible types for <code>_Writer</code> and
<code>_Processor</code></li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/b5fb741127471a98d5cb91264640218e3bbe83ff"><code>b5fb741</code></a>
Export <code>__version__</code></li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/1b1042ea689247264f4f9062f227d967826781c5"><code>1b1042e</code></a>
Merge pull request <a
href="https://github.com/pytest-dev/pluggy/issues/430">#430</a>
from bluetech/typing3</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/ba6fb4ab03adbd5c47ad47b3d39822b15622bae0"><code>ba6fb4a</code></a>
[pre-commit.ci] pre-commit autoupdate</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/aea172a01824e6d8963ba78f70965174bfec9eb7"><code>aea172a</code></a>
[pre-commit.ci] pre-commit autoupdate</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/20b419d7711ec84c5357efa2d6eefbd8ca1c4112"><code>20b419d</code></a>
docs: enable nitpicky mode</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/80a73dcf58eb0bf8e707c89bd572a46cc69eb141"><code>80a73dc</code></a>
Mark some fields and classes <code>Final</code> and
<code>@Final</code></li>
<li>Additional commits viewable in <a
href="https://github.com/pytest-dev/pluggy/compare/1.0.0...1.3.0">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=pluggy&package-manager=pip&previous-version=1.0&new-version=1.3.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@simonwo
Copy link
Contributor

simonwo commented Nov 14, 2023

Most of these issues are now solved by up front node ranking.

@simonwo simonwo closed this as not planned Won't fix, can't repro, duplicate, stale Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement Type: New features or enhancements to existing features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@aronchick @lukemarsden @simonwo @wdbaruni @philwinder