-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: release v0.5.1 #82
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run e2e tests with babylond in docker container. Seems that in order to execute tests with `t.Parallel()` we will need to do some refactoring in eots manager. Will be done in next PR.
Ensures that our e2e tests version use a correct version of babylond from go.mod
In the previous implementation, once a finality provider is jailed, when the fpd is restarted, it will panic due to error from Babylon when fast sync. This PR fixed this issue with the following changes: 1. We implemented `unjail` finality provider CLI other than using the one from Babylon. This implementation will set the fp instance status to `inactive` after `unjail` tx is successfully sent (will later updated to active if the fp has voting power). 2. Once `jailed` error is detected while starting a fp instance, it will fail but the fpd will not panic, meaning that the loop for updating stored fp status continues running. Now the flow of jailing/unjailing becomes the follows: 1. fpd detects jailing via err when sending a fp sig or a loop for checking fp status 2. once `jailed` detected, fpd terminates the fp instance without terminating the program 3. the operator checks fp signing info to get the `jail_until` via `babylond q finality signing-info [fp-pk-hex]` 4. after the `jail_until` is passed, the operator can unjail the fp by executing `fpd unjail-finality-provider [fp-pk-hex]` 5. if everything goes well, the fp will continue sending finality votes if it has voting power after a period of waiting for state transition
New release `v0.5.x` should be created after this PR
Hey @gitferry running the local deployments with this version, the finality provider is stopping after being slashed, is this expected?
|
New release v06 will be done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.