backport: Insert inclusion height to early unbonding event #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #225. * added unbonding start height to early unbonding event * changed that early unbonding event is emitted as a tx event
gitferry
requested review from
Lazar955,
RafilxTenfen,
KonradStaniec and
jrwbabylonlab
and removed request for
a team,
Lazar955 and
RafilxTenfen
jrwbabylonlab
approved these changes
Oct 25, 2024
KonradStaniec
approved these changes
Oct 25, 2024
maurolacy
reviewed
Oct 27, 2024
| @@ -215,8 +215,10 @@ message EventBTCDelgationUnbondedEarly { | |||
| // staking_tx_hash is the hash of the staking tx. | |||
| // It uniquely identifies a BTC delegation | |||
| string staking_tx_hash = 1 [(amino.dont_omitempty) = true]; | |||
| // start_height is the start BTC height of the early unbonding | |||
| string start_height = 2 [(amino.dont_omitempty) = true]; | |||
There was a problem hiding this comment.
Why is this not a uint32 or uint64? Just curious.
There was a problem hiding this comment.
This is for easier parsing for subscribers of the event
maurolacy
reviewed
Oct 27, 2024
Comment on lines
+192
to
+194
| if !btcDel.IsUnbondedEarly() { | ||
| types.EmitExpiredDelegationEvent(sdkCtx, delEvent.StakingTxHash) | ||
| } |
There was a problem hiding this comment.
What if it's an early unbond? No event emitted?
There was a problem hiding this comment.
It is now emitted during processing undelegate message https://github.com/babylonlabs-io/babylon/pull/228/files#diff-0490899e13cee0223ce9b01147d9ad2753112c4e8118443e1b54684738fc4969R585. The reason we changed the emitting there is because we don't want to save the inclusion height in db considering re-org could happen on Bitcoin. Discussions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.