chore: add check in finality for block height finality parameter to accept finality vote/pubrand #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tart to process events that updates the voting power table
This was referenced Oct 15, 2024
RafilxTenfen
requested review from
KonradStaniec,
samricotta and
gitferry
and removed request for
a team
…btc-staking-activation-height
gitferry
reviewed
Oct 16, 2024
|
Will be modified to block finality vote and pub rand commit before activation height |
KonradStaniec
approved these changes
Oct 22, 2024
gitferry
approved these changes
Oct 22, 2024
x/finality/abci.go
Outdated
Comment on lines
23
to
30
| sdkCtx := sdk.UnwrapSDKContext(ctx) | ||
| if uint64(sdkCtx.HeaderInfo().Height) < k.GetParams(ctx).FinalityActivationHeight { | ||
| return []abci.ValidatorUpdate{}, nil | ||
| } | ||
|
|
||
| // if the BTC staking protocol is activated, i.e., there exists a height where a finality provider | ||
| // has voting power, start indexing and tallying blocks | ||
| if _, err := k.BTCStakingKeeper.GetBTCStakingActivatedHeight(ctx); err == nil { |
There was a problem hiding this comment.
nit: I think we can combine the two checks into one validation like validateActivation indication that we only handle finality when (1) the height higher than the activation height and (2) at least one fp has voting power at this height
…btc-staking-activation-height
maurolacy
reviewed
Oct 25, 2024
Comment on lines
+135
to
+137
| fmt.Printf("\n Debug: errOut %s", errBufString) | ||
| fmt.Printf("\n Debug: output %s", outBuf.String()) | ||
|
|
There was a problem hiding this comment.
Nit: Remove debug statements.
maurolacy
reviewed
Oct 25, 2024
| ctx := sdk.UnwrapSDKContext(goCtx) | ||
| activationHeight, errMod := ms.validateActivationHeight(ctx, req.BlockHeight) | ||
| if errMod != nil { | ||
| return nil, errMod.Wrapf("finality block height: %d is lower than activation height %d", req.BlockHeight, activationHeight) |
There was a problem hiding this comment.
Nit: The error message should be returned from inside the validation function, for generality.
maurolacy
reviewed
Oct 25, 2024
| activationHeight, errMod := ms.validateActivationHeight(ctx, req.StartHeight) | ||
| if errMod != nil { | ||
| return nil, types.ErrFinalityNotActivated.Wrapf( | ||
| "public rand commit start block height: %d is lower than activation height %d", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add finality param to minimum block height to allow receiving Finality and Pub Rand Commit of
x/finalityThis value is a module parameter and it can be updated by governance proposal