chore: update exposed db object RewardGuages in x/incentive module
#203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samricotta
requested review from
gitferry and
RafilxTenfen
and removed request for
a team
samricotta
changed the title
RewardGuages in x/incentive moduleRewardGuages in x/incentive module
gitferry
approved these changes
Oct 16, 2024
Comment on lines
+51
to
+59
| repeated cosmos.base.v1beta1.Coin coins = 1 [ | ||
| (gogoproto.nullable) = false, | ||
| (gogoproto.castrepeated) = "github.com/cosmos/cosmos-sdk/types.Coins" | ||
| ]; | ||
| // withdrawn_coins are coins that have been withdrawn by the stakeholder already | ||
| repeated cosmos.base.v1beta1.Coin withdrawn_coins = 2 [ | ||
| (gogoproto.nullable) = false, | ||
| (gogoproto.castrepeated) = "github.com/cosmos/cosmos-sdk/types.Coins" | ||
| ]; |
There was a problem hiding this comment.
This Response type is exactly like the RewardGauge should we have two exactly structures just to split from the db used structure? @babylonlabs-io/core-dev
There was a problem hiding this comment.
I think this is the case, as the two structs might diverge in the future. If we reuse the same struct now, then it's made difficult if we want to make modifications on API or DB.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part closes: https://github.com/babylonlabs-io/pm/issues/72
Currently some of the objects in the babylon apis are exposed and need to be handled correctly seen in https://github.com/babylonlabs-io/pm/issues/72
This PR handles the exposed objects in
x/incentiveSpecifically the
RewardGuagesobject.