Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove localnet functionality from Makefile #184

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Conversation

vitsalis
Copy link
Member

This functionality is not useful as a network of Babylon nodes just by itself does not allow us to test much. This is evident by the fact that we never use this for testing. Instead we typically utilise a deployment containing all the interconnected components consisting of the Babylon network.

This functionality is not useful as a network of Babylon nodes just by itself does not allow us to test much.
This is evident by the fact that we never use this for testing.
Instead we typically utilise a deployment containing all the interconnected components
consisting of the Babylon network.
@vitsalis vitsalis requested a review from a team as a code owner October 11, 2024 12:47
@vitsalis vitsalis requested review from Lazar955 and RafilxTenfen and removed request for a team October 11, 2024 12:47
Makefile Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@RafilxTenfen RafilxTenfen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vitsalis vitsalis merged commit e66765c into main Oct 11, 2024
20 checks passed
@vitsalis vitsalis deleted the localnet-clean branch October 11, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants