ci: add goreleaser setup and move out changelog reminder #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastianElvis
requested review from
gitferry and
KonradStaniec
and removed request for
a team
|
Hmm any idea why changelog reminder is not happy with the error UPDATE: OK resolved by moving it out following Osmosis' practice. Now ready for review |
SebastianElvis
changed the title
KonradStaniec
approved these changes
Oct 11, 2024
Yes this is already mentioned. And you are right this is done upon tagging |
oh I do not see any mentions there, that upon pushing a tag new binaries will be build and published. There is only mention abut backporitng label |
Ah you are right! Added |
Lazar955
approved these changes
Oct 11, 2024
Comment on lines
+22
to
+23
| - -X github.com/cosmos/cosmos-sdk/version.Version={{ .Version }} | ||
| - -X github.com/cosmos/cosmos-sdk/version.Commit={{ .Commit }} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
make release-snapshot