Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(btcstaking/client): edit fp arg #154

Merged
merged 3 commits into from
Oct 10, 2024
Merged

fix(btcstaking/client): edit fp arg #154

merged 3 commits into from
Oct 10, 2024

Conversation

Lazar955
Copy link
Member

@Lazar955 Lazar955 commented Oct 9, 2024

We're accessing arg at index 1, but should be at 0

@Lazar955 Lazar955 requested a review from a team as a code owner October 9, 2024 15:21
@Lazar955 Lazar955 requested review from gitferry, RafilxTenfen and KonradStaniec and removed request for a team October 9, 2024 15:21
@@ -159,7 +159,7 @@ func NewEditFinalityProviderCmd() *cobra.Command {
}

// get BTC PK
btcPK, err := hex.DecodeString(args[1])
btcPK, err := hex.DecodeString(args[0])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

Copy link
Contributor

@RafilxTenfen RafilxTenfen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

miss changelogs ^^

@Lazar955 Lazar955 merged commit a5c4e94 into main Oct 10, 2024
18 checks passed
@Lazar955 Lazar955 deleted the lazar/fix-edit-fp-arg branch October 10, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants