-
Notifications
You must be signed in to change notification settings - Fork 97
fix(evm): Bump cosmos evm to 0.41 and add eth signer extractor for the priority nonce mempool #1430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR upgrades the cosmos EVM module from version 0.3.1 to 0.4.1 and implements the required priority nonce mempool with an Ethereum signer extractor. The changes enable proper handling of Ethereum transactions in the mempool by extracting signers from Ethereum transaction extensions.
- Bump cosmos EVM to v0.4.1 and associated dependencies
- Add EthSignerExtractionAdapter for priority nonce mempool integration
- Remove evidence precompile and update precompile configuration with codec options
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Updates cosmos EVM and various dependencies to newer versions |
| cmd/babylond/cmd/root.go | Changes return type from servertypes.Application to evmserver.Application |
| app/signer.go | Implements EthSignerExtractionAdapter for extracting signers from Ethereum transactions |
| app/keepers/precompiles.go | Removes evidence precompile and adds codec configuration for precompiles |
| app/keepers/keepers.go | Updates precompile initialization to remove evidence keeper dependency |
| app/app.go | Configures mempool with Ethereum signer extractor and adds pending transaction listener support |
| CHANGELOG.md | Documents the EVM upgrade in changelog |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@canu0205 can you please double check if the new required wiring introduced in 0.41 is correct ? |
canu0205
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a comment on setup EthSignerExtractionAdapter on proposal handler.
besides that, wiring cosmos evm v0.4.1 looks correct.
|
@Vvaradinov is it ready for review it again? |
|
@canu0205 yes can you please re-review |
canu0205
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
one minor comment regarding changing the maxTxs at testnet command and default babylon config for utilizing priority nonce mempool (it can be modified future)
…e priority nonce mempool (#1430) This PR updates the evm to the latest commit hash that included the priority nonce mempool cosmos/evm#245. This adds the mandatory signer extractor to the mempool configuration. Additional changes in our testnet command, cosmos evm version and other configurations are needed. (cherry picked from commit dac5bad)
…e priority nonce mempool (backport #1430) (#1575) This PR updates the evm to the latest commit hash that included the priority nonce mempool cosmos/evm#245. This adds the mandatory signer extractor to the mempool configuration. Additional changes in our testnet command, cosmos evm version and other configurations are needed. <hr>This is an automatic backport of pull request #1430 done by [Mergify](https://mergify.com). Co-authored-by: Vladislav Varadinov <[email protected]>
This PR updates the evm to the latest commit hash that included the priority nonce mempool cosmos/evm#245. This adds the mandatory signer extractor to the mempool configuration.
Additional changes in our testnet command, cosmos evm version and other configurations are needed.