Skip to content

Conversation

@Vvaradinov
Copy link
Contributor

@Vvaradinov Vvaradinov commented Jul 28, 2025

This PR updates the evm to the latest commit hash that included the priority nonce mempool cosmos/evm#245. This adds the mandatory signer extractor to the mempool configuration.

Additional changes in our testnet command, cosmos evm version and other configurations are needed.

@Vvaradinov Vvaradinov changed the title [WIP]: fix(evm): add eth signer extractor for the priority nonce mempool fix(evm): Bump cosmos evm to 0.41 and add eth signer extractor for the priority nonce mempool Aug 15, 2025
@Vvaradinov Vvaradinov marked this pull request as ready for review August 15, 2025 08:39
Copilot AI review requested due to automatic review settings August 15, 2025 08:39
@Vvaradinov Vvaradinov requested a review from canu0205 August 15, 2025 08:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the cosmos EVM module from version 0.3.1 to 0.4.1 and implements the required priority nonce mempool with an Ethereum signer extractor. The changes enable proper handling of Ethereum transactions in the mempool by extracting signers from Ethereum transaction extensions.

  • Bump cosmos EVM to v0.4.1 and associated dependencies
  • Add EthSignerExtractionAdapter for priority nonce mempool integration
  • Remove evidence precompile and update precompile configuration with codec options

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
go.mod Updates cosmos EVM and various dependencies to newer versions
cmd/babylond/cmd/root.go Changes return type from servertypes.Application to evmserver.Application
app/signer.go Implements EthSignerExtractionAdapter for extracting signers from Ethereum transactions
app/keepers/precompiles.go Removes evidence precompile and adds codec configuration for precompiles
app/keepers/keepers.go Updates precompile initialization to remove evidence keeper dependency
app/app.go Configures mempool with Ethereum signer extractor and adds pending transaction listener support
CHANGELOG.md Documents the EVM upgrade in changelog

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Vvaradinov
Copy link
Contributor Author

@canu0205 can you please double check if the new required wiring introduced in 0.41 is correct ?

Copy link
Collaborator

@canu0205 canu0205 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a comment on setup EthSignerExtractionAdapter on proposal handler.

besides that, wiring cosmos evm v0.4.1 looks correct.

@canu0205
Copy link
Collaborator

@Vvaradinov is it ready for review it again?

@Vvaradinov
Copy link
Contributor Author

@canu0205 yes can you please re-review

@Vvaradinov Vvaradinov requested a review from canu0205 August 20, 2025 06:03
Copy link
Collaborator

@canu0205 canu0205 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

one minor comment regarding changing the maxTxs at testnet command and default babylon config for utilizing priority nonce mempool (it can be modified future)

@Vvaradinov Vvaradinov merged commit dac5bad into main Aug 21, 2025
32 checks passed
@Vvaradinov Vvaradinov deleted the Vvaradinov/signer-extractor-mempool branch August 21, 2025 07:00
mergify bot pushed a commit that referenced this pull request Aug 21, 2025
…e priority nonce mempool (#1430)

This PR updates the evm to the latest commit hash that included the
priority nonce mempool cosmos/evm#245. This adds
the mandatory signer extractor to the mempool configuration.

Additional changes in our testnet command, cosmos evm version and other
configurations are needed.

(cherry picked from commit dac5bad)
Vvaradinov added a commit that referenced this pull request Aug 21, 2025
…e priority nonce mempool (backport #1430) (#1575)

This PR updates the evm to the latest commit hash that included the
priority nonce mempool cosmos/evm#245. This adds
the mandatory signer extractor to the mempool configuration.

Additional changes in our testnet command, cosmos evm version and other
configurations are needed. <hr>This is an automatic backport of pull
request #1430 done by [Mergify](https://mergify.com).

Co-authored-by: Vladislav Varadinov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants