Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: missing unambiguous sourceType #8610

Merged
merged 1 commit into from
Sep 4, 2018
Merged

types: missing unambiguous sourceType #8610

merged 1 commit into from
Sep 4, 2018

Conversation

xtuc
Copy link
Member

@xtuc xtuc commented Sep 3, 2018

Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@xtuc
Copy link
Member Author

xtuc commented Sep 3, 2018

We're using it here

babel/packages/babel-parser/src/index.js

Line 19 in 7663205

if (options && options.sourceType === "unambiguous") {
and flow didn't get that.

@xtuc xtuc added PR: Internal 🏠 A type of pull request used for our changelog categories pkg: parser labels Sep 3, 2018
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8992/

@existentialism existentialism merged commit 07fae82 into master Sep 4, 2018
@existentialism existentialism deleted the xtuc-patch-2 branch September 4, 2018 15:03
@existentialism existentialism mentioned this pull request Sep 4, 2018
Merged
This was referenced Sep 18, 2018
Merged
Merged
Open
Open
@dependencies dependencies bot mentioned this pull request Oct 1, 2018
Open
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xtuc @babel-bot @nicolo-ribaudo @existentialism