Rely on the call stack to clean up cache in _guessExecutionStatusRelativeTo
#14649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
changed the title
_guessExecutionStatusRelativeTo
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52179/ |
liuxingbaoyu
approved these changes
Jun 9, 2022
|
Great job! Maybe we can make |
JLHwung
approved these changes
Jun 10, 2022
JLHwung
added
the
PR: Internal 🏠
I prefer to keep it an internal implementation detail, not exposed to publicly reachable functions. |
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2Follow up to #14617 (cc @liuxingbaoyu)
This small refactor simplifies #14617 a bit so that we don't have to manually clean up
executionStatusCacheand track its "inited" status, but it's handled automatically by the engine. The number of lines of code inintrospection.tsis still more or less the same, but the logic has been reduced.Also,
NodePath#_guessExecutionStatusRelativeToDifferentFunctionsisn't used anymore so we can remove it in Babel 8.I suggest reviewing with whitespace diff disabled.