Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use md5 hashing for OpenSSL 3 #924

Merged
merged 4 commits into from
Mar 22, 2022
Merged

Use md5 hashing for OpenSSL 3 #924

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4aef3c6
Use md5 hashing for OpenSSL 3
pathmapper Jan 1, 2022
1461df8
Fix lint
pathmapper Jan 1, 2022
ba92115
Use 'md5' hashing if 'md4' could not be created
pathmapper Jan 1, 2022
e8e5932
Move hash detection to top level
pathmapper Jan 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions src/cache.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,14 @@ const transform = require("./transform");
// Lazily instantiated when needed
let defaultCacheDirectory = null;

let hashType = "md4";
// use md5 hashing if md4 is not available
try {
crypto.createHash(hashType);
} catch (err) {
hashType = "md5";
}

const readFile = promisify(fs.readFile);
const writeFile = promisify(fs.writeFile);
const gunzip = promisify(zlib.gunzip);
Expand Down Expand Up @@ -63,13 +71,6 @@ const write = async function (filename, compress, result) {
* @return {String}
*/
const filename = function (source, identifier, options) {
// md4 hashing is not supported starting with node v17.0.0
const majorNodeVersion = parseInt(process.versions.node.split(".")[0], 10);
let hashType = "md4";
if (majorNodeVersion >= 17) {
hashType = "md5";
}

const hash = crypto.createHash(hashType);

const contents = JSON.stringify({ source, options, identifier });
Expand Down