Enter async mode only when necessary #79
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Ever since babel-loader introduced caching we can't use it anymore together with enhanced-require as that doesn't support async callbacks in loaders.
This change restores enhanced-require compatibility as long as the cacheDirectory option isn't used.
(It would be possible to implement caching synchronously but I suppose there are performance concerns. We don't need caching when using enhanced-require so I left caching to be async.)