Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .babelrc when options.babelrc path is supplied #579

Closed
wants to merge 1 commit into from
Closed

Use .babelrc when options.babelrc path is supplied #579

wants to merge 1 commit into from

Conversation

nguyenj
Copy link

@nguyenj nguyenj commented Feb 15, 2018

Please Read the CONTRIBUTING Guidelines
In particular the portion on Commit Message Formatting

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Some help writing this test would be very much appreciated.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Bugfix

What is the current behavior? (You can also link to an open issue here)
Doesn't read the babelrc file when path is supplied.

What is the new behavior?
Reads the babelrc file and applies the configuration that's passed on to transpile. If configuration is supplied within the loader options, that takes precedence even if babelrc path is supplied.

Does this PR introduce a breaking change?

  • No

If this PR contains a breaking change, please describe the following...

Other information:

@nguyenj nguyenj mentioned this pull request Feb 15, 2018
@danez
Copy link
Member

danez commented Feb 25, 2018

We do not want to handle config file loading in the loader, this should all be done in babel-core. The next babel-loader version will contain a fix for the babelrc issue. #583

@danez danez closed this Feb 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants