Update peerDependencies to include Webpack 2 #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: I’m specified as the “owner” here but I don’t publish packages so it’s up to the actual maintainers to merge this. |
Couto
added a commit
that referenced
this pull request
Feb 3, 2016
Update peerDependencies to include Webpack 2
|
I'm just trying to fix the travis error, and I'll publish the package right after. |
|
Travis is taking ages to start with the builds. |
|
Thank you for quick response! |
|
webpack 2 is now at 2.0.7-beta. Is it possible to specify "2.x-beta" or some such to avoid npm warning? or is the warning desired? |
|
The warning is not exactly desired, but as far I can tell, npm doens't work well with ranges and pre-releases. |
|
Yeah, you can’t include all future pre-releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Webpack 2 does not seem to have changes breaking this loader. In this PR, we explicitly enable the latest beta (since we have to specify exact prerelease versions in semver), as well as the stable 2.x when it comes out.