Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include BABEL_ENV || NODE_ENV in cacheIdentifier #113

Merged
merged 1 commit into from
Nov 9, 2015
Merged

Include BABEL_ENV || NODE_ENV in cacheIdentifier #113

merged 1 commit into from
Nov 9, 2015

Conversation

aaronjensen
Copy link
Contributor

babel configs can differ based on BABEL_ENV and NODE_ENV, so cache identifier should be different. This may have been the thing that caused #112

@aaronjensen aaronjensen changed the title cacheIdentifier should include BABEL_ENV || NODE_ENV Include BABEL_ENV || NODE_ENV in cacheIdentifier Oct 5, 2015
@Couto Couto merged commit e6b5c37 into babel:master Nov 9, 2015
@aaronjensen aaronjensen mentioned this pull request Nov 9, 2015
Closed
@Couto
Copy link
Member

Couto commented Nov 9, 2015

Thanks for the PR!
👍

@aaronjensen
Copy link
Contributor Author

np, thanks for the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aaronjensen @Couto