Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump node requirement to ^18.20.0 || ^20.10.0 || >=22.0.0 and webpack requirement to >= 5.61.0 #1026

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Jul 12, 2024

Please Read the CONTRIBUTING Guidelines
In particular the portion on Commit Message Formatting

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
Behaviour is not expected to change.

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

If this PR contains a breaking change, please describe the following...

  • Impact: Medium
    Dropped support for dead node.js versions and old webpack 5 versions.
  • Migration path for existing applications: Upgrade node.js to ^18.20.0 || ^20.10.0 || >=22.0.0 and webpack to >= 5.61.0 or pin babel-loader to 9
  • Github Issue(s) this is regarding:

Other information:
The webpack requirement is bumped to 5.61.0 as this is the first webpack version that supports the Node.js 18 change without the --openssl-legacy-provider switch: webpack/webpack@0f6c78c

@JLHwung
Copy link
Contributor Author

JLHwung commented Jul 12, 2024

As we can see from the CI, webpack 5.0.0 no longer works for the minimum Node.js 18.20.0, so we have to bump webpack requirements as well. I will try to find the first version that webpack 5 even supports Node.js 18.20.0.

@JLHwung JLHwung changed the title bump node requirements to ^18.20.0 || ^20.10.0 || >=22.0.0 bump node requirement to ^18.20.0 || ^20.10.0 || >=22.0.0 and webpack requirement to >= 5.61.0 Jul 12, 2024
@JLHwung JLHwung merged commit 7cba007 into main Jul 15, 2024
16 checks passed
@JLHwung JLHwung mentioned this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants