Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Previous loaders are included in the filepath passed to Babel plugins #106

Closed
dallonf opened this issue Sep 24, 2015 · 3 comments
Closed

Comments

@dallonf
Copy link

dallonf commented Sep 24, 2015

This issue is described in more detail over here, where I noticed the symptoms: formatjs/babel-plugin-react-intl#5

Basically, I have ts-loader set to run before babel-loader, and a plugin (babel-plugin-react-intl) that depends on file options being passed to it. When babel-plugin-react-intl receives the file information, the filename value is '<project directory>/node_modules/ts-loader/index.js!<project directory>/src/pages/asset/Page.tsx' - which it can't parse.

@johanneslumpe
Copy link

Just came across this issue today too - hope this can be fixed soon :)

@benmosher
Copy link

eslint-loader as a pre-loader + React Transform Babel plugin + Redbox error-catching with custom styles is how I stumbled onto this; the custom styles file got some crazy generated path on account of the loaders still being in the file path provided to Babel.

I suspect it's a pretty straightforward way to reproduce. I can try to conjure it back up, if that would be helpful.

Couto added a commit that referenced this issue Nov 17, 2015
@Couto
Copy link
Member

Couto commented Nov 17, 2015

This is now on v6.2.0
I'm closing this. Please re-open if something comes up

@Couto Couto closed this as completed Nov 17, 2015
Couto added a commit that referenced this issue Jan 4, 2016
* release/v6.2.0:
  Pass true filenames
  Fix styles that were breaking ci tests
  Remove babel-core/es2015 preset from devDependencies
  Pass true filenames #106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants