This repository has been archived by the owner on Aug 18, 2021. It is now read-only.
Reset TypeParameters to Identifier #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hzoo If you are okay with that we should also create a new release that works completely with babylon 6.8.1 |
This can be a TODO or we move all that functionality out as a separate thing/rule and make babel-eslint just the compat part. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new TypeParameter is currently not known by babel-eslint or eslint, so this fixes it by simply making it a Identifier again.
This could probably also have been done by doing more monkeypatching and making escope aware that TypeParameter exists and can be visited.
I also enabled some tests that were skipped, but are now working as it seems.