Class properties resulting in false positive #487

damianobarbati · 2017-06-13T14:20:00Z

In the following JS I get a "no-undef" on webpack compilation because of inputPicks and contextTypes static class properties but it does not happen firing ESLint from command line.

export default class Input extends React.Component {
    static contextTypes = {
        formName: PropTypes.string.isRequired,
    }

    static inputPicks = ['minLength', 'maxLength', 'pattern']

    constructor(props) {
        super(props, context);
    }
...and so on

Package.json

    "eslintConfig": {
        "parser": "babel-eslint",
        "parserOptions": {
            "ecmaVersion": 2017,
            "sourceType": "module",
            "impliedStrict": true,
            "ecmaFeatures": {
                "jsx": true,
                "experimentalObjectRestSpread": true
            }
        },
        "env": {
            "browser": true,
            "node": true,
            "jest": true,
            "es6": true
        },
        "plugins": [
            "import",
            "react",
            "jest"
        ],
        "extends": [
            "eslint:recommended",
            "plugin:react/recommended",
            "plugin:jest/recommended"
        ],
        "rules": {
            "no-console": "off",
            "no-unused-vars": "off",
            "no-unsafe-finally": "off",
            "react/no-unescaped-entities": "off",
            "react/prop-types": "off"
        }
    },

Dependencies:

    "devDependencies": {
        "autobind-decorator": "^1.3.4",
        "autoprefixer": "^7.1.1",
        "babel-core": "^6.7.4",
        "babel-eslint": "^7.1.1",
        "babel-loader": "7.0.0",
        "babel-plugin-react-css-modules": "^2.6.0",
        "babel-plugin-syntax-class-properties": "^6.13.0",
        "babel-plugin-transform-decorators-legacy": "^1.3.4",
        "babel-polyfill": "^6.20.0",
        "babel-preset-env": "2.0.0-alpha.3",
        "babel-preset-react": "^6.5.0",
        "babel-preset-stage-0": "^6.16.0",
        "babili": "^0.1.2",
        "babili-webpack-plugin": "^0.1.1",
        "clean-webpack-plugin": "0.1.16",
        "compression-webpack-plugin": "^0.4.0",
        "css-loader": "^0.28.4",
        "cssnano": "^3.10.0",
        "eslint": "^4.0.0",
        "eslint-loader": "^1.6.1",
        "eslint-plugin-import": "^2.2.0",
        "eslint-plugin-jest": "^20.0.3",
        "eslint-plugin-react": "^7.0.1",
        "extract-text-webpack-plugin": "^2.1.0",
        "favicons-webpack-plugin": "^0.0.7",
        "file-loader": "^0.11.1",
        "history": "^4.6.1",
        "html-webpack-plugin": "^2.25.0",
        "img-loader": "^2.0.0",
        "json-loader": "^0.5.4",
        "material-ui": "^0.18.1",
        "material-ui-community-icons": "^0.15.0",
        "node-sass": "^4.1.1",
        "open-browser-webpack-plugin": "^0.0.5",
        "postcss-load-config": "^1.1.0",
        "postcss-loader": "^2.0.5",
        "postcss-scss": "^1.0.0",
        "query-string": "^4.3.4",
        "react": "^15.4.1",
        "react-addons-perf": "^15.4.2",
        "react-create-app": "^1.0.3",
        "react-create-store": "^1.0.4",
        "react-dimensions": "^1.3.0",
        "react-dom": "^15.4.1",
        "react-ga": "^2.2.0",
        "react-highcharts": "^12.0.0",
        "react-moment": "^0.2.4",
        "react-redux": "^5.0.1",
        "react-router": "^4.1.1",
        "react-router-dom": "^4.1.1",
        "react-router-redux": "next",
        "react-sizeme": "^2.3.2",
        "react-svg-inline": "^2.0.0",
        "react-swipeable-views": "^0.12.3",
        "react-tap-event-plugin": "^2.0.0",
        "react-transition-group": "^1.1.3",
        "recompose": "^0.23.4",
        "redux": "^3.6.0",
        "redux-action-buffer": "^1.0.1",
        "redux-actions": "^2.0.3",
        "redux-devtools-extension": "^2.13.2",
        "redux-logger": "^3.0.6",
        "redux-persist": "^4.1.0",
        "redux-persist-crosstab": "^3.5.2",
        "redux-promise": "^0.5.3",
        "redux-thunk": "^2.1.0",
        "sass-loader": "^6.0.5",
        "string-replace-loader": "^1.2.0",
        "style-loader": "^0.18.2",
        "stylelint-config-sass-guidelines": "^2.1.0",
        "stylelint-config-standard": "^16.0.0",
        "stylelint-scss": "^1.4.4",
        "stylelint-webpack-plugin": "^0.7.0",
        "url-loader": "^0.5.8",
        "webpack": "^2.5.1",
        "webpack-bundle-analyzer": "^2.8.2",
        "webpack-chunk-hash": "^0.4.0",
        "webpack-notifier": "^1.5.0"
    }

The text was updated successfully, but these errors were encountered:

jsg2021 · 2017-06-13T15:48:25Z

I don't know where this bug is... here is the eslint ref
eslint/eslint#8720

damianobarbati · 2017-06-13T15:53:17Z

wow I didn't see that: did you just open the same issue some hours before I did? xD
Maybe something due to latest updates?

jsg2021 · 2017-06-13T16:49:41Z

I opened it last night, but they (eslint) suggested the bug may be here.
So I came here to report... but found yours :)

damianobarbati · 2017-06-14T10:31:19Z

This is serious.
In order to compile I'm now with "no-undef": "off": I just lost the whole morning (~3hours) to track down a simple not defined variable which eslint would spot in milliseconds.

kentcdodds · 2017-06-14T15:17:46Z

Sorry this is causing issues. I'm not familiar with the codebase much. Could someone dive in a bit and provide a suggested solution/pull request?

soda0289 · 2017-06-14T17:53:23Z

Is think broken in eslint 3.19 as well or just 4.0?

damianobarbati · 2017-06-15T09:24:25Z

@soda0289 hell yeah, fixed in 4.0! Thanks so much ( @jsg2021 )

jsg2021 · 2017-06-15T12:35:23Z

i don't see any changes in this or eslint... how is it fixed?

jsg2021 · 2017-06-15T12:36:46Z

@soda0289 this wasn't a problem in eslint 3.x.x

soda0289 · 2017-06-15T14:04:42Z

If this problem started with eslint v4 it probably has something to do with the new scope analysis fork eslint uses. It was changed from escope to eslint-scope.

I think the problem is that babel-eslint is failing to find and monkey patch eslint-scope. It might be finding escope from some other installation of eslint. How are you running eslint?

damianobarbati · 2017-06-15T14:08:57Z

Rules in package.json

    "eslintConfig": {
        "parser": "babel-eslint",
        "parserOptions": {
            "ecmaVersion": 2017,
            "sourceType": "module",
            "impliedStrict": true,
            "ecmaFeatures": {
                "jsx": true,
                "impliedStrict": true,
                "globalReturn": false,
                "experimentalObjectRestSpread": true
            }
        },
        "env": {
            "browser": true,
            "node": true,
            "jest": true,
            "es6": true
        },
        "plugins": [
            "import",
            "react",
            "jest"
        ],
        "extends": [
            "eslint:recommended",
            "plugin:react/recommended",
            "plugin:jest/recommended"
        ],
        "rules": {
            "no-console": "off",
            "no-unused-vars": "off",
            "no-unsafe-finally": "off",
            "no-unreachable": "off",
            "react/no-unescaped-entities": "off",
            "react/prop-types": "off"
        }
    },
    "stylelint": {
        "extends": [
            "stylelint-config-standard",
            "stylelint-config-sass-guidelines"
        ],
        "rules": {
            "indentation": 4,
            "no-missing-end-of-source-newline": null,
            "selector-list-comma-newline-after": null,
            "max-nesting-depth": null,
            "selector-pseudo-class-no-unknown": [
                true,
                {
                    "ignorePseudoClasses": [
                        "global",
                        "local"
                    ]
                }
            ]
        }
    },
    "babel": {
        "presets": [
            [
                "env",
                {
                    "targets": {
                        "browsers": [
                            "chrome 54",
                            "safari 9",
                            "firefox 50",
                            "edge 12",
                            "explorer 11"
                        ]
                    },
                    "modules": false,
                    "useBuiltIns": true,
                    "debug": true
                }
            ],
            "stage-0",
            "react"
        ],
        "plugins": [
            "transform-decorators-legacy",
            "transform-class-properties",
            [
                "react-css-modules",
                {
                    "filetypes": {
                        ".scss": "postcss-scss"
                    }
                }
            ]
        ]
    },
    "jest": {
        "bail": true
    },
    "dependencies": {
        "array-to-csv": "^1.0.1",
        "axios": "^0.16.2",
        "better-console": "^1.0.0",
        "child-process-promise": "^2.2.1",
        "compare-versions": "^3.0.1",
        "cssnano-preset-default": "^4.0.0-rc.0",
        "csv-parse": "^1.2.0",
        "csvjson": "^4.3.3",
        "docdash": "^0.4.0",
        "esdoc": "^0.5.2",
        "fs-promise": "^2.0.2",
        "jest": "^20.0.4",
        "jsdoc": "^3.4.3",
        "jsdoc-strip-async-await": "^0.1.0",
        "jws": "^3.1.4",
        "koa": "^2.2.0",
        "koa-basic-auth": "^2.0.0",
        "koa-better-ratelimit": "^2.1.2",
        "koa-body": "^2.1.0",
        "koa-compress": "^2.0.0",
        "koa-cors": "0.0.16",
        "koa-json": "^2.0.2",
        "koa-mount": "^3.0.0",
        "koa-passport": "^3.0.0",
        "koa-remove-trailing-slashes": "1.0.0",
        "koa-router": "^7.2.0",
        "koa-send": "^4.1.0",
        "koa-sslify": "^2.1.2",
        "koa-useragent": "^1.0.0",
        "lodash": "^4.17.4",
        "moment": "^2.18.1",
        "moment-timezone": "^0.5.13",
        "mz": "^2.6.0",
        "node-schedule": "^1.1.1",
        "node-xlsx": "^0.7.4",
        "nodemailer": "^4.0.1",
        "passport": "^0.3.2",
        "passport-facebook": "^2.1.1",
        "passport-google-oauth": "^1.0.0",
        "pm2": "^2.4.4",
        "sequelize": "^4.1.0",
        "slack-node": "^0.1.8",
        "sleep-promise": "^2.0.0",
        "sqlite3": "^3.1.8",
        "stripe": "^4.22.0",
        "tsv": "^0.2.0",
        "xlsx-populate": "^1.6.0",
        "yargs": "^8.0.1"
    },
    "devDependencies": {
        "autobind-decorator": "^1.3.4",
        "autoprefixer": "^7.1.1",
        "babel-core": "^6.7.4",
        "babel-eslint": "^7.1.1",
        "babel-loader": "7.0.0",
        "babel-plugin-react-css-modules": "^2.6.0",
        "babel-plugin-syntax-class-properties": "^6.13.0",
        "babel-plugin-transform-decorators-legacy": "^1.3.4",
        "babel-polyfill": "^6.20.0",
        "babel-preset-env": "2.0.0-alpha.3",
        "babel-preset-react": "^6.5.0",
        "babel-preset-stage-0": "^6.16.0",
        "babili": "^0.1.3",
        "babili-webpack-plugin": "^0.1.0",
        "case-sensitive-paths-webpack-plugin": "^2.1.1",
        "clean-webpack-plugin": "0.1.16",
        "compression-webpack-plugin": "^0.4.0",
        "css-loader": "^0.28.4",
        "cssnano": "^3.10.0",
        "deep-diff": "^0.3.8",
        "eslint": "^4.0.0",
        "eslint-loader": "^1.8.0",
        "eslint-plugin-import": "^2.2.0",
        "eslint-plugin-jest": "^20.0.3",
        "eslint-plugin-react": "^7.1.0",
        "extract-text-webpack-plugin": "^2.1.0",
        "favicons-webpack-plugin": "^0.0.7",
        "file-loader": "^0.11.1",
        "history": "^4.6.2",
        "html-webpack-plugin": "^2.25.0",
        "img-loader": "^2.0.0",
        "json-loader": "^0.5.4",
        "material-ui": "^0.18.1",
        "material-ui-community-icons": "^0.15.0",
        "node-sass": "^4.1.1",
        "open-browser-webpack-plugin": "^0.0.5",
        "postcss-load-config": "^1.1.0",
        "postcss-loader": "^2.0.5",
        "postcss-scss": "^1.0.0",
        "query-string": "^4.3.4",
        "react": "^15.6.1",
        "react-addons-perf": "^15.4.2",
        "react-create-app": "^1.0.3",
        "react-create-store": "^1.0.4",
        "react-dimensions": "^1.3.0",
        "react-dom": "^15.6.1",
        "react-ga": "^2.2.0",
        "react-highcharts": "^12.0.0",
        "react-moment": "^0.2.4",
        "react-redux": "^5.0.1",
        "react-router": "^4.1.1",
        "react-router-dom": "^4.1.1",
        "react-router-redux": "next",
        "react-sizeme": "^2.3.2",
        "react-svg-inline": "^2.0.0",
        "react-swipeable-views": "^0.12.3",
        "react-tap-event-plugin": "^2.0.0",
        "react-transition-group": "^1.1.3",
        "recompose": "^0.23.4",
        "redux": "^3.6.0",
        "redux-action-buffer": "^1.0.1",
        "redux-actions": "^2.0.3",
        "redux-devtools-extension": "^2.13.2",
        "redux-logger": "^3.0.6",
        "redux-persist": "^4.1.0",
        "redux-persist-crosstab": "^3.5.2",
        "redux-promise": "^0.5.3",
        "redux-thunk": "^2.1.0",
        "sass-loader": "^6.0.6",
        "string-replace-loader": "^1.2.0",
        "style-loader": "^0.18.2",
        "stylelint-config-sass-guidelines": "^2.1.0",
        "stylelint-config-standard": "^16.0.0",
        "stylelint-scss": "^1.4.4",
        "stylelint-webpack-plugin": "^0.7.0",
        "url-loader": "^0.5.8",
        "webpack": "^2.5.1",
        "webpack-bundle-analyzer": "^2.8.2",
        "webpack-chunk-hash": "^0.4.0",
        "webpack-notifier": "^1.5.0"
    }
}

jsg2021 · 2017-06-15T15:21:37Z

I'm on npm 5, node 8.
I execute eslint by: eslint --ext .js,.jsx ./src
my eslint config is pretty simple...

{
	extends: 'eslint:recommended',
	parser: 'babel-eslint',
	parserOptions: {
		ecmaVersion: 2017,
		sourceType: 'module',
		ecmaFeatures: {
			experimentalObjectRestSpread: true,
			impliedStrict: true,
			globalReturn: false
		}
	},

	env: {
		es6: true,
		node: true,
		browser: true,
		jest: true
	}
}

eslint is only depended on once in my package.

soda0289 · 2017-06-15T15:27:05Z

@jsg2021

So you are using the globally installed eslint. Can you try the locally installed one:
node node_modules/.bin/eslint --ext .js,.jsx ./src

jsg2021 · 2017-06-15T15:32:55Z

that was the local one. I have ./node_modules/.bin/ on my path. I don't use global packages.

damianobarbati · 2017-06-15T15:34:42Z

I'm always local:

    "scripts": {
        "pm2": "./node_modules/pm2/bin/pm2",
        "lint": "./node_modules/eslint/bin/eslint.js --ignore-path .gitignore --ignore-pattern **/*.min.js .",

Lyncredible · 2017-06-16T21:43:10Z

Why is this issue closed? There are multiple reports here and in eslint:
eslint/eslint#8720

ryanzec · 2017-06-30T15:31:16Z

This issue was resolved for me when upgrading to 7.2.2 (might have even worked before that, only know it did not work with 6.1.2).

backjo · 2017-07-25T01:40:03Z

Occurs for me on 7.2.2 and eslint 4.3.0

ChristianGrete · 2017-07-27T08:04:14Z

Same here on 7.2.3 and ESLint 4.3.0.

AdamMcCormick · 2017-07-28T22:34:59Z

This was fixed for us (node 6.2.0) by explicitly invoking the ./node_modules/eslint/bin/eslint.js script rather than using the binary in ./node_modules/.bin/eslint I would suggest that perhaps there's some issue with the binary being generated in 4.3.x?

jsg2021 · 2017-07-28T22:45:06Z

It just went away for me... don't know when/how it changed.
I'm on node 8.2.1, npm 5.3.0, latest eslint 4.x, latest babel 6.x, babel-eslint 7.x

hsingh23 · 2017-07-31T19:50:32Z

I'm having this problem with node v6.11.1, npm 5.3, [email protected], babel-eslint@^7.2.3 [email protected] [email protected]

chiharahwost · 2017-08-01T08:40:09Z

Same for me! ALARM!

mikecfisher · 2017-08-10T21:05:03Z

I can confirm I'm having this same issue as well. no-undef false positive with babel-esint: 7.2.3 and eslint: 4.4.1

colinweight · 2017-08-11T00:02:01Z

I was getting this just in the webpack build, and not when running eslint from the command line. I deleted the node_modules folder and did a yarn install and all the problems went away. babel-esint: 7.2.3 and eslint: 4.4.1

ctumolosus · 2017-08-12T12:15:32Z

FWIW it appears to occur when packages are installed with Yarn instead of NPM. Running npm rebuild after a fresh yarn install fixes the problem for me.

This is the content of the package.json file:

{
  ...
  "scripts": {
    ...
    "lint": "eslint --cache --ext .jsx,.js .",
    ...
  },
  ...
  "devDependencies": {
    ...
    "eslint": "4.4.1",
    "eslint-plugin-import": "2.7.0",
    "eslint-plugin-jsx-a11y": "5.1.1",
    "eslint-plugin-react": "7.2.0",
    ...
  },
  ...
}

These are the versions of Node, NPM, and Yarn running on my machine:

node --version
v6.11.2

npm --version
3.10.10

yarn --version
0.27.5

hkmarques · 2018-03-02T18:19:41Z

With eslint at ^4.18.1 and babel-eslint at ^8.2.2 the issue is gone for me.

If, like me, you have a global installation of eslint, you might want to check where the command is being run from. In my case the eslint version inside the project dependencies, where it was being run from, was an older one. After updating the dependency, props are no longer producing lint errors for me. Hope this helps!

atian25 · 2018-03-24T02:58:37Z

hey, it seems this still break eslint@3, maybe should pick a patch?

Bobgy · 2018-04-18T13:34:57Z

I verified it's caused by the monkey patch.
I started with the following versions and it worked perfectly.

"eslint": "^3.19.0",
"babel-eslint": "^7.2.3",

Then, after I upgraded to webpack 4, everything broke without changing any eslint related versions.
I found that webpack 4 introduced eslint-scope as a new dependency, and it seems like babel-eslint will try to use this eslint-scope instead of its own dependency escope.

I verified this by doing npm rm eslint-scope and run eslint again, then the eslint error goes away.

I don't know an easy way to get rid of eslint-scope, so I chose to upgrade to latest versions of eslint 4 and eslint-babel 8 in the end.

SethDavenport · 2018-04-25T17:35:15Z

What @Bobgy said - just experienced the same thing with the same versions after an update to webpack 4.

purdrew · 2018-07-12T22:16:09Z

Just ran into this issue when I bumped the version of an unrelated dependency (not eslint/webpack/babel-eslint). Our organization has numerous modules using eslint v3 and babel-eslint v7. One common dependency was updated that uses eslint v4. This caused eslint-scope to bubble up to the top node_modules directory which switched eslint v3 to now load it. This resulted in all our module eslints now falsely failing for no-undef errors for things like static class properties.

Seems like this issue should really be addressed as bringing in an unrelated dependency should not cause this sort of side affect.

xuqinggang · 2018-07-25T09:03:47Z

upgrade eslint latest
npm i -D eslint@latest

Tapppi · 2018-09-17T19:51:58Z

This bug is back with babel-eslint@^9 and instance fields containing bound methods:

class asdf {
  m = () => { // <-- BORK rule: 'no-undef', add eslint-disable-next-line no-undef above to workaround

  }
}

croraf · 2018-10-07T19:13:38Z

Same issue:

    "eslint": "^4.13.1",
    "babel-eslint": "^10.0.1",
node: 10.10.0

class CustomDialog extends React.Component {
    state = {  // <----[eslint] 'state' is not defined. (no-undef)
        open: false,
    };

kryops · 2018-11-12T10:45:35Z

In a yarn workspace, you can prevent hoisting of the problematic eslint-scope package with the following config in your package.json:

"workspaces": {
  "packages": [
    "packages/*"
  ],
  "nohoist": [
    "**/eslint-scope"
  ]
},

Tanatcu · 2018-12-22T18:52:58Z

I updated all my packages, see my package.json:

"devDependencies": {
    "babel-eslint": "^8.2.1",
    "eslint": "^4.16.0",
    "eslint-config-airbnb": "^16.1.0",
    "eslint-plugin-import": "^2.8.0",
    "eslint-plugin-jsx-a11y": "^6.0.3",
    "eslint-plugin-react": "^7.5.1"
  },

and my .eslintrc is so

"parser": "babel-eslint",
  "extends": "airbnb",
  "plugins": [
    "react",
    "jsx-a11y",
    "import"
 ],

I hope I can have helped

It's worked for me!

can add back, but @storybook/react so far behind everything else... was causing hidden chaos in dev. See babel/babel-eslint#487 (comment)

linxiaowu66 · 2019-06-03T00:55:18Z

In a yarn workspace, you can prevent hoisting of the problematic eslint-scope package with the following config in your package.json:
"workspaces": {
  "packages": [
    "packages/*"
  ],
  "nohoist": [
    "**/eslint-scope"
  ]
},

@kryops this method is work for me! 👏

chenop · 2019-06-16T12:52:38Z

Upgrading to:
{
"eslint": "^5.16.0",
"babel-eslint": "^10.0.1",
}

Solved the issue for me.

robbykim · 2019-10-03T13:47:43Z

Having these issues with:
{
"eslint": "^3.1.0",
"babel-eslint: "^9.0.0"
}

swen-ihealthlabs · 2019-10-17T10:00:47Z

Having the same issue with
{
"eslint": "^3.6.0",
"babel-eslint": "^9.0.0","
}
Unfortunately upgrade to

{
"eslint": "^5.16.0",
"babel-eslint": "^10.0.1",
}

doesn't work for me

ahmad-reza619 · 2019-11-26T02:59:17Z

Any update on this issue? i have the same problem btw after upgrading babel from v6 to v7. using eslint 3.19.0 and babel eslint version 9.0.0

congcongcong250 · 2019-12-11T05:45:21Z

Since people (including me recently) are still running into this issue, and I just spent quite some time figuring it out, I would like to post a long answer with some reference.

TL;DR

This should be solved by

{
    "eslint": ">=4.14.0",
    "babel-eslint": ">=8.1.0"
}

with fix from eslint/eslint PR#8755,
and fix from babel/babel-eslint PR#542.
Thanks to @mysticatea for the hard work.

Explanation:
This is a issue caused by the 'scope analyze' in eslint. In the older version (<4.14.0), eslint analyze the scope by its own without passing in the correct childVisitorKeys attribute.

// eslint.js
// gather scope data that may be needed by the rules
scopeManager = escope.analyze(ast, {
    ignoreEval: true,
    nodejsScope: ecmaFeatures.globalReturn,
    impliedStrict: ecmaFeatures.impliedStrict,
    ecmaVersion,
    sourceType: currentConfig.parserOptions.sourceType || "script",
    fallback: Traverser.getKeys
});

https://github.com/eslint/eslint/blob/421aab44a9c167c82210bed52f68cf990b7edbea/lib/eslint.js#L892

A correct scope after parser.parse() requires corresponding childVisitorKeys defined by different parser, as PR#8755 explains.

After those two PRs, babel-eslint will generate the scopeManager with its own modification.
eslint will consume the scopeManager (const scopeManager = parseResult.scopeManager;), and apply rules over it.

Take away:
It costs time to locate the root cause for this kind of issue if you are not familiar with the massive project like eslint (or ast concept), not to mention it normally comes with several more issues together. If you really want to do the research, start from the rules folder and analyze specific rule to get two cents about what goes wrong, in this case, it's the scope. It would be much easier then to narrow down your research in scope-related logic in parse().

The easy way to 'just make things work' is always upgrade version.

dancherb · 2019-12-30T00:29:33Z

Getting this issue (using React Native).

I previously only had "eslint-config-rallycoding": "^3.2.0" in my dev dependencies and eslint installed globally and everything was going smoothly. I had to install babel-eslint 7.2.1 to get operator chaining (a?.b) working without errors.

This then caused this issue where arrow functions on classes were "undefined". I upgraded to the latest babel-eslint, and this gave me the error that it couldn't find "eslint-scope".

~~Installing the latest eslint in dev dependencies then caused files to stop linting at all.~~

After installing the latest eslint in dev dependencies, renaming the workspace folder and restarting VSCode seemed to reset things and got everything working.

kaicataldo · 2020-08-04T00:22:02Z

Thank you for the issue. Now that @babel/eslint-parser has been released, we are making this repository read-only. If this is a change you would still like to advocate for, please reopen this in the babel/babel monorepo.

damianobarbati changed the title ~~Class properties false positive~~ Class properties resulting in false positive Jun 13, 2017

damianobarbati closed this as completed Jun 15, 2017

damianobarbati reopened this Jun 24, 2017

not-an-aardvark mentioned this issue Jul 11, 2017

no-undef false positive on class properties/fields. eslint/eslint#8720

Closed

popomore mentioned this issue Feb 28, 2018

feat: egg-bin check eggjs/egg-bin#87

Merged

4 tasks

samouri mentioned this issue Mar 16, 2018

eslint: fix no-undef for static properties Automattic/wp-calypso#23382

Merged

adonespitogo mentioned this issue Mar 18, 2018

fix eslint issues zinserjan/mocha-webpack#212

Closed

samouri mentioned this issue Apr 18, 2018

test circleci transform-class Automattic/wp-calypso#24308

Merged

egucciar mentioned this issue Apr 19, 2018

Breaks Eslint in Project cypress-io/cypress-webpack-preprocessor#18

Closed

WooodHead mentioned this issue May 5, 2018

ESlint error: solved by upgrade eslint and babel-eslint version. react-boilerplate/react-boilerplate#2205

Closed

This was referenced Oct 7, 2018

warning 'state' is not defined. #529

Closed

'state' is not defined no-undef #682

Closed

imlucas added a commit to mongodb-js/compass-sidebar that referenced this issue May 9, 2019

Remove old unused storybook stuff

1edd432

can add back, but @storybook/react so far behind everything else... was causing hidden chaos in dev. See babel/babel-eslint#487 (comment)

imlucas added a commit to mongodb-js/compass-sidebar that referenced this issue May 24, 2019

Remove old unused storybook stuff

1dbe699

can add back, but @storybook/react so far behind everything else... was causing hidden chaos in dev. See babel/babel-eslint#487 (comment)

kaicataldo closed this as completed Aug 4, 2020

osheroff mentioned this issue Feb 23, 2021

Fix annotations example katspaugh/wavesurfer.js#2194

Closed

Class properties resulting in false positive #487

Class properties resulting in false positive #487

Comments

damianobarbati commented Jun 13, 2017 • edited Loading

jsg2021 commented Jun 13, 2017

damianobarbati commented Jun 13, 2017

jsg2021 commented Jun 13, 2017 • edited Loading

damianobarbati commented Jun 14, 2017

kentcdodds commented Jun 14, 2017

soda0289 commented Jun 14, 2017

damianobarbati commented Jun 15, 2017

jsg2021 commented Jun 15, 2017

jsg2021 commented Jun 15, 2017

soda0289 commented Jun 15, 2017

damianobarbati commented Jun 15, 2017

jsg2021 commented Jun 15, 2017 • edited Loading

soda0289 commented Jun 15, 2017

jsg2021 commented Jun 15, 2017

damianobarbati commented Jun 15, 2017

Lyncredible commented Jun 16, 2017

ryanzec commented Jun 30, 2017

backjo commented Jul 25, 2017

ChristianGrete commented Jul 27, 2017

AdamMcCormick commented Jul 28, 2017 • edited Loading

jsg2021 commented Jul 28, 2017

hsingh23 commented Jul 31, 2017 • edited Loading

chiharahwost commented Aug 1, 2017

mikecfisher commented Aug 10, 2017 • edited Loading

colinweight commented Aug 11, 2017

ctumolosus commented Aug 12, 2017 • edited Loading

hkmarques commented Mar 2, 2018

atian25 commented Mar 24, 2018

Bobgy commented Apr 18, 2018 • edited Loading

SethDavenport commented Apr 25, 2018

purdrew commented Jul 12, 2018

xuqinggang commented Jul 25, 2018

Tapppi commented Sep 17, 2018

croraf commented Oct 7, 2018

kryops commented Nov 12, 2018

Tanatcu commented Dec 22, 2018

linxiaowu66 commented Jun 3, 2019

chenop commented Jun 16, 2019

robbykim commented Oct 3, 2019

swen-ihealthlabs commented Oct 17, 2019 • edited Loading

ahmad-reza619 commented Nov 26, 2019

congcongcong250 commented Dec 11, 2019 • edited Loading

TL;DR

dancherb commented Dec 30, 2019 • edited Loading

kaicataldo commented Aug 4, 2020

damianobarbati commented Jun 13, 2017 •

edited

Loading

jsg2021 commented Jun 13, 2017 •

edited

Loading

jsg2021 commented Jun 15, 2017 •

edited

Loading

AdamMcCormick commented Jul 28, 2017 •

edited

Loading

hsingh23 commented Jul 31, 2017 •

edited

Loading

mikecfisher commented Aug 10, 2017 •

edited

Loading

ctumolosus commented Aug 12, 2017 •

edited

Loading

Bobgy commented Apr 18, 2018 •

edited

Loading

swen-ihealthlabs commented Oct 17, 2019 •

edited

Loading

congcongcong250 commented Dec 11, 2019 •

edited

Loading

dancherb commented Dec 30, 2019 •

edited

Loading