-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ns meta to a handful of clojure.core dynamic vars #597
Conversation
I think we could just add this metadata at the place where these vars are first created. |
I thought about that, but it didn't work out in my head, so I'm hoping you can point out where I'm tripped up on this. We can't pull the namespace object from We could create the namespace just once in |
@bobisageek We can put these ns objects in sci.impl.utils. |
O wait, that doesn't work because of the cyclic dep. |
Yeah, let's do sci.impl.vars. To be fair, that namespace is also about namespaces, not only vars. So it seems fine. |
Awesome. I'll see if I can make some headway on this after work today. |
- create clojure core ns in sci.impl.vars - refer to vars ns in io and namespaces - "alias" clojure-core-ns in namespaces to maintain babashka.main's reference (for now)
This may seem a little bit convoluted, but I left the I sincerely hope I'm not being more annoyance than help. :) |
I sincerely think you're being very helpful! |
Because the vars are already marked dynamic, we can't just use core-var (without adding more arguments or something), so I added the function for just tweaking the metadata on the dynamic vars. As always, I'm happy to revise it if there's a different preferred approach.