Optimize TypeORM DB Usage#643
Closed
sorenjohanson wants to merge 11 commits into
Closed
Conversation
…son/teammapper into 593-optimize-typeorm-db-usage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #593.
This PR adds an hourly logging mechanism for the database, which will show queries executed, most common query patterns and potential N+1 queries. It also adds the ability to log an analysis on the spot using
getAnalysis(). The logger is very simple and file-based.Here is an up to date analysis using the analyzer:
typeorm-analysis.log
I've decided to log the full stack trace when discovering potential N+1 queries because sometimes the actual file where the query is executed is at the top, sometimes at the bottom. It also logs the full query minus parameters in "Top 5 Query Patterns", so it's GDPR-compatible.
There are some obvious optimisations in the diff callbacks, some of which I've already implemented.