Improve DialogResult extension

Add null check
b-straub · Jul 1, 2024 · 6b6849d · 6b6849d
1 parent f9e42c6
commit 6b6849d
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/RxMudBlazorLight/Extensions/RxMudBlazorLightExtensionsExtern.cs b/RxMudBlazorLight/Extensions/RxMudBlazorLightExtensionsExtern.cs
@@ -1,10 +1,11 @@
-using MudBlazor;
+using System.Diagnostics.CodeAnalysis;
+using MudBlazor;
 
 namespace RxMudBlazorLight.Extensions
 {
     public static class RxMudBlazorLightExtensionsExtern
     {
-        public static bool OK(this DialogResult? result)
+        public static bool OK([NotNullWhen(true)] this DialogResult? result)
         {
             return result is not null && !result.Canceled;
         }

diff --git a/RxMudBlazorLight/RxMudBlazorLight.csproj b/RxMudBlazorLight/RxMudBlazorLight.csproj
@@ -25,7 +25,7 @@
         <PackageTags>Blazor,MudBlazor,Rx,Reactive</PackageTags>
         <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
         <PackageOutputPath>..\Nuget</PackageOutputPath>
-        <PackageVersion>0.9.3</PackageVersion>
+        <PackageVersion>0.9.4</PackageVersion>
     </PropertyGroup>
 
     <ItemGroup>

diff --git a/RxMudBlazorLightTestBase/CRUD/CRUDItemAddOrUpdate.razor b/RxMudBlazorLightTestBase/CRUD/CRUDItemAddOrUpdate.razor
@@ -25,7 +25,7 @@ else
         var dialog = await DialogService.ShowAsync<CRUDItemDialog>(AddMode ? "Add ToDo" : "Edit ToDo", parameters);
         var result = await dialog.Result;
 
-        if (result is not null && !result.Canceled)
+        if (result.OK())
         {
             var scope = (CrudService.CrudItemInput?)result.Data;
             if (scope is not null)

diff --git a/RxMudBlazorLightTestBase/Components/ButtonTest.razor b/RxMudBlazorLightTestBase/Components/ButtonTest.razor
@@ -131,7 +131,7 @@
 
         var res = await dialog.Result;
 
-        if (res is not null && !res.Canceled)
+        if (res.OK())
         {
             c.NotifyChanging();
             await Task.Delay(4000, c.CancellationToken);