Skip to content

chore: cleanup and release #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 10, 2025
Merged

chore: cleanup and release #93

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
736f544
fix: don't inspect without auth
b-long Sep 10, 2025
3949cb7
fix: process otdf-python-proto/pyproject.toml correctly
b-long Sep 10, 2025
7fbbf1c
chore: remove NanoTDF from README
b-long Sep 10, 2025
a883578
chore: mention legacy version in main README
b-long Sep 10, 2025
cb3a5b8
chore: set version to 0.3.1
b-long Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 1 addition & 14 deletions src/otdf_python/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,21 +355,8 @@ def cmd_inspect(args):
# Validate input file
input_path = validate_file_exists(args.file)

# For inspection, try to create authenticated SDK, but allow unauthenticated inspection too
try:
try:
sdk = build_sdk(args)
except CLIError as auth_error:
# If authentication fails, create minimal SDK for basic inspection
logger.warning(f"Authentication failed, using minimal SDK: {auth_error}")
builder = SDKBuilder()
if args.platform_url:
builder.set_platform_endpoint(args.platform_url)
if hasattr(args, "plaintext") and args.plaintext:
builder.use_insecure_plaintext_connection(True)
if args.insecure:
builder.use_insecure_skip_verify(True)
sdk = builder.build()
Comment on lines 358 to -372
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change removes the logic for creating a 'minimal' SDK for unauthenticated inspection, which appears to be a functional regression. Previously, it was possible to inspect a TDF's manifest without providing authentication credentials, as the code would fall back to a minimal SDK capable of parsing the TDF structure. With this change, any authentication failure during SDK building results in a very basic inspection that only reports file type and size, losing the valuable ability to view the manifest without full credentials. If retaining unauthenticated manifest inspection is desired, the previous logic should be restored, possibly in a more robust implementation.

sdk = build_sdk(args)

try:
# Read encrypted file
Expand Down
Loading