Skip to content

feat: configure release-please #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 4, 2025
Merged

feat: configure release-please #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ba8c9a
chore: add '.release-please-manifest.json'
b-long Sep 4, 2025
97e3e4e
chore: bump version 0.2.19 -> 0.2.20
b-long Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-golang-macos.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,4 @@ jobs:

# - uses: ./.github/workflows/platform-integration-test.yaml
# with:
# wheel: dist/otdf_python-0.2.19-py3-none-any.whl
# wheel: dist/otdf_python-0.2.20-py3-none-any.whl
6 changes: 3 additions & 3 deletions .github/workflows/build-golang-ubuntu.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,12 @@ jobs:

- uses: actions/cache/restore@v4
with:
path: dist/otdf_python-0.2.19-py3-none-any.whl
path: dist/otdf_python-0.2.20-py3-none-any.whl
key: ${{ runner.os }}${{ matrix.python3_version }}-data-${{ github.sha }}

- uses: actions/cache/save@v4
with:
path: dist/otdf_python-0.2.19-py3-none-any.whl
path: dist/otdf_python-0.2.20-py3-none-any.whl
key: ${{ runner.os }}${{ matrix.python3_version }}-data-${{ github.sha }}
restore-keys: |
${{ runner.os }}${{ matrix.python3_version }}-data-
Expand All @@ -61,5 +61,5 @@ jobs:
needs: build
uses: ./.github/workflows/platform-integration-test.yaml
with:
wheel: dist/otdf_python-0.2.19-py3-none-any.whl
wheel: dist/otdf_python-0.2.20-py3-none-any.whl
python_version: ${{ matrix.python3_version }}
2 changes: 1 addition & 1 deletion .github/workflows/platform-integration-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:

- uses: actions/cache/restore@v4
with:
path: dist/otdf_python-0.2.19-py3-none-any.whl
path: dist/otdf_python-0.2.20-py3-none-any.whl
key: ${{ runner.os }}${{ inputs.python_version }}-data-${{ github.sha }}

- name: Prove that the input file is available
Expand Down
3 changes: 3 additions & 0 deletions .release-please-manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
".": "0.2.20"
}
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ Install from the [Python Package Index (PyPI)](https://pypi.org):
pip install otdf_python

# Install a pinned version
pip install otdf-python==0.2.19
pip install otdf-python==0.2.20

# Install a pinned version, from test.pypi.org
pip install -i https://test.pypi.org/simple/ otdf-python==0.2.19
pip install -i https://test.pypi.org/simple/ otdf-python==0.2.20
```

## Usage
Expand Down
2 changes: 1 addition & 1 deletion build-scripts/ci-build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,4 +72,4 @@ echo "✨✨✨ Build wheel"
poetry run python3 setup.py bdist_wheel

echo "✨✨✨ Install wheel"
pip install dist/otdf_python-0.2.19-py3-none-any.whl
pip install dist/otdf_python-0.2.20-py3-none-any.whl
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Hardcoding the version number in the wheel filename makes the build script brittle as it needs to be updated for every release. Using a wildcard (glob) to find the wheel file would make this script more robust and reduce maintenance for version bumps.

Suggested change
pip install dist/otdf_python-0.2.20-py3-none-any.whl
pip install dist/otdf_python-*-py3-none-any.whl

2 changes: 1 addition & 1 deletion build-scripts/make_and_validate_script.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ python3 -m pip install --upgrade setuptools wheel
python3 setup.py bdist_wheel

# Prove that the wheel can be installed
pip install dist/otdf_python-0.2.19-py3-none-any.whl
pip install dist/otdf_python-0.2.20-py3-none-any.whl
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Hardcoding the version number in the wheel filename makes the build script brittle as it needs to be updated for every release. Using a wildcard (glob) to find the wheel file would make this script more robust and reduce maintenance for version bumps.

Suggested change
pip install dist/otdf_python-0.2.20-py3-none-any.whl
pip install dist/otdf_python-*-py3-none-any.whl


if [[ "$SKIP_TESTS" == "-s" || "$SKIP_TESTS" == "--skip-tests" ]]; then
echo "Build is complete, skipping tests."
Expand Down
2 changes: 1 addition & 1 deletion build-scripts/uv_make_and_validate_script.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ loud_print "Installing wheel"
uv venv .venv-wheel --python 3.12 "$PY_TYPE"
source "${BUILD_ROOT}/.venv-wheel/bin/activate"
pip install pybindgen
pip install dist/otdf_python-0.2.19-py3-none-any.whl
pip install dist/otdf_python-0.2.20-py3-none-any.whl
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Hardcoding the version number in the wheel filename makes the build script brittle as it needs to be updated for every release. Using a wildcard (glob) to find the wheel file would make this script more robust and reduce maintenance for version bumps.

Suggested change
pip install dist/otdf_python-0.2.20-py3-none-any.whl
pip install dist/otdf_python-*-py3-none-any.whl


if [[ "$SKIP_TESTS" == "-s" || "$SKIP_TESTS" == "--skip-tests" ]]; then
echo "Build is complete, skipping tests."
Expand Down
4 changes: 2 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[project]
name = "otdf-python"
# Should match 'setup.py' version number (used for gopy/pybindgen)
version = "0.2.19"
version = "0.2.20"
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The project version is duplicated across several files (pyproject.toml, setup.py, setup_ci.py, uv.lock, and hardcoded in build scripts). This increases the maintenance burden and risk of inconsistencies during version updates. It's a best practice to have a single source of truth for the version number.

Consider defining the version only in pyproject.toml and dynamically reading it in other files like setup.py. While release-please seems to be handling the updates, this change would improve the project's maintainability.

description = "Unofficial OpenTDF SDK for Python."
authors = [
{name="b-long", email="[email protected]"}
Expand All @@ -19,7 +19,7 @@ pybindgen = "^0.22.1"

[tool.poetry]
package-mode = false
version = "0.2.19"
version = "0.2.20"

[tool.poetry.dependencies]
python = ">=3.10,<3.14"
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
url="https://github.com/b-long/opentdf-python-sdk",
package_data={"otdf_python": ["*.so"]},
# Should match 'pyproject.toml' version number
version="0.2.19",
version="0.2.20",
author_email="[email protected]",
include_package_data=True,
)
2 changes: 1 addition & 1 deletion setup_ci.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ def build_extension(self, ext: Extension):

setuptools.setup(
name="otdf_python",
version="0.2.19",
version="0.2.20",
author="b-long",
description="Unofficial OpenTDF SDK for Python.",
long_description_content_type="text/markdown",
Expand Down
2 changes: 1 addition & 1 deletion uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading