Support for Deno v1.13 FFI

[jjallaire]

With the release of v1.13 Deno has replaced their native Rust plugin system with a more generic FFI interface (https://deno.com/blog/v1.13#experimental-ffi-replaces-native-plugin-system). Sadly Deno.openPlugin is now gone so deno_dom doesn't work w/ v1.13 and higher.

Are there plans to implement an FFI compatible version of deno_dom? We'd be happy to contribute to this effort if you can point us in the right direction.

[b-fuze]

Yes, I plan to implement it. If you're interested you can take a jab at it. However, the new FFI feature doesn't support buffers yet. It can only pass number types. When they implement buffers I'll definitely get the native backend working again.

For reference, here's the (open as of this writing) PR tracking string and buffer support for the new FFI interface denoland/deno#11648

[jjallaire]

Okay, great to know that FFI is on your radar and hope that the string and buffer support lands soon.

I think that #64 would likely be enough for us until FFI lands, in the case that we did also want to try using the native plugin version (as that would give us the perf win both at load time for deno_dom code path and of course at runtime) do you still have reservations about the Deno plugin system stability? (saw these noted here: #48). We'd be running with Deno v1.12.2 (the last version to support native plugins).

[b-fuze]

do you still have reservations about the Deno plugin system stability?

Yes. The previous incarnation (that Deno DOM implements currently) of the plugin system was very unstable. If you want to use the last stable version of the native plugin you'll need to use v0.1.9-alpha with Deno v1.9 as v1.10 introduced the new and buggy native plugin interface.

[jjallaire]

Okay in that case I think we’ll stick with WASM for now as we need some bundler improvements introduced after v1.9

…

On Sun, Sep 5, 2021 at 5:17 PM b-fuze ***@***.***> wrote: do you still have reservations about the Deno plugin system stability? Yes. The previous incarnation of the plugin system was very unstable. If you want to use the last stable version of the native plugin you'll need to use v0.1.9-alpha with Deno v1.9 as v1.10 introduced the new and buggy native plugin interface. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#63 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAZPR2NQBQKD5ORT6V3BV3UAPM5FANCNFSM5DPC6YYA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[b-fuze]

Deno DOM Native works with FFI now, closing this