Merge pull request #174 from timreichen/text-textContent-setter

fix: Text.textContent setter
b-fuze · Aug 12, 2024 · 4658549 · 4658549
2 parents d50e746 + 71617e2
commit 4658549
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/src/dom/node.ts b/src/dom/node.ts
@@ -631,10 +631,6 @@ export class Text extends CharacterData {
   _shallowClone(): Node {
     return new Text(this.textContent);
   }
-
-  get textContent(): string {
-    return <string> this.nodeValue;
-  }
 }
 
 export class Comment extends CharacterData {

diff --git a/test/units/CharacterData.ts b/test/units/CharacterData.ts
@@ -128,3 +128,14 @@ Deno.test("CharacterData.after/before/remove/replaceWith", () => {
   assertEquals(comment.previousSibling, null);
   assertEquals(comment.nextSibling, null);
 });
+
+Deno.test("CharacterData.textContent", () => {
+  const doc = new DOMParser().parseFromString(
+    `<body>foo</body>`,
+    "text/html",
+  );
+  const text = doc.body.childNodes[0];
+  assertEquals(text.textContent, "foo");
+  text.textContent = "bar";
+  assertEquals(text.textContent, "bar");
+});