Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -241,9 +241,9 @@
/sdk/ml/azure-ai-ml/azure/ai/ml/_local_endpoints/ @NonStatic2014 @arunsu @stanley-msft @JustinFirsching

# PRLabel: %ML-Jobs
/sdk/ml/azure-ai-ml/azure/ai/ml/_schema/job* @DouglasXiaoMS @TonyJ1 @wangchao1230
/sdk/ml/azure-ai-ml/azure/ai/ml/entities/_job/ @DouglasXiaoMS @TonyJ1 @wangchao1230
/sdk/ml/training-experiences.tests.yml @DouglasXiaoMS @TonyJ1
/sdk/ml/azure-ai-ml/azure/ai/ml/_schema/job* @TonyJ1 @wangchao1230
/sdk/ml/azure-ai-ml/azure/ai/ml/entities/_job/ @TonyJ1 @wangchao1230
/sdk/ml/training-experiences.tests.yml @TonyJ1

# PRLabel: %ML-AutoML
/sdk/ml/azure-ai-ml/azure/ai/ml/_schema/automl/ @skasturi @rtanase @raduk @PhaniShekhar @sharma-riti @jialiu103 @nick863 @yuanzhuangyuanzhuang @anupsms @MaurisLucis @novaturient95
Expand Down Expand Up @@ -951,7 +951,7 @@
#/<NotInRepo>/ @shivanissambare

# ServiceLabel: %ML-Jobs
#/<NotInRepo>/ @DouglasXiaoMS @TonyJ1 @wangchao1230
#/<NotInRepo>/ @TonyJ1 @wangchao1230

# ServiceLabel: %ML-Local Endpoints
#/<NotInRepo>/ @NonStatic2014 @arunsu @stanley-msft @JustinFirsching
Expand Down Expand Up @@ -1013,6 +1013,8 @@
###########
/eng/ @scbedd @weshaggard @benbp

/tools/ @scbedd @mccoyp

# Add owners for notifications for specific pipelines
/eng/pipelines/templates/jobs/tests-nightly-python.yml @lmazuel @mccoyp
/eng/pipelines/aggregate-reports.yml @lmazuel @mccoyp @YalinLi0312
Expand Down
68 changes: 63 additions & 5 deletions .github/workflows/event-processor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,26 +17,29 @@ on:
permissions: {}

jobs:
event-handler:
# This event requires the Azure CLI to get the LABEL_SERVICE_API_KEY from the vault.
# Because the azure/login step adds time costly pre/post Az CLI commands to any every job
# it's used in, split this into its own job so only the event that needs the Az CLI pays
# the cost.
event-handler-with-azure:
permissions:
issues: write
pull-requests: write
# For OIDC auth
id-token: write
contents: read
name: Handle ${{ github.event_name }} ${{ github.event.action }} event
name: Handle ${{ github.event_name }} ${{ github.event.action }} event with azure login
runs-on: ubuntu-latest
if: ${{ github.event_name == 'issues' && github.event.action == 'opened' }}
steps:
- name: 'Az CLI login'
if: ${{ github.event_name == 'issues' && github.event.action == 'opened' }}
uses: azure/login@v1.5.1
uses: azure/login@v1
with:
client-id: ${{ secrets.AZURE_CLIENT_ID }}
tenant-id: ${{ secrets.AZURE_TENANT_ID }}
subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}

- name: 'Run Azure CLI commands'
if: ${{ github.event_name == 'issues' && github.event.action == 'opened' }}
run: |
LABEL_SERVICE_API_KEY=$(az keyvault secret show \
--vault-name issue-labeler \
Expand Down Expand Up @@ -94,3 +97,58 @@ jobs:
# https://docs.github.com/en/actions/security-guides/automatic-token-authentication#about-the-github_token-secret
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
LABEL_SERVICE_API_KEY: ${{ env.LABEL_SERVICE_API_KEY }}

event-handler:
permissions:
issues: write
pull-requests: write
name: Handle ${{ github.event_name }} ${{ github.event.action }} event
runs-on: ubuntu-latest
if: ${{ github.event_name != 'issues' || github.event.action != 'opened' }}
steps:
# To run github-event-processor built from source, for testing purposes, uncomment everything
# in between the Start/End-Build From Source comments and comment everything in between the
# Start/End-Install comments
# Start-Install
- name: Install GitHub Event Processor
run: >
dotnet tool install
Azure.Sdk.Tools.GitHubEventProcessor
--version 1.0.0-dev.20240229.2
--add-source https://pkgs.dev.azure.com/azure-sdk/public/_packaging/azure-sdk-for-net/nuget/v3/index.json
--global
shell: bash
# End-Install

# Testing checkout of sources from the Azure/azure-sdk-tools repository
# The ref: is the SHA from the pull request in that repository or the
# refs/pull/<PRNumber>/merge for the latest on any given PR. If the repository
# is a fork eg. <User>/azure-sdk-tools then the repository down below will
# need to point to that fork
# Start-Build
# - name: Checkout tools repo for GitHub Event Processor sources
# uses: actions/checkout@v3
# with:
# repository: Azure/azure-sdk-tools
# path: azure-sdk-tools
# ref: <refs/pull/<PRNumber>/merge> or <sha>

# - name: Build and install GitHubEventProcessor from sources
# run: |
# dotnet pack
# dotnet tool install --global --prerelease --add-source ../../../artifacts/packages/Debug Azure.Sdk.Tools.GitHubEventProcessor
# shell: bash
# working-directory: azure-sdk-tools/tools/github-event-processor/Azure.Sdk.Tools.GitHubEventProcessor
# End-Build

- name: Process Action Event
run: |
cat > payload.json << 'EOF'
${{ toJson(github.event) }}
EOF
github-event-processor ${{ github.event_name }} payload.json
shell: bash
env:
# This is a temporary secret generated by github
# https://docs.github.com/en/actions/security-guides/automatic-token-authentication#about-the-github_token-secret
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
2 changes: 1 addition & 1 deletion eng/common/scripts/Prepare-Release.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ $month = $ParsedReleaseDate.ToString("MMMM")
Write-Host "Assuming release is in $month with release date $releaseDateString" -ForegroundColor Green
if (Test-Path "Function:GetExistingPackageVersions")
{
$releasedVersions = GetExistingPackageVersions -PackageName $packageProperties.Name -GroupId $packageProperties.Group
$releasedVersions = @(GetExistingPackageVersions -PackageName $packageProperties.Name -GroupId $packageProperties.Group)
if ($null -ne $releasedVersions -and $releasedVersions.Count -gt 0)
{
$latestReleasedVersion = $releasedVersions[$releasedVersions.Count - 1]
Expand Down
1 change: 1 addition & 0 deletions eng/common/scripts/Test-SampleMetadata.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,7 @@ begin {
"blazor-webassembly",
"common-data-service",
"customer-voice",
"dotnet-api",
"dotnet-core",
"dotnet-standard",
"document-intelligence",
Expand Down
6 changes: 3 additions & 3 deletions sdk/appconfiguration/azure-appconfiguration-provider/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,8 @@
python_requires=">=3.6",
install_requires=[
"msrest>=0.6.21",
"azure-core<2.0.0,>=1.28.0",
"azure-appconfiguration<2.0.0,>=1.5.0",
"azure-keyvault-secrets<5.0.0,>=4.3.0",
"azure-core>=1.28.0",
"azure-appconfiguration>=1.5.0",
"azure-keyvault-secrets>=4.3.0",
],
)
2 changes: 1 addition & 1 deletion sdk/appconfiguration/azure-appconfiguration/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
packages=find_packages(exclude=exclude_packages),
python_requires=">=3.8",
install_requires=[
"azure-core<2.0.0,>=1.28.0",
"azure-core>=1.28.0",
"isodate>=0.6.0",
],
)
4 changes: 2 additions & 2 deletions sdk/appcontainers/azure-mgmt-appcontainers/_meta.json
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
{
"commit": "4cd95123fb961c68740565a1efcaa5e43bd35802",
"commit": "631552a340927454f7179cd811e7f343d15dfcbc",
"repository_url": "https://github.com/Azure/azure-rest-api-specs",
"autorest": "3.9.7",
"use": [
"@autorest/python@6.7.1",
"@autorest/modelerfour@4.26.2"
],
"autorest_command": "autorest specification/app/resource-manager/readme.md --generate-sample=True --include-x-ms-examples-original-file=True --python --python-sdks-folder=/home/vsts/work/1/azure-sdk-for-python/sdk --use=@autorest/python@6.7.1 --use=@autorest/modelerfour@4.26.2 --version=3.9.7 --version-tolerant=False",
"autorest_command": "autorest specification/app/resource-manager/readme.md --generate-sample=True --include-x-ms-examples-original-file=True --python --python-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-python/sdk --use=@autorest/python@6.7.1 --use=@autorest/modelerfour@4.26.2 --version=3.9.7 --version-tolerant=False",
"readme": "specification/app/resource-manager/readme.md"
}
Original file line number Diff line number Diff line change
Expand Up @@ -27,16 +27,16 @@ class ContainerAppsAPIClientConfiguration(Configuration): # pylint: disable=too

:param credential: Credential needed for the client to connect to Azure. Required.
:type credential: ~azure.core.credentials.TokenCredential
:param subscription_id: The ID of the target subscription. Required.
:param subscription_id: The ID of the target subscription. The value must be an UUID. Required.
:type subscription_id: str
:keyword api_version: Api Version. Default value is "2023-05-01". Note that overriding this
default value may result in unsupported behavior.
:keyword api_version: Api Version. Default value is "2024-02-02-preview". Note that overriding
this default value may result in unsupported behavior.
:paramtype api_version: str
"""

def __init__(self, credential: "TokenCredential", subscription_id: str, **kwargs: Any) -> None:
super(ContainerAppsAPIClientConfiguration, self).__init__(**kwargs)
api_version: str = kwargs.pop("api_version", "2023-05-01")
api_version: str = kwargs.pop("api_version", "2024-02-02-preview")

if credential is None:
raise ValueError("Parameter 'credential' must not be None.")
Expand Down
Loading