[AutoPR @azure/arm-synapse] Swagger correctness action items

sdk/synapse/arm-synapse/CHANGELOG.md

@@ -1,16 +1,6 @@
 # Release History
-
-## 8.1.0-beta.2 (Unreleased)
-
-### Features Added
-
-### Breaking Changes
-
-### Bugs Fixed
-
-### Other Changes
-
-## 8.1.0-beta.1 (2022-04-20)
+
+## 9.0.0-beta.1 (2022-07-05)
 
 **Features**
 
@@ -21,14 +11,21 @@
   - Added Interface WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsListNextOptionalParams
   - Added Interface WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsListOptionalParams
   - Added Interface WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsUpdateOptionalParams
+  - Added Type Alias ActualState
   - Added Type Alias DedicatedSQLminimalTlsSettings
   - Added Type Alias DedicatedSQLMinimalTlsSettingsName
+  - Added Type Alias DesiredState
   - Added Type Alias WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsGetResponse
   - Added Type Alias WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsListNextResponse
   - Added Type Alias WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsListResponse
   - Added Type Alias WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsUpdateResponse
   - Class SynapseManagementClient has a new parameter workspaceManagedSqlServerDedicatedSQLMinimalTlsSettings
   - Added Enum KnownDedicatedSQLMinimalTlsSettingsName
+
+**Breaking Changes**
+
+  - Removed Enum KnownManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentityActualState
+  - Removed Enum KnownManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentityDesiredState
 
 
 ## 8.0.0 (2022-01-13)

sdk/synapse/arm-synapse/_meta.json

@@ -1,8 +1,8 @@
 {
-  "commit": "8a9bd9c5b65e5c3e5a8536f3c5b2b15bf9920b5d",
+  "commit": "4f955b8571de321631f2f8b89453506e4710240b",
   "readme": "specification/synapse/resource-manager/readme.md",
-  "autorest_command": "autorest --version=3.7.3 --typescript --modelerfour.lenient-model-deduplication --head-as-boolean=true --license-header=MICROSOFT_MIT_NO_VERSION --generate-test --typescript-sdks-folder=D:\\work\\azure-sdk-for-js ..\\azure-rest-api-specs\\specification\\synapse\\resource-manager\\readme.md --use=@autorest/typescript@6.0.0-alpha.19.20220408.1 --generate-sample=true",
+  "autorest_command": "autorest --version=3.7.3 --typescript --modelerfour.lenient-model-deduplication --azure-arm --head-as-boolean=true --license-header=MICROSOFT_MIT_NO_VERSION --generate-test --typescript-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-js ../azure-rest-api-specs/specification/synapse/resource-manager/readme.md --use=@autorest/typescript@6.0.0-alpha.19.20220425.1",
   "repository_url": "https://github.com/Azure/azure-rest-api-specs.git",
-  "release_tool": "@azure-tools/js-sdk-release-tools@2.2.6",
-  "use": "@autorest/typescript@6.0.0-alpha.19.20220408.1"
+  "release_tool": "@azure-tools/js-sdk-release-tools@2.4.0",
+  "use": "@autorest/typescript@6.0.0-alpha.19.20220425.1"
 }

sdk/synapse/arm-synapse/package.json

@@ -3,7 +3,7 @@
   "sdk-type": "mgmt",
   "author": "Microsoft Corporation",
   "description": "A generated SDK for SynapseManagementClient.",
-  "version": "8.1.0-beta.2",
+  "version": "9.0.0-beta.1",
   "engines": {
     "node": ">=12.0.0"
   },
@@ -40,9 +40,11 @@
     "uglify-js": "^3.4.9",
     "rimraf": "^3.0.0",
     "@azure/identity": "^2.0.1",
-    "@azure-tools/test-recorder": "^1.0.0",
+    "@azure-tools/test-recorder": "^2.0.0",
+    "@azure-tools/test-credential": "^1.0.0",
     "mocha": "^7.1.1",
-    "cross-env": "^7.0.2"
+    "cross-env": "^7.0.2",
+    "@azure/dev-tool": "^1.0.0"
   },
   "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/synapse/arm-synapse",
   "repository": {
@@ -93,7 +95,7 @@
     "unit-test:node": "cross-env TEST_MODE=playback npm run integration-test:node",
     "unit-test:browser": "echo skipped",
     "integration-test": "npm run integration-test:node && npm run integration-test:browser",
-    "integration-test:node": "mocha -r esm --require ts-node/register --timeout 1200000 --full-trace test/*.ts --reporter ../../../common/tools/mocha-multi-reporter.js",
+    "integration-test:node": "dev-tool run test:node-ts-input -- --timeout 1200000 'test/*.ts'",
     "integration-test:browser": "echo skipped",
     "docs": "echo skipped"
   },
@@ -106,13 +108,5 @@
       }
     ]
   },
-  "autoPublish": true,
-  "//sampleConfiguration": {
-    "productName": "",
-    "productSlugs": [
-      "azure"
-    ],
-    "disableDocsMs": true,
-    "apiRefLink": "https://docs.microsoft.com/javascript/api/@azure/arm-synapse?view=azure-node-preview"
-  }
-}
+  "autoPublish": true
+}

sdk/synapse/arm-synapse/review/arm-synapse.api.md

@@ -10,6 +10,9 @@ import { PagedAsyncIterableIterator } from '@azure/core-paging';
 import { PollerLike } from '@azure/core-lro';
 import { PollOperationState } from '@azure/core-lro';
 
+// @public
+export type ActualState = "Enabling" | "Enabled" | "Disabling" | "Disabled" | "Unknown";
+
 // @public
 export type AttachedDatabaseConfiguration = ProxyResource & {
     location?: string;
@@ -577,6 +580,9 @@ export interface DedicatedSQLminimalTlsSettingsPatchInfo {
 // @public
 export type DefaultPrincipalsModificationKind = string;
 
+// @public
+export type DesiredState = "Enabled" | "Disabled";
+
 // @public
 export interface DynamicExecutorAllocation {
     enabled?: boolean;
@@ -1846,28 +1852,6 @@ export enum KnownLanguageExtensionName {
     R = "R"
 }
 
-// @public
-export enum KnownManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentityActualState {
-    // (undocumented)
-    Disabled = "Disabled",
-    // (undocumented)
-    Disabling = "Disabling",
-    // (undocumented)
-    Enabled = "Enabled",
-    // (undocumented)
-    Enabling = "Enabling",
-    // (undocumented)
-    Unknown = "Unknown"
-}
-
-// @public
-export enum KnownManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentityDesiredState {
-    // (undocumented)
-    Disabled = "Disabled",
-    // (undocumented)
-    Enabled = "Enabled"
-}
-
 // @public
 export enum KnownManagedIntegrationRuntimeNodeStatus {
     // (undocumented)
@@ -2781,16 +2765,10 @@ export type ManagedIdentitySqlControlSettingsModel = ProxyResource & {
 
 // @public
 export interface ManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentity {
-    readonly actualState?: ManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentityActualState;
-    desiredState?: ManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentityDesiredState;
+    readonly actualState?: ActualState;
+    desiredState?: DesiredState;
 }
 
-// @public
-export type ManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentityActualState = string;
-
-// @public
-export type ManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentityDesiredState = string;
-
 // @public
 export type ManagedIntegrationRuntime = IntegrationRuntime & {
     type: "Managed";

sdk/synapse/arm-synapse/src/models/index.ts

@@ -1127,12 +1127,12 @@ export interface WorkspacePatchInfo {
 /** Grant sql control to managed identity */
 export interface ManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentity {
   /** Desired state */
-  desiredState?: ManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentityDesiredState;
+  desiredState?: DesiredState;
   /**
    * Actual state
    * NOTE: This property will not be serialized. It can only be populated by the server.
    */
-  readonly actualState?: ManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentityActualState;
+  readonly actualState?: ActualState;
 }
 
 /** The response to a list restorable dropped Sql pools request */
@@ -4811,44 +4811,6 @@ export enum KnownWorkspacePublicNetworkAccess {
  */
 export type WorkspacePublicNetworkAccess = string;
 
-/** Known values of {@link ManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentityDesiredState} that the service accepts. */
-export enum KnownManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentityDesiredState {
-  Enabled = "Enabled",
-  Disabled = "Disabled"
-}
-
-/**
- * Defines values for ManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentityDesiredState. \
- * {@link KnownManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentityDesiredState} can be used interchangeably with ManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentityDesiredState,
- *  this enum contains the known values that the service supports.
- * ### Known values supported by the service
- * **Enabled** \
- * **Disabled**
- */
-export type ManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentityDesiredState = string;
-
-/** Known values of {@link ManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentityActualState} that the service accepts. */
-export enum KnownManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentityActualState {
-  Enabling = "Enabling",
-  Enabled = "Enabled",
-  Disabling = "Disabling",
-  Disabled = "Disabled",
-  Unknown = "Unknown"
-}
-
-/**
- * Defines values for ManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentityActualState. \
- * {@link KnownManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentityActualState} can be used interchangeably with ManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentityActualState,
- *  this enum contains the known values that the service supports.
- * ### Known values supported by the service
- * **Enabling** \
- * **Enabled** \
- * **Disabling** \
- * **Disabled** \
- * **Unknown**
- */
-export type ManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentityActualState = string;
-
 /** Known values of {@link ConfigurationType} that the service accepts. */
 export enum KnownConfigurationType {
   File = "File",
@@ -5681,6 +5643,15 @@ export type ResourceIdentityType =
   | "None"
   | "SystemAssigned"
   | "SystemAssigned,UserAssigned";
+/** Defines values for DesiredState. */
+export type DesiredState = "Enabled" | "Disabled";
+/** Defines values for ActualState. */
+export type ActualState =
+  | "Enabling"
+  | "Enabled"
+  | "Disabling"
+  | "Disabled"
+  | "Unknown";
 /** Defines values for Type. */
 export type Type =
   | "Microsoft.Synapse/workspaces/kustoPools/databases"

sdk/synapse/arm-synapse/src/models/mappers.ts

@@ -2564,14 +2564,22 @@ export const ManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToMa
       desiredState: {
         serializedName: "desiredState",
         type: {
-          name: "String"
+          name: "Enum",
+          allowedValues: ["Enabled", "Disabled"]
         }
       },
       actualState: {
         serializedName: "actualState",
         readOnly: true,
         type: {
-          name: "String"
+          name: "Enum",
+          allowedValues: [
+            "Enabling",
+            "Enabled",
+            "Disabling",
+            "Disabled",
+            "Unknown"
+          ]
         }
       }
     }

sdk/synapse/arm-synapse/src/synapseManagementClient.ts

@@ -192,7 +192,7 @@ export class SynapseManagementClient extends coreClient.ServiceClient {
       credential: credentials
     };
 
-    const packageDetails = `azsdk-js-arm-synapse/8.1.0-beta.2`;
+    const packageDetails = `azsdk-js-arm-synapse/9.0.0-beta.1`;
     const userAgentPrefix =
       options.userAgentOptions && options.userAgentOptions.userAgentPrefix
         ? `${options.userAgentOptions.userAgentPrefix} ${packageDetails}`

sdk/synapse/arm-synapse/test/sampleTest.ts

@@ -7,35 +7,30 @@
  */
 
 import {
-  env,
-  record,
-  RecorderEnvironmentSetup,
-  Recorder
+  Recorder,
+  RecorderStartOptions,
+  env
 } from "@azure-tools/test-recorder";
-import * as assert from "assert";
+import { assert } from "chai";
+import { Context } from "mocha";
 
-const recorderEnvSetup: RecorderEnvironmentSetup = {
-  replaceableVariables: {
-    AZURE_CLIENT_ID: "azure_client_id",
-    AZURE_CLIENT_SECRET: "azure_client_secret",
-    AZURE_TENANT_ID: "88888888-8888-8888-8888-888888888888",
-    SUBSCRIPTION_ID: "azure_subscription_id"
-  },
-  customizationsOnRecordings: [
-    (recording: any): any =>
-      recording.replace(
-        /"access_token":"[^"]*"/g,
-        `"access_token":"access_token"`
-      )
-  ],
-  queryParametersToSkip: []
+const replaceableVariables: Record<string, string> = {
+  AZURE_CLIENT_ID: "azure_client_id",
+  AZURE_CLIENT_SECRET: "azure_client_secret",
+  AZURE_TENANT_ID: "88888888-8888-8888-8888-888888888888",
+  SUBSCRIPTION_ID: "azure_subscription_id"
+};
+
+const recorderOptions: RecorderStartOptions = {
+  envSetupForPlayback: replaceableVariables
 };
 
 describe("My test", () => {
   let recorder: Recorder;
 
-  beforeEach(async function() {
-    recorder = record(this, recorderEnvSetup);
+  beforeEach(async function(this: Context) {
+    recorder = new Recorder(this.currentTest);
+    await recorder.start(recorderOptions);
   });
 
   afterEach(async function() {

sdk/synapse/arm-synapse/tsconfig.json

@@ -15,17 +15,11 @@
     ],
     "declaration": true,
     "outDir": "./dist-esm",
-    "importHelpers": true,
-    "paths": {
-      "@azure/arm-synapse": [
-        "./src/index"
-      ]
-    }
+    "importHelpers": true
   },
   "include": [
     "./src/**/*.ts",
-    "./test/**/*.ts",
-    "samples-dev/**/*.ts"
+    "./test/**/*.ts"
   ],
   "exclude": [
     "node_modules"