[AutoPR @azure/arm-policyinsights] [Hub Generated] Review request for Microsoft.PolicyInsights to add version stable/2023-03-01

sdk/policyinsights/arm-policyinsights/CHANGELOG.md

@@ -1,23 +1,14 @@
 # Release History
-
-## 6.0.0-beta.4 (Unreleased)
-
-### Features Added
-
-### Breaking Changes
-
-### Bugs Fixed
-
-### Other Changes
-
-## 6.0.0-beta.3 (2023-01-30)
+
+## 6.0.0-beta.4 (2023-04-10)
 
 **Features**
 
   - Added operation group ComponentPolicyStates
   - Added operation PolicyRestrictions.checkAtManagementGroupScope
   - Added Interface Attestation
   - Added Interface CheckManagementGroupRestrictionsRequest
+  - Added Interface CheckRestrictionEvaluationDetails
   - Added Interface ComponentExpressionEvaluationDetails
   - Added Interface ComponentPolicyEvaluationDetails
   - Added Interface ComponentPolicyState
@@ -28,6 +19,7 @@
   - Added Interface ComponentPolicyStatesListQueryResultsForSubscriptionLevelPolicyAssignmentOptionalParams
   - Added Interface ComponentPolicyStatesListQueryResultsForSubscriptionOptionalParams
   - Added Interface ComponentPolicyStatesQueryResults
+  - Added Interface PolicyEffectDetails
   - Added Interface PolicyMetadataProperties
   - Added Interface PolicyRestrictionsCheckAtManagementGroupScopeOptionalParams
   - Added Type Alias ComponentPolicyStatesListQueryResultsForPolicyDefinitionResponse
@@ -41,12 +33,40 @@
   - Added Type Alias PolicyRestrictionsCheckAtManagementGroupScopeResponse
   - Added Type Alias PolicyStatesSummaryResourceType
   - Added Type Alias PolicyTrackedResourcesResourceType
+  - Interface CheckRestrictionsRequest has a new optional parameter includeAuditEffect
+  - Interface FieldRestriction has a new optional parameter policyEffect
+  - Interface FieldRestriction has a new optional parameter reason
   - Interface Operation has a new optional parameter isDataAction
+  - Interface PolicyEvaluationResult has a new optional parameter effectDetails
   - Added Enum KnownComponentPolicyStatesResource
   - Added Enum KnownPolicyEventsResourceType
   - Added Enum KnownPolicyStatesSummaryResourceType
   - Added Enum KnownPolicyTrackedResourcesResourceType
+  - Enum KnownFieldRestrictionResult has a new value Audit
   - Added function getContinuationToken
+
+**Breaking Changes**
+
+  - Operation PolicyEvents.listQueryResultsForManagementGroup has a new signature
+  - Operation PolicyEvents.listQueryResultsForPolicyDefinition has a new signature
+  - Operation PolicyEvents.listQueryResultsForPolicySetDefinition has a new signature
+  - Operation PolicyEvents.listQueryResultsForResource has a new signature
+  - Operation PolicyEvents.listQueryResultsForResourceGroup has a new signature
+  - Operation PolicyEvents.listQueryResultsForResourceGroupLevelPolicyAssignment has a new signature
+  - Operation PolicyEvents.listQueryResultsForSubscription has a new signature
+  - Operation PolicyEvents.listQueryResultsForSubscriptionLevelPolicyAssignment has a new signature
+  - Operation PolicyStates.summarizeForManagementGroup has a new signature
+  - Operation PolicyStates.summarizeForPolicyDefinition has a new signature
+  - Operation PolicyStates.summarizeForPolicySetDefinition has a new signature
+  - Operation PolicyStates.summarizeForResource has a new signature
+  - Operation PolicyStates.summarizeForResourceGroup has a new signature
+  - Operation PolicyStates.summarizeForResourceGroupLevelPolicyAssignment has a new signature
+  - Operation PolicyStates.summarizeForSubscription has a new signature
+  - Operation PolicyStates.summarizeForSubscriptionLevelPolicyAssignment has a new signature
+  - Operation PolicyTrackedResources.listQueryResultsForManagementGroup has a new signature
+  - Operation PolicyTrackedResources.listQueryResultsForResource has a new signature
+  - Operation PolicyTrackedResources.listQueryResultsForResourceGroup has a new signature
+  - Operation PolicyTrackedResources.listQueryResultsForSubscription has a new signature
   - Interface AttestationsListForResourceGroupNextOptionalParams no longer has parameter queryOptions
   - Interface AttestationsListForResourceNextOptionalParams no longer has parameter queryOptions
   - Interface AttestationsListForSubscriptionNextOptionalParams no longer has parameter queryOptions
@@ -79,29 +99,7 @@
   - Interface RemediationsListForResourceGroupNextOptionalParams no longer has parameter queryOptions
   - Interface RemediationsListForResourceNextOptionalParams no longer has parameter queryOptions
   - Interface RemediationsListForSubscriptionNextOptionalParams no longer has parameter queryOptions
-
-**Breaking Changes**
-
-  - Operation PolicyEvents.listQueryResultsForManagementGroup has a new signature
-  - Operation PolicyEvents.listQueryResultsForPolicyDefinition has a new signature
-  - Operation PolicyEvents.listQueryResultsForPolicySetDefinition has a new signature
-  - Operation PolicyEvents.listQueryResultsForResource has a new signature
-  - Operation PolicyEvents.listQueryResultsForResourceGroup has a new signature
-  - Operation PolicyEvents.listQueryResultsForResourceGroupLevelPolicyAssignment has a new signature
-  - Operation PolicyEvents.listQueryResultsForSubscription has a new signature
-  - Operation PolicyEvents.listQueryResultsForSubscriptionLevelPolicyAssignment has a new signature
-  - Operation PolicyStates.summarizeForManagementGroup has a new signature
-  - Operation PolicyStates.summarizeForPolicyDefinition has a new signature
-  - Operation PolicyStates.summarizeForPolicySetDefinition has a new signature
-  - Operation PolicyStates.summarizeForResource has a new signature
-  - Operation PolicyStates.summarizeForResourceGroup has a new signature
-  - Operation PolicyStates.summarizeForResourceGroupLevelPolicyAssignment has a new signature
-  - Operation PolicyStates.summarizeForSubscription has a new signature
-  - Operation PolicyStates.summarizeForSubscriptionLevelPolicyAssignment has a new signature
-  - Operation PolicyTrackedResources.listQueryResultsForManagementGroup has a new signature
-  - Operation PolicyTrackedResources.listQueryResultsForResource has a new signature
-  - Operation PolicyTrackedResources.listQueryResultsForResourceGroup has a new signature
-  - Operation PolicyTrackedResources.listQueryResultsForSubscription has a new signature
+  - Type of parameter evaluationDetails of interface PolicyEvaluationResult is changed from PolicyEvaluationDetails to CheckRestrictionEvaluationDetails
 
 
 ## 5.0.0 (2022-01-24)

sdk/policyinsights/arm-policyinsights/_meta.json

@@ -1,8 +1,8 @@
 {
-  "commit": "78ec1b99699a4bf44869bd13f1b0ed7d92a99c27",
+  "commit": "025ca2395b5eb78212fd89d6470ddf6c96415d1d",
   "readme": "specification/policyinsights/resource-manager/readme.md",
-  "autorest_command": "autorest --version=3.9.3 --typescript --modelerfour.lenient-model-deduplication --azure-arm --head-as-boolean=true --license-header=MICROSOFT_MIT_NO_VERSION --generate-test --typescript-sdks-folder=F:\\azure-sdk-for-js ..\\azure-rest-api-specs\\specification\\policyinsights\\resource-manager\\readme.md --use=@autorest/typescript@6.0.0-rc.7 --generate-sample=true",
+  "autorest_command": "autorest --version=3.9.3 --typescript --modelerfour.lenient-model-deduplication --azure-arm --head-as-boolean=true --license-header=MICROSOFT_MIT_NO_VERSION --generate-test --typescript-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-js ../azure-rest-api-specs/specification/policyinsights/resource-manager/readme.md --use=@autorest/typescript@6.0.0-rc.10",
   "repository_url": "https://github.com/Azure/azure-rest-api-specs.git",
-  "release_tool": "@azure-tools/js-sdk-release-tools@2.6.0",
-  "use": "@autorest/typescript@6.0.0-rc.7"
+  "release_tool": "@azure-tools/js-sdk-release-tools@2.7.0",
+  "use": "@autorest/typescript@6.0.0-rc.10"
 }

sdk/policyinsights/arm-policyinsights/package.json

@@ -8,10 +8,10 @@
     "node": ">=14.0.0"
   },
   "dependencies": {
-    "@azure/core-lro": "^2.2.0",
+    "@azure/core-lro": "^2.5.0",
     "@azure/abort-controller": "^1.0.0",
     "@azure/core-paging": "^1.2.0",
-    "@azure/core-client": "^1.6.1",
+    "@azure/core-client": "^1.7.0",
     "@azure/core-auth": "^1.3.0",
     "@azure/core-rest-pipeline": "^1.8.0",
     "tslib": "^2.2.0"
@@ -33,13 +33,13 @@
     "@rollup/plugin-json": "^6.0.0",
     "@rollup/plugin-multi-entry": "^6.0.0",
     "@rollup/plugin-node-resolve": "^13.1.3",
-    "mkdirp": "^1.0.4",
+    "mkdirp": "^2.1.2",
     "rollup": "^2.66.1",
     "rollup-plugin-sourcemaps": "^0.6.3",
     "typescript": "~4.8.0",
     "uglify-js": "^3.4.9",
     "rimraf": "^3.0.0",
-    "dotenv": "^8.2.0",
+    "dotenv": "^16.0.0",
     "@azure/identity": "^2.0.1",
     "@azure-tools/test-recorder": "^3.0.0",
     "@azure-tools/test-credential": "^1.0.0",
@@ -111,13 +111,5 @@
     ]
   },
   "autoPublish": true,
-  "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/policyinsights/arm-policyinsights",
-  "//sampleConfiguration": {
-    "productName": "",
-    "productSlugs": [
-      "azure"
-    ],
-    "disableDocsMs": true,
-    "apiRefLink": "https://docs.microsoft.com/javascript/api/@azure/arm-policyinsights?view=azure-node-preview"
-  }
-}
+  "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/policyinsights/arm-policyinsights"
+}

sdk/policyinsights/arm-policyinsights/review/arm-policyinsights.api.md

@@ -6,9 +6,9 @@
 
 import * as coreAuth from '@azure/core-auth';
 import * as coreClient from '@azure/core-client';
+import { OperationState } from '@azure/core-lro';
 import { PagedAsyncIterableIterator } from '@azure/core-paging';
-import { PollerLike } from '@azure/core-lro';
-import { PollOperationState } from '@azure/core-lro';
+import { SimplePollerLike } from '@azure/core-lro';
 
 // @public
 export interface Attestation extends Resource {
@@ -40,11 +40,11 @@ export interface AttestationListResult {
 
 // @public
 export interface Attestations {
-    beginCreateOrUpdateAtResource(resourceId: string, attestationName: string, parameters: Attestation, options?: AttestationsCreateOrUpdateAtResourceOptionalParams): Promise<PollerLike<PollOperationState<AttestationsCreateOrUpdateAtResourceResponse>, AttestationsCreateOrUpdateAtResourceResponse>>;
+    beginCreateOrUpdateAtResource(resourceId: string, attestationName: string, parameters: Attestation, options?: AttestationsCreateOrUpdateAtResourceOptionalParams): Promise<SimplePollerLike<OperationState<AttestationsCreateOrUpdateAtResourceResponse>, AttestationsCreateOrUpdateAtResourceResponse>>;
     beginCreateOrUpdateAtResourceAndWait(resourceId: string, attestationName: string, parameters: Attestation, options?: AttestationsCreateOrUpdateAtResourceOptionalParams): Promise<AttestationsCreateOrUpdateAtResourceResponse>;
-    beginCreateOrUpdateAtResourceGroup(resourceGroupName: string, attestationName: string, parameters: Attestation, options?: AttestationsCreateOrUpdateAtResourceGroupOptionalParams): Promise<PollerLike<PollOperationState<AttestationsCreateOrUpdateAtResourceGroupResponse>, AttestationsCreateOrUpdateAtResourceGroupResponse>>;
+    beginCreateOrUpdateAtResourceGroup(resourceGroupName: string, attestationName: string, parameters: Attestation, options?: AttestationsCreateOrUpdateAtResourceGroupOptionalParams): Promise<SimplePollerLike<OperationState<AttestationsCreateOrUpdateAtResourceGroupResponse>, AttestationsCreateOrUpdateAtResourceGroupResponse>>;
     beginCreateOrUpdateAtResourceGroupAndWait(resourceGroupName: string, attestationName: string, parameters: Attestation, options?: AttestationsCreateOrUpdateAtResourceGroupOptionalParams): Promise<AttestationsCreateOrUpdateAtResourceGroupResponse>;
-    beginCreateOrUpdateAtSubscription(attestationName: string, parameters: Attestation, options?: AttestationsCreateOrUpdateAtSubscriptionOptionalParams): Promise<PollerLike<PollOperationState<AttestationsCreateOrUpdateAtSubscriptionResponse>, AttestationsCreateOrUpdateAtSubscriptionResponse>>;
+    beginCreateOrUpdateAtSubscription(attestationName: string, parameters: Attestation, options?: AttestationsCreateOrUpdateAtSubscriptionOptionalParams): Promise<SimplePollerLike<OperationState<AttestationsCreateOrUpdateAtSubscriptionResponse>, AttestationsCreateOrUpdateAtSubscriptionResponse>>;
     beginCreateOrUpdateAtSubscriptionAndWait(attestationName: string, parameters: Attestation, options?: AttestationsCreateOrUpdateAtSubscriptionOptionalParams): Promise<AttestationsCreateOrUpdateAtSubscriptionResponse>;
     deleteAtResource(resourceId: string, attestationName: string, options?: AttestationsDeleteAtResourceOptionalParams): Promise<void>;
     deleteAtResourceGroup(resourceGroupName: string, attestationName: string, options?: AttestationsDeleteAtResourceGroupOptionalParams): Promise<void>;
@@ -168,8 +168,16 @@ export interface CheckManagementGroupRestrictionsRequest {
     resourceDetails?: CheckRestrictionsResourceDetails;
 }
 
+// @public
+export interface CheckRestrictionEvaluationDetails {
+    evaluatedExpressions?: ExpressionEvaluationDetails[];
+    ifNotExistsDetails?: IfNotExistsEvaluationDetails;
+    readonly reason?: string;
+}
+
 // @public
 export interface CheckRestrictionsRequest {
+    includeAuditEffect?: boolean;
     pendingFields?: PendingField[];
     resourceDetails: CheckRestrictionsResourceDetails;
 }
@@ -442,6 +450,8 @@ export interface ExpressionEvaluationDetails {
 export interface FieldRestriction {
     readonly defaultValue?: string;
     readonly policy?: PolicyReference;
+    readonly policyEffect?: string;
+    readonly reason?: string;
     readonly result?: FieldRestrictionResult;
     readonly values?: string[];
 }
@@ -486,6 +496,7 @@ export enum KnownCreatedByType {
 
 // @public
 export enum KnownFieldRestrictionResult {
+    Audit = "Audit",
     Deny = "Deny",
     Removed = "Removed",
     Required = "Required"
@@ -585,6 +596,11 @@ export interface PolicyDetails {
     readonly policySetDefinitionId?: string;
 }
 
+// @public
+export interface PolicyEffectDetails {
+    readonly policyEffect?: string;
+}
+
 // @public
 export interface PolicyEvaluationDetails {
     evaluatedExpressions?: ExpressionEvaluationDetails[];
@@ -593,7 +609,8 @@ export interface PolicyEvaluationDetails {
 
 // @public
 export interface PolicyEvaluationResult {
-    readonly evaluationDetails?: PolicyEvaluationDetails;
+    readonly effectDetails?: PolicyEffectDetails;
+    readonly evaluationDetails?: CheckRestrictionEvaluationDetails;
     readonly evaluationResult?: string;
     readonly policyInfo?: PolicyReference;
 }
@@ -958,9 +975,9 @@ export interface PolicyState {
 
 // @public
 export interface PolicyStates {
-    beginTriggerResourceGroupEvaluation(subscriptionId: string, resourceGroupName: string, options?: PolicyStatesTriggerResourceGroupEvaluationOptionalParams): Promise<PollerLike<PollOperationState<void>, void>>;
+    beginTriggerResourceGroupEvaluation(subscriptionId: string, resourceGroupName: string, options?: PolicyStatesTriggerResourceGroupEvaluationOptionalParams): Promise<SimplePollerLike<OperationState<void>, void>>;
     beginTriggerResourceGroupEvaluationAndWait(subscriptionId: string, resourceGroupName: string, options?: PolicyStatesTriggerResourceGroupEvaluationOptionalParams): Promise<void>;
-    beginTriggerSubscriptionEvaluation(subscriptionId: string, options?: PolicyStatesTriggerSubscriptionEvaluationOptionalParams): Promise<PollerLike<PollOperationState<void>, void>>;
+    beginTriggerSubscriptionEvaluation(subscriptionId: string, options?: PolicyStatesTriggerSubscriptionEvaluationOptionalParams): Promise<SimplePollerLike<OperationState<void>, void>>;
     beginTriggerSubscriptionEvaluationAndWait(subscriptionId: string, options?: PolicyStatesTriggerSubscriptionEvaluationOptionalParams): Promise<void>;
     listQueryResultsForManagementGroup(policyStatesResource: PolicyStatesResource, managementGroupName: string, options?: PolicyStatesListQueryResultsForManagementGroupOptionalParams): PagedAsyncIterableIterator<PolicyState>;
     listQueryResultsForPolicyDefinition(policyStatesResource: PolicyStatesResource, subscriptionId: string, policyDefinitionName: string, options?: PolicyStatesListQueryResultsForPolicyDefinitionOptionalParams): PagedAsyncIterableIterator<PolicyState>;

sdk/policyinsights/arm-policyinsights/src/lroImpl.ts

@@ -6,29 +6,37 @@
  * Changes may cause incorrect behavior and will be lost if the code is regenerated.
  */
 
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT license.
+
+import { AbortSignalLike } from "@azure/abort-controller";
 import { LongRunningOperation, LroResponse } from "@azure/core-lro";
 
-export class LroImpl<T> implements LongRunningOperation<T> {
-  constructor(
-    private sendOperationFn: (args: any, spec: any) => Promise<LroResponse<T>>,
-    private args: Record<string, unknown>,
-    private spec: {
-      readonly requestBody?: unknown;
-      readonly path?: string;
-      readonly httpMethod: string;
-    } & Record<string, any>,
-    public requestPath: string = spec.path!,
-    public requestMethod: string = spec.httpMethod
-  ) {}
-  public async sendInitialRequest(): Promise<LroResponse<T>> {
-    return this.sendOperationFn(this.args, this.spec);
-  }
-  public async sendPollRequest(path: string): Promise<LroResponse<T>> {
-    const { requestBody, ...restSpec } = this.spec;
-    return this.sendOperationFn(this.args, {
-      ...restSpec,
-      path,
-      httpMethod: "GET"
-    });
-  }
+export function createLroSpec<T>(inputs: {
+  sendOperationFn: (args: any, spec: any) => Promise<LroResponse<T>>;
+  args: Record<string, unknown>;
+  spec: {
+    readonly requestBody?: unknown;
+    readonly path?: string;
+    readonly httpMethod: string;
+  } & Record<string, any>;
+}): LongRunningOperation<T> {
+  const { args, spec, sendOperationFn } = inputs;
+  return {
+    requestMethod: spec.httpMethod,
+    requestPath: spec.path!,
+    sendInitialRequest: () => sendOperationFn(args, spec),
+    sendPollRequest: (
+      path: string,
+      options?: { abortSignal?: AbortSignalLike }
+    ) => {
+      const { requestBody, ...restSpec } = spec;
+      return sendOperationFn(args, {
+        ...restSpec,
+        httpMethod: "GET",
+        path,
+        abortSignal: options?.abortSignal
+      });
+    }
+  };
 }