Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions common/config/rush/pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

24 changes: 16 additions & 8 deletions sdk/batch/arm-batch/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,15 +1,23 @@
# Release History

## 8.0.0 (2022-11-10)

**Features**

## 7.2.1 (Unreleased)

### Features Added

### Breaking Changes

### Bugs Fixed
- Added Type Alias NodeCommunicationMode
- Interface NetworkConfiguration has a new optional parameter dynamicVnetAssignmentScope
- Interface Pool has a new optional parameter currentNodeCommunicationMode
- Interface Pool has a new optional parameter targetNodeCommunicationMode
- Interface PrivateLinkServiceConnectionState has a new optional parameter actionsRequired

### Other Changes
**Breaking Changes**

- Interface CifsMountConfiguration no longer has parameter username
- Interface NetworkConfiguration no longer has parameter dynamicVNetAssignmentScope
- Interface PrivateLinkServiceConnectionState no longer has parameter actionRequired
- Interface CifsMountConfiguration has a new required parameter userName


## 7.2.0 (2022-07-19)

**Features**
Expand Down
8 changes: 4 additions & 4 deletions sdk/batch/arm-batch/_meta.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"commit": "c03c258c7a01a7d57b3110cc20e2e76752b6f2d6",
"commit": "ee492b5b6f3b38e49f59b53a9e29068bf0d49657",
"readme": "specification/batch/resource-manager/readme.md",
"autorest_command": "autorest --version=3.7.3 --typescript --modelerfour.lenient-model-deduplication --azure-arm --head-as-boolean=true --license-header=MICROSOFT_MIT_NO_VERSION --generate-test --typescript-sdks-folder=D:\\Git\\azure-sdk-for-js ..\\azure-rest-api-specs\\specification\\batch\\resource-manager\\readme.md --use=@autorest/typescript@6.0.0-rc.1 --generate-sample=true",
"autorest_command": "autorest --version=3.8.4 --typescript --modelerfour.lenient-model-deduplication --azure-arm --head-as-boolean=true --license-header=MICROSOFT_MIT_NO_VERSION --generate-test --typescript-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-js ../azure-rest-api-specs/specification/batch/resource-manager/readme.md --use=@autorest/typescript@6.0.0-rc.2",
"repository_url": "https://github.com/Azure/azure-rest-api-specs.git",
"release_tool": "@azure-tools/js-sdk-release-tools@2.4.0",
"use": "@autorest/typescript@6.0.0-rc.1"
"release_tool": "@azure-tools/js-sdk-release-tools@2.5.1",
"use": "@autorest/typescript@6.0.0-rc.2"
}
19 changes: 5 additions & 14 deletions sdk/batch/arm-batch/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"sdk-type": "mgmt",
"author": "Microsoft Corporation",
"description": "A generated SDK for BatchManagementClient.",
"version": "7.2.1",
"version": "8.0.0",
"engines": {
"node": ">=14.0.0"
},
Expand Down Expand Up @@ -36,7 +36,7 @@
"mkdirp": "^1.0.4",
"rollup": "^2.66.1",
"rollup-plugin-sourcemaps": "^0.6.3",
"typescript": "~4.2.0",
"typescript": "~4.6.0",
"uglify-js": "^3.4.9",
"rimraf": "^3.0.0",
"@azure/identity": "^2.0.1",
Expand All @@ -46,8 +46,7 @@
"@types/chai": "^4.2.8",
"chai": "^4.2.0",
"cross-env": "^7.0.2",
"@azure/dev-tool": "^1.0.0",
"@azure/arm-storage": "^17.1.0"
"@azure/dev-tool": "^1.0.0"
},
"homepage": "https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/batch/arm-batch",
"repository": {
Expand Down Expand Up @@ -110,13 +109,5 @@
}
]
},
"autoPublish": true,
"//sampleConfiguration": {
"productName": "",
"productSlugs": [
"azure"
],
"disableDocsMs": true,
"apiRefLink": "https://docs.microsoft.com/javascript/api/@azure/arm-batch?view=azure-node-preview"
}
}
"autoPublish": true
}
11 changes: 8 additions & 3 deletions sdk/batch/arm-batch/review/arm-batch.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -661,7 +661,7 @@ export interface CifsMountConfiguration {
password: string;
relativeMountPath: string;
source: string;
username: string;
userName: string;
}

// @public
Expand Down Expand Up @@ -977,7 +977,7 @@ export type NameAvailabilityReason = "Invalid" | "AlreadyExists";

// @public
export interface NetworkConfiguration {
dynamicVNetAssignmentScope?: DynamicVNetAssignmentScope;
dynamicVnetAssignmentScope?: DynamicVNetAssignmentScope;
endpointConfiguration?: PoolEndpointConfiguration;
publicIPAddressConfiguration?: PublicIPAddressConfiguration;
subnetId?: string;
Expand Down Expand Up @@ -1007,6 +1007,9 @@ export interface NFSMountConfiguration {
source: string;
}

// @public
export type NodeCommunicationMode = "Default" | "Classic" | "Simplified";

// @public
export interface NodePlacementConfiguration {
policy?: NodePlacementPolicyType;
Expand Down Expand Up @@ -1088,6 +1091,7 @@ export interface Pool extends ProxyResource {
readonly creationTime?: Date;
readonly currentDedicatedNodes?: number;
readonly currentLowPriorityNodes?: number;
readonly currentNodeCommunicationMode?: NodeCommunicationMode;
deploymentConfiguration?: DeploymentConfiguration;
displayName?: string;
identity?: BatchPoolIdentity;
Expand All @@ -1101,6 +1105,7 @@ export interface Pool extends ProxyResource {
readonly resizeOperationStatus?: ResizeOperationStatus;
scaleSettings?: ScaleSettings;
startTask?: StartTask;
targetNodeCommunicationMode?: NodeCommunicationMode;
taskSchedulingPolicy?: TaskSchedulingPolicy;
taskSlotsPerNode?: number;
userAccounts?: UserAccount[];
Expand Down Expand Up @@ -1346,7 +1351,7 @@ export interface PrivateLinkResourceOperations {

// @public
export interface PrivateLinkServiceConnectionState {
readonly actionRequired?: string;
readonly actionsRequired?: string;
description?: string;
status: PrivateLinkServiceConnectionStatus;
}
Expand Down
41 changes: 24 additions & 17 deletions sdk/batch/arm-batch/src/batchManagementClient.ts
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ export class BatchManagementClient extends coreClient.ServiceClient {
credential: credentials
};

const packageDetails = `azsdk-js-arm-batch/7.2.1`;
const packageDetails = `azsdk-js-arm-batch/8.0.0`;
const userAgentPrefix =
options.userAgentOptions && options.userAgentOptions.userAgentPrefix
? `${options.userAgentOptions.userAgentPrefix} ${packageDetails}`
Expand All @@ -91,34 +91,41 @@ export class BatchManagementClient extends coreClient.ServiceClient {
};
super(optionsWithDefaults);

let bearerTokenAuthenticationPolicyFound: boolean = false;
if (options?.pipeline && options.pipeline.getOrderedPolicies().length > 0) {
const pipelinePolicies: coreRestPipeline.PipelinePolicy[] = options.pipeline.getOrderedPolicies();
const bearerTokenAuthenticationPolicyFound = pipelinePolicies.some(
bearerTokenAuthenticationPolicyFound = pipelinePolicies.some(
(pipelinePolicy) =>
pipelinePolicy.name ===
coreRestPipeline.bearerTokenAuthenticationPolicyName
);
if (!bearerTokenAuthenticationPolicyFound) {
this.pipeline.removePolicy({
name: coreRestPipeline.bearerTokenAuthenticationPolicyName
});
this.pipeline.addPolicy(
coreRestPipeline.bearerTokenAuthenticationPolicy({
scopes: `${optionsWithDefaults.baseUri}/.default`,
challengeCallbacks: {
authorizeRequestOnChallenge:
coreClient.authorizeRequestOnClaimChallenge
}
})
);
}
}
if (
!options ||
!options.pipeline ||
options.pipeline.getOrderedPolicies().length == 0 ||
!bearerTokenAuthenticationPolicyFound
) {
this.pipeline.removePolicy({
name: coreRestPipeline.bearerTokenAuthenticationPolicyName
});
this.pipeline.addPolicy(
coreRestPipeline.bearerTokenAuthenticationPolicy({
credential: credentials,
scopes: `${optionsWithDefaults.credentialScopes}`,
challengeCallbacks: {
authorizeRequestOnChallenge:
coreClient.authorizeRequestOnClaimChallenge
}
})
);
}
// Parameter assignments
this.subscriptionId = subscriptionId;

// Assigning values to Constant parameters
this.$host = options.$host || "https://management.azure.com";
this.apiVersion = options.apiVersion || "2022-06-01";
this.apiVersion = options.apiVersion || "2022-10-01";
this.batchAccountOperations = new BatchAccountOperationsImpl(this);
this.applicationPackageOperations = new ApplicationPackageOperationsImpl(
this
Expand Down
Loading