[AutoPR @azure/arm-loadtestservice] [Hub Generated] Review request for Microsoft.LoadTestService to add version stable/2022-12-01

sdk/loadtestservice/arm-loadtestservice/CHANGELOG.md

@@ -1,5 +1,5 @@
 # Release History
 
-## 1.0.0 (2022-10-24)
+## 1.0.0 (2022-11-04)
 
 The package of @azure/arm-loadtestservice is using our next generation design principles. To learn more, please refer to our documentation [Quick Start](https://aka.ms/js-track2-quickstart).

sdk/loadtestservice/arm-loadtestservice/_meta.json

@@ -1,8 +1,8 @@
 {
-  "commit": "3927945ce9bd4ac8c252b6bd558a2c42aa2877cc",
+  "commit": "dc3d2f94d80376afe2fe88a1424a71275a87e42e",
   "readme": "specification/loadtestservice/resource-manager/readme.md",
-  "autorest_command": "autorest --version=3.8.4 --typescript --modelerfour.lenient-model-deduplication --azure-arm --head-as-boolean=true --license-header=MICROSOFT_MIT_NO_VERSION --generate-test --typescript-sdks-folder=D:\\Git\\azure-sdk-for-js ..\\azure-rest-api-specs\\specification\\loadtestservice\\resource-manager\\readme.md --use=@autorest/typescript@6.0.0-rc.3.20221020.1 --generate-sample=true",
+  "autorest_command": "autorest --version=3.8.4 --typescript --modelerfour.lenient-model-deduplication --azure-arm --head-as-boolean=true --license-header=MICROSOFT_MIT_NO_VERSION --generate-test --typescript-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-js ../azure-rest-api-specs/specification/loadtestservice/resource-manager/readme.md --use=@autorest/typescript@6.0.0-rc.2",
   "repository_url": "https://github.com/Azure/azure-rest-api-specs.git",
-  "release_tool": "@azure-tools/js-sdk-release-tools@2.4.2",
-  "use": "@autorest/typescript@6.0.0-rc.3.20221020.1"
+  "release_tool": "@azure-tools/js-sdk-release-tools@2.5.0",
+  "use": "@autorest/typescript@6.0.0-rc.2"
 }

sdk/loadtestservice/arm-loadtestservice/package.json

@@ -11,7 +11,7 @@
     "@azure/core-lro": "^2.2.0",
     "@azure/abort-controller": "^1.0.0",
     "@azure/core-paging": "^1.2.0",
-    "@azure/core-client": "^1.6.1",
+    "@azure/core-client": "^1.5.0",
     "@azure/core-auth": "^1.3.0",
     "@azure/core-rest-pipeline": "^1.8.0",
     "tslib": "^2.2.0"
@@ -46,7 +46,6 @@
     "@types/chai": "^4.2.8",
     "chai": "^4.2.0",
     "cross-env": "^7.0.2",
-    "@types/node": "^14.0.0",
     "@azure/dev-tool": "^1.0.0"
   },
   "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/loadtestservice/arm-loadtestservice",
@@ -110,13 +109,5 @@
       }
     ]
   },
-  "autoPublish": true,
-  "//sampleConfiguration": {
-    "productName": "",
-    "productSlugs": [
-      "azure"
-    ],
-    "disableDocsMs": true,
-    "apiRefLink": "https://docs.microsoft.com/javascript/api/@azure/arm-loadtestservice?view=azure-node-preview"
-  }
+  "autoPublish": true
 }

sdk/loadtestservice/arm-loadtestservice/review/arm-loadtestservice.api.md

@@ -152,7 +152,9 @@ export interface LoadTestResourcePatchRequestBody {
     description?: string;
     encryption?: EncryptionProperties;
     identity?: ManagedServiceIdentity;
-    tags?: Record<string, unknown>;
+    tags?: {
+        [propertyName: string]: string | null;
+    };
 }
 
 // @public
@@ -248,7 +250,7 @@ export interface ManagedServiceIdentity {
     readonly tenantId?: string;
     type: ManagedServiceIdentityType;
     userAssignedIdentities?: {
-        [propertyName: string]: UserAssignedIdentity;
+        [propertyName: string]: UserAssignedIdentity | null;
     };
 }
 

sdk/loadtestservice/arm-loadtestservice/src/models/index.ts

@@ -222,7 +222,9 @@ export interface ManagedServiceIdentity {
   /** Type of managed service identity (where both SystemAssigned and UserAssigned types are allowed). */
   type: ManagedServiceIdentityType;
   /** The set of user assigned identities associated with the resource. The userAssignedIdentities dictionary keys will be ARM resource ids in the form: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ManagedIdentity/userAssignedIdentities/{identityName}. The dictionary values can be empty objects ({}) in requests. */
-  userAssignedIdentities?: { [propertyName: string]: UserAssignedIdentity };
+  userAssignedIdentities?: {
+    [propertyName: string]: UserAssignedIdentity | null;
+  };
 }
 
 /** User assigned identity properties */
@@ -242,7 +244,7 @@ export interface UserAssignedIdentity {
 /** LoadTest resource patch request body. */
 export interface LoadTestResourcePatchRequestBody {
   /** Resource tags. */
-  tags?: Record<string, unknown>;
+  tags?: { [propertyName: string]: string | null };
   /** The type of identity used for the resource. */
   identity?: ManagedServiceIdentity;
   /** Description of the resource. */

sdk/loadtestservice/arm-loadtestservice/src/models/mappers.ts

@@ -414,6 +414,7 @@ export const EncryptionPropertiesIdentity: coreClient.CompositeMapper = {
       },
       resourceId: {
         serializedName: "resourceId",
+        nullable: true,
         type: {
           name: "String"
         }
@@ -491,9 +492,10 @@ export const LoadTestResourcePatchRequestBody: coreClient.CompositeMapper = {
     modelProperties: {
       tags: {
         serializedName: "tags",
+        nullable: true,
         type: {
           name: "Dictionary",
-          value: { type: { name: "any" } }
+          value: { type: { name: "String" } }
         }
       },
       identity: {

sdk/loadtestservice/arm-loadtestservice/test/sampleTest.ts

@@ -0,0 +1,43 @@
+/*
+ * Copyright (c) Microsoft Corporation.
+ * Licensed under the MIT License.
+ *
+ * Code generated by Microsoft (R) AutoRest Code Generator.
+ * Changes may cause incorrect behavior and will be lost if the code is regenerated.
+ */
+
+import {
+  Recorder,
+  RecorderStartOptions,
+  env
+} from "@azure-tools/test-recorder";
+import { assert } from "chai";
+import { Context } from "mocha";
+
+const replaceableVariables: Record<string, string> = {
+  AZURE_CLIENT_ID: "azure_client_id",
+  AZURE_CLIENT_SECRET: "azure_client_secret",
+  AZURE_TENANT_ID: "88888888-8888-8888-8888-888888888888",
+  SUBSCRIPTION_ID: "azure_subscription_id"
+};
+
+const recorderOptions: RecorderStartOptions = {
+  envSetupForPlayback: replaceableVariables
+};
+
+describe("My test", () => {
+  let recorder: Recorder;
+
+  beforeEach(async function(this: Context) {
+    recorder = new Recorder(this.currentTest);
+    await recorder.start(recorderOptions);
+  });
+
+  afterEach(async function() {
+    await recorder.stop();
+  });
+
+  it("sample test", async function() {
+    console.log("Hi, I'm a test!");
+  });
+});

sdk/loadtestservice/arm-loadtestservice/tsconfig.json

@@ -15,17 +15,11 @@
     ],
     "declaration": true,
     "outDir": "./dist-esm",
-    "importHelpers": true,
-    "paths": {
-      "@azure/arm-loadtestservice": [
-        "./src/index"
-      ]
-    }
+    "importHelpers": true
   },
   "include": [
     "./src/**/*.ts",
-    "./test/**/*.ts",
-    "samples-dev/**/*.ts"
+    "./test/**/*.ts"
   ],
   "exclude": [
     "node_modules"