Skip to content

[AutoPR azure-resourcemanager-appconfiguration] Add restler config to improve coverage of appconfig traffic validation #1768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
azure-sdk wants to merge 1 commit into from
Closed

[AutoPR azure-resourcemanager-appconfiguration] Add restler config to improve coverage of appconfig traffic validation #1768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sdk/appconfiguration/azure-resourcemanager-appconfiguration/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
# Release History

## 1.0.0-beta.7 (Unreleased)
## 1.0.0-beta.1 (2022-09-07)

- Azure Resource Manager AppConfiguration client library for Java. This package contains Microsoft Azure SDK for AppConfiguration Management SDK. Package tag package-2022-05-01. For documentation on how to use this package, please see [Azure Management Libraries for Java](https://aka.ms/azsdk/java/mgmt).

### Features Added

Expand Down
2 changes: 1 addition & 1 deletion sdk/appconfiguration/azure-resourcemanager-appconfiguration/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Various documentation is available to help you get started
<dependency>
<groupId>com.azure.resourcemanager</groupId>
<artifactId>azure-resourcemanager-appconfiguration</artifactId>
<version>1.0.0-beta.6</version>
<version>1.0.0-beta.7</version>
</dependency>
```
[//]: # ({x-version-update-end})
Expand Down
2 changes: 1 addition & 1 deletion ...ion/src/main/java/com/azure/resourcemanager/appconfiguration/AppConfigurationManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ public AppConfigurationManager authenticate(TokenCredential credential, AzurePro
.append("-")
.append("com.azure.resourcemanager.appconfiguration")
.append("/")
.append("1.0.0-beta.6");
.append("1.0.0-beta.1");
if (!Configuration.getGlobalConfiguration().get("AZURE_TELEMETRY_DISABLED", false)) {
userAgentBuilder
.append(" (")
Expand Down
3 changes: 1 addition & 2 deletions ...n/src/main/java/com/azure/resourcemanager/appconfiguration/fluent/models/ApiKeyInner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,7 @@ public final class ApiKeyInner {
private String value;

/*
* A connection string that can be used by supporting clients for
* authentication.
* A connection string that can be used by supporting clients for authentication.
*/
@JsonProperty(value = "connectionString", access = JsonProperty.Access.WRITE_ONLY)
private String connectionString;
Expand Down
12 changes: 4 additions & 8 deletions ...om/azure/resourcemanager/appconfiguration/fluent/models/ConfigurationStoreProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,15 +42,13 @@ public final class ConfigurationStoreProperties {
private EncryptionProperties encryption;

/*
* The list of private endpoint connections that are set up for this
* resource.
* The list of private endpoint connections that are set up for this resource.
*/
@JsonProperty(value = "privateEndpointConnections", access = JsonProperty.Access.WRITE_ONLY)
private List<PrivateEndpointConnectionReference> privateEndpointConnections;

/*
* Control permission for data plane traffic coming from public networks
* while private endpoint is enabled.
* Control permission for data plane traffic coming from public networks while private endpoint is enabled.
*/
@JsonProperty(value = "publicNetworkAccess")
private PublicNetworkAccess publicNetworkAccess;
Expand All @@ -62,15 +60,13 @@ public final class ConfigurationStoreProperties {
private Boolean disableLocalAuth;

/*
* The amount of time in days that the configuration store will be retained
* when it is soft deleted.
* The amount of time in days that the configuration store will be retained when it is soft deleted.
*/
@JsonProperty(value = "softDeleteRetentionInDays")
private Integer softDeleteRetentionInDays;

/*
* Property specifying whether protection against purge is enabled for this
* configuration store.
* Property specifying whether protection against purge is enabled for this configuration store.
*/
@JsonProperty(value = "enablePurgeProtection")
private Boolean enablePurgeProtection;
Expand Down
6 changes: 2 additions & 4 deletions ...emanager/appconfiguration/fluent/models/ConfigurationStorePropertiesUpdateParameters.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,13 @@ public final class ConfigurationStorePropertiesUpdateParameters {
private Boolean disableLocalAuth;

/*
* Control permission for data plane traffic coming from public networks
* while private endpoint is enabled.
* Control permission for data plane traffic coming from public networks while private endpoint is enabled.
*/
@JsonProperty(value = "publicNetworkAccess")
private PublicNetworkAccess publicNetworkAccess;

/*
* Property specifying whether protection against purge is enabled for this
* configuration store.
* Property specifying whether protection against purge is enabled for this configuration store.
*/
@JsonProperty(value = "enablePurgeProtection")
private Boolean enablePurgeProtection;
Expand Down
18 changes: 6 additions & 12 deletions ...ain/java/com/azure/resourcemanager/appconfiguration/fluent/models/KeyValueProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,14 @@
public final class KeyValueProperties {
/*
* The primary identifier of a key-value.
* The key is used in unison with the label to uniquely identify a
* key-value.
* The key is used in unison with the label to uniquely identify a key-value.
*/
@JsonProperty(value = "key", access = JsonProperty.Access.WRITE_ONLY)
private String key;

/*
* A value used to group key-values.
* The label is used in unison with the key to uniquely identify a
* key-value.
* The label is used in unison with the key to uniquely identify a key-value.
*/
@JsonProperty(value = "label", access = JsonProperty.Access.WRITE_ONLY)
private String label;
Expand All @@ -37,22 +35,19 @@ public final class KeyValueProperties {

/*
* The content type of the key-value's value.
* Providing a proper content-type can enable transformations of values
* when they are retrieved by applications.
* Providing a proper content-type can enable transformations of values when they are retrieved by applications.
*/
@JsonProperty(value = "contentType")
private String contentType;

/*
* An ETag indicating the state of a key-value within a configuration
* store.
* An ETag indicating the state of a key-value within a configuration store.
*/
@JsonProperty(value = "eTag", access = JsonProperty.Access.WRITE_ONLY)
private String etag;

/*
* The last time a modifying operation was performed on the given
* key-value.
* The last time a modifying operation was performed on the given key-value.
*/
@JsonProperty(value = "lastModified", access = JsonProperty.Access.WRITE_ONLY)
private OffsetDateTime lastModified;
Expand All @@ -65,8 +60,7 @@ public final class KeyValueProperties {
private Boolean locked;

/*
* A dictionary of tags that can help identify what a key-value may be
* applicable for.
* A dictionary of tags that can help identify what a key-value may be applicable for.
*/
@JsonProperty(value = "tags")
@JsonInclude(value = JsonInclude.Include.NON_NULL, content = JsonInclude.Include.ALWAYS)
Expand Down
3 changes: 1 addition & 2 deletions ...com/azure/resourcemanager/appconfiguration/fluent/models/NameAvailabilityStatusInner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@ public final class NameAvailabilityStatusInner {
private Boolean nameAvailable;

/*
* If any, the error message that provides more detail for the reason that
* the name is not available.
* If any, the error message that provides more detail for the reason that the name is not available.
*/
@JsonProperty(value = "message", access = JsonProperty.Access.WRITE_ONLY)
private String message;
Expand Down
3 changes: 1 addition & 2 deletions ...e/resourcemanager/appconfiguration/fluent/models/PrivateEndpointConnectionProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@ public final class PrivateEndpointConnectionProperties {
private PrivateEndpoint privateEndpoint;

/*
* A collection of information about the state of the connection between
* service consumer and provider.
* A collection of information about the state of the connection between service consumer and provider.
*/
@JsonProperty(value = "privateLinkServiceConnectionState", required = true)
private PrivateLinkServiceConnectionState privateLinkServiceConnectionState;
Expand Down
34 changes: 18 additions & 16 deletions ...ourcemanager/appconfiguration/implementation/AppConfigurationManagementClientBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,24 +119,26 @@ public AppConfigurationManagementClientBuilder serializerAdapter(SerializerAdapt
* @return an instance of AppConfigurationManagementClientImpl.
*/
public AppConfigurationManagementClientImpl buildClient() {
if (endpoint == null) {
this.endpoint = "https://management.azure.com";
}
if (environment == null) {
this.environment = AzureEnvironment.AZURE;
}
if (pipeline == null) {
this.pipeline = new HttpPipelineBuilder().policies(new UserAgentPolicy(), new RetryPolicy()).build();
}
if (defaultPollInterval == null) {
this.defaultPollInterval = Duration.ofSeconds(30);
}
if (serializerAdapter == null) {
this.serializerAdapter = SerializerFactory.createDefaultManagementSerializerAdapter();
}
String localEndpoint = (endpoint != null) ? endpoint : "https://management.azure.com";
AzureEnvironment localEnvironment = (environment != null) ? environment : AzureEnvironment.AZURE;
HttpPipeline localPipeline =
(pipeline != null)
? pipeline
: new HttpPipelineBuilder().policies(new UserAgentPolicy(), new RetryPolicy()).build();
Duration localDefaultPollInterval =
(defaultPollInterval != null) ? defaultPollInterval : Duration.ofSeconds(30);
SerializerAdapter localSerializerAdapter =
(serializerAdapter != null)
? serializerAdapter
: SerializerFactory.createDefaultManagementSerializerAdapter();
AppConfigurationManagementClientImpl client =
new AppConfigurationManagementClientImpl(
pipeline, serializerAdapter, defaultPollInterval, environment, subscriptionId, endpoint);
localPipeline,
localSerializerAdapter,
localDefaultPollInterval,
localEnvironment,
subscriptionId,
localEndpoint);
return client;
}
}
24 changes: 16 additions & 8 deletions .../azure/resourcemanager/appconfiguration/implementation/ConfigurationStoresClientImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2551,7 +2551,8 @@ public void purgeDeleted(String location, String configStoreName, Context contex
/**
* Get the next page of items.
*
* @param nextLink The nextLink parameter.
* @param nextLink The URL to get the next list of items
* <p>The nextLink parameter.
* @throws IllegalArgumentException thrown if parameters fail the validation.
* @throws ManagementException thrown if the request is rejected by server.
* @throws RuntimeException all other wrapped checked exceptions if the request fails to be sent.
Expand Down Expand Up @@ -2587,7 +2588,8 @@ private Mono<PagedResponse<ConfigurationStoreInner>> listNextSinglePageAsync(Str
/**
* Get the next page of items.
*
* @param nextLink The nextLink parameter.
* @param nextLink The URL to get the next list of items
* <p>The nextLink parameter.
* @param context The context to associate with this operation.
* @throws IllegalArgumentException thrown if parameters fail the validation.
* @throws ManagementException thrown if the request is rejected by server.
Expand Down Expand Up @@ -2624,7 +2626,8 @@ private Mono<PagedResponse<ConfigurationStoreInner>> listNextSinglePageAsync(Str
/**
* Get the next page of items.
*
* @param nextLink The nextLink parameter.
* @param nextLink The URL to get the next list of items
* <p>The nextLink parameter.
* @throws IllegalArgumentException thrown if parameters fail the validation.
* @throws ManagementException thrown if the request is rejected by server.
* @throws RuntimeException all other wrapped checked exceptions if the request fails to be sent.
Expand Down Expand Up @@ -2661,7 +2664,8 @@ private Mono<PagedResponse<ConfigurationStoreInner>> listByResourceGroupNextSing
/**
* Get the next page of items.
*
* @param nextLink The nextLink parameter.
* @param nextLink The URL to get the next list of items
* <p>The nextLink parameter.
* @param context The context to associate with this operation.
* @throws IllegalArgumentException thrown if parameters fail the validation.
* @throws ManagementException thrown if the request is rejected by server.
Expand Down Expand Up @@ -2699,7 +2703,8 @@ private Mono<PagedResponse<ConfigurationStoreInner>> listByResourceGroupNextSing
/**
* Get the next page of items.
*
* @param nextLink The nextLink parameter.
* @param nextLink The URL to get the next list of items
* <p>The nextLink parameter.
* @throws IllegalArgumentException thrown if parameters fail the validation.
* @throws ManagementException thrown if the request is rejected by server.
* @throws RuntimeException all other wrapped checked exceptions if the request fails to be sent.
Expand Down Expand Up @@ -2735,7 +2740,8 @@ private Mono<PagedResponse<ApiKeyInner>> listKeysNextSinglePageAsync(String next
/**
* Get the next page of items.
*
* @param nextLink The nextLink parameter.
* @param nextLink The URL to get the next list of items
* <p>The nextLink parameter.
* @param context The context to associate with this operation.
* @throws IllegalArgumentException thrown if parameters fail the validation.
* @throws ManagementException thrown if the request is rejected by server.
Expand Down Expand Up @@ -2772,7 +2778,8 @@ private Mono<PagedResponse<ApiKeyInner>> listKeysNextSinglePageAsync(String next
/**
* Get the next page of items.
*
* @param nextLink The nextLink parameter.
* @param nextLink The URL to get the next list of items
* <p>The nextLink parameter.
* @throws IllegalArgumentException thrown if parameters fail the validation.
* @throws ManagementException thrown if the request is rejected by server.
* @throws RuntimeException all other wrapped checked exceptions if the request fails to be sent.
Expand Down Expand Up @@ -2808,7 +2815,8 @@ private Mono<PagedResponse<DeletedConfigurationStoreInner>> listDeletedNextSingl
/**
* Get the next page of items.
*
* @param nextLink The nextLink parameter.
* @param nextLink The URL to get the next list of items
* <p>The nextLink parameter.
* @param context The context to associate with this operation.
* @throws IllegalArgumentException thrown if parameters fail the validation.
* @throws ManagementException thrown if the request is rejected by server.
Expand Down
6 changes: 4 additions & 2 deletions ...n/java/com/azure/resourcemanager/appconfiguration/implementation/KeyValuesClientImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1002,7 +1002,8 @@ public void delete(String resourceGroupName, String configStoreName, String keyV
/**
* Get the next page of items.
*
* @param nextLink The nextLink parameter.
* @param nextLink The URL to get the next list of items
* <p>The nextLink parameter.
* @throws IllegalArgumentException thrown if parameters fail the validation.
* @throws ManagementException thrown if the request is rejected by server.
* @throws RuntimeException all other wrapped checked exceptions if the request fails to be sent.
Expand Down Expand Up @@ -1039,7 +1040,8 @@ private Mono<PagedResponse<KeyValueInner>> listByConfigurationStoreNextSinglePag
/**
* Get the next page of items.
*
* @param nextLink The nextLink parameter.
* @param nextLink The URL to get the next list of items
* <p>The nextLink parameter.
* @param context The context to associate with this operation.
* @throws IllegalArgumentException thrown if parameters fail the validation.
* @throws ManagementException thrown if the request is rejected by server.
Expand Down
6 changes: 4 additions & 2 deletions .../java/com/azure/resourcemanager/appconfiguration/implementation/OperationsClientImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,7 +565,8 @@ public Response<NameAvailabilityStatusInner> regionalCheckNameAvailabilityWithRe
/**
* Get the next page of items.
*
* @param nextLink The nextLink parameter.
* @param nextLink The URL to get the next list of items
* <p>The nextLink parameter.
* @throws IllegalArgumentException thrown if parameters fail the validation.
* @throws ManagementException thrown if the request is rejected by server.
* @throws RuntimeException all other wrapped checked exceptions if the request fails to be sent.
Expand Down Expand Up @@ -601,7 +602,8 @@ private Mono<PagedResponse<OperationDefinitionInner>> listNextSinglePageAsync(St
/**
* Get the next page of items.
*
* @param nextLink The nextLink parameter.
* @param nextLink The URL to get the next list of items
* <p>The nextLink parameter.
* @param context The context to associate with this operation.
* @throws IllegalArgumentException thrown if parameters fail the validation.
* @throws ManagementException thrown if the request is rejected by server.
Expand Down
6 changes: 4 additions & 2 deletions ...resourcemanager/appconfiguration/implementation/PrivateEndpointConnectionsClientImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1115,7 +1115,8 @@ public void delete(
/**
* Get the next page of items.
*
* @param nextLink The nextLink parameter.
* @param nextLink The URL to get the next list of items
* <p>The nextLink parameter.
* @throws IllegalArgumentException thrown if parameters fail the validation.
* @throws ManagementException thrown if the request is rejected by server.
* @throws RuntimeException all other wrapped checked exceptions if the request fails to be sent.
Expand Down Expand Up @@ -1153,7 +1154,8 @@ private Mono<PagedResponse<PrivateEndpointConnectionInner>> listByConfigurationS
/**
* Get the next page of items.
*
* @param nextLink The nextLink parameter.
* @param nextLink The URL to get the next list of items
* <p>The nextLink parameter.
* @param context The context to associate with this operation.
* @throws IllegalArgumentException thrown if parameters fail the validation.
* @throws ManagementException thrown if the request is rejected by server.
Expand Down
6 changes: 4 additions & 2 deletions ...azure/resourcemanager/appconfiguration/implementation/PrivateLinkResourcesClientImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,8 @@ public Response<PrivateLinkResourceInner> getWithResponse(
/**
* Get the next page of items.
*
* @param nextLink The nextLink parameter.
* @param nextLink The URL to get the next list of items
* <p>The nextLink parameter.
* @throws IllegalArgumentException thrown if parameters fail the validation.
* @throws ManagementException thrown if the request is rejected by server.
* @throws RuntimeException all other wrapped checked exceptions if the request fails to be sent.
Expand Down Expand Up @@ -490,7 +491,8 @@ private Mono<PagedResponse<PrivateLinkResourceInner>> listByConfigurationStoreNe
/**
* Get the next page of items.
*
* @param nextLink The nextLink parameter.
* @param nextLink The URL to get the next list of items
* <p>The nextLink parameter.
* @param context The context to associate with this operation.
* @throws IllegalArgumentException thrown if parameters fail the validation.
* @throws ManagementException thrown if the request is rejected by server.
Expand Down
2 changes: 1 addition & 1 deletion ...tion/src/main/java/com/azure/resourcemanager/appconfiguration/models/ActionsRequired.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import com.fasterxml.jackson.annotation.JsonCreator;
import java.util.Collection;

/** Defines values for ActionsRequired. */
/** Any action that is required beyond basic workflow (approve/ reject/ disconnect). */
public final class ActionsRequired extends ExpandableStringEnum<ActionsRequired> {
/** Static value None for ActionsRequired. */
public static final ActionsRequired NONE = fromString("None");
Expand Down
2 changes: 1 addition & 1 deletion ...ain/java/com/azure/resourcemanager/appconfiguration/models/ConfigurationResourceType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import com.fasterxml.jackson.annotation.JsonCreator;
import java.util.Collection;

/** Defines values for ConfigurationResourceType. */
/** The resource type to check for name availability. */
public final class ConfigurationResourceType extends ExpandableStringEnum<ConfigurationResourceType> {
/** Static value Microsoft.AppConfiguration/configurationStores for ConfigurationResourceType. */
public static final ConfigurationResourceType MICROSOFT_APP_CONFIGURATION_CONFIGURATION_STORES =
Expand Down
2 changes: 1 addition & 1 deletion ...ion/src/main/java/com/azure/resourcemanager/appconfiguration/models/ConnectionStatus.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import com.fasterxml.jackson.annotation.JsonCreator;
import java.util.Collection;

/** Defines values for ConnectionStatus. */
/** The private link service connection status. */
public final class ConnectionStatus extends ExpandableStringEnum<ConnectionStatus> {
/** Static value Pending for ConnectionStatus. */
public static final ConnectionStatus PENDING = fromString("Pending");
Expand Down
Loading