Skip to content

Commit a22a073

Browse files
srnagarsrnagar
authored
Update codeowners and CI config for AOT (Azure#28604)
* Update codeowners and CI config for AOT * disable revapi check for samples package
1 parent 486e78b commit a22a073

File tree

5 files changed

+137
-25
lines changed

5 files changed

+137
-25
lines changed

‎.github/CODEOWNERS‎

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
################
77

88
# Git Hub integration and bot rules
9-
/.github/ @AlexGhiondea @jsquire
9+
/.github/ @AlexGhiondea @jsquire
1010

1111
###########
1212
# SDK
@@ -19,11 +19,15 @@
1919
# PRLabel: %bom
2020
/sdk/boms/azure-sdk-bom/ @pallavit @alzimmermsft @jonathangiles @srnagar @anuchandy
2121
# PRLabel: %azure-spring
22-
/sdk/boms/spring-cloud-azure-dependencies/ @backwind1233 @chenrujun @hui1110 @jialigit @netyyyy @saragluna @stliu @yiliuTo
22+
/sdk/boms/spring-cloud-azure-dependencies/ @backwind1233 @chenrujun @hui1110 @jialigit @netyyyy @saragluna @stliu @yiliuTo
2323

2424
####
2525
# Service teams
2626
####
27+
28+
# PRLabel: %AOT
29+
/sdk/aot/ @srnagar @jonathangiles
30+
2731
# PRLabel: %App Configuration
2832
/sdk/appconfiguration/ @mssfang @alzimmermsft
2933
# PRLabel: %azure-spring

‎sdk/aot/azure-aot-graalvm-samples/pom.xml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,8 @@
4343

4444
<properties>
4545
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
46+
<!-- This sample package is not released to maven and revapi checks are not required -->
47+
<revapi.skip>true</revapi.skip>
4648
<legal>
4749
<![CDATA[[INFO] Any downloads listed may be third party software. Microsoft grants you no rights for third party software.]]></legal>
4850
</properties>

‎sdk/aot/azure-aot-graalvm-support-netty/pom.xml‎

Lines changed: 70 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -129,25 +129,76 @@
129129
</configuration>
130130
</plugin>
131131

132-
<!-- We must generate an empty javadoc JAR file to publish to Maven Central because this package does not contain any public sources -->
133-
<plugin>
134-
<groupId>org.apache.maven.plugins</groupId>
135-
<artifactId>maven-jar-plugin</artifactId>
136-
<version>3.1.2</version> <!-- {x-version-update;org.apache.maven.plugins:maven-jar-plugin;external_dependency} -->
137-
<executions>
138-
<execution>
139-
<id>empty-javadoc-jar</id>
140-
<phase>package</phase>
141-
<goals>
142-
<goal>jar</goal>
143-
</goals>
144-
<configuration>
145-
<classifier>javadoc</classifier>
146-
<classesDirectory>${basedir}/javadoc</classesDirectory>
147-
</configuration>
148-
</execution>
149-
</executions>
150-
</plugin>
132+
<!-- START: Empty Java Doc -->
133+
<!-- The following code will generate an empty javadoc with just a README.md. This is necessary
134+
to pass the required checks on Maven. The way this works is by setting the classesDirectory
135+
to a directory that only contains the README.md, which we need to copy. If the classesDirectory
136+
is set to the root, where the README.md lives, it still won't have javadocs but the jar file
137+
will contain a bunch of files that shouldn't be there. The faux sources directory is deleted
138+
and recreated with the README.md being copied every time to guarantee that, when building locally,
139+
it'll have the latest copy of the README.md file.
140+
-->
141+
<plugin>
142+
<groupId>org.apache.maven.plugins</groupId>
143+
<artifactId>maven-javadoc-plugin</artifactId>
144+
<version>3.3.1</version> <!-- {x-version-update;org.apache.maven.plugins:maven-javadoc-plugin;external_dependency} -->
145+
<executions>
146+
<execution>
147+
<id>attach-javadocs</id>
148+
<goals>
149+
<goal>jar</goal>
150+
</goals>
151+
<configuration>
152+
<skip>true</skip>
153+
</configuration>
154+
</execution>
155+
</executions>
156+
</plugin>
157+
<plugin>
158+
<groupId>org.apache.maven.plugins</groupId>
159+
<artifactId>maven-jar-plugin</artifactId>
160+
<version>3.1.2</version> <!-- {x-version-update;org.apache.maven.plugins:maven-jar-plugin;external_dependency} -->
161+
<executions>
162+
<execution>
163+
<id>empty-javadoc-jar-with-readme</id>
164+
<phase>package</phase>
165+
<goals>
166+
<goal>jar</goal>
167+
</goals>
168+
<configuration>
169+
<classifier>javadoc</classifier>
170+
<classesDirectory>${project.basedir}/javadocTemp</classesDirectory>
171+
</configuration>
172+
</execution>
173+
</executions>
174+
</plugin>
175+
<plugin>
176+
<groupId>org.apache.maven.plugins</groupId>
177+
<artifactId>maven-antrun-plugin</artifactId>
178+
<version>1.8</version> <!-- {x-version-update;org.apache.maven.plugins:maven-antrun-plugin;external_dependency} -->
179+
<executions>
180+
<execution>
181+
<id>copy-readme-to-javadocTemp</id>
182+
<phase>prepare-package</phase>
183+
<configuration>
184+
<target>
185+
<echo>Deleting existing ${project.basedir}/javadocTemp</echo>
186+
<delete includeEmptyDirs="true" quiet="true">
187+
<fileset dir="${project.basedir}/javadocTemp"/>
188+
</delete>
189+
<echo>Copying ${project.basedir}/README.md to
190+
${project.basedir}/javadocTemp/README.md
191+
</echo>
192+
<copy file="${project.basedir}/README.md" tofile="${project.basedir}/javadocTemp/README.md"/>
193+
</target>
194+
</configuration>
195+
<goals>
196+
<goal>run</goal>
197+
</goals>
198+
</execution>
199+
</executions>
200+
</plugin>
201+
<!-- END: Empty Java Doc -->
151202
</plugins>
152203
</build>
153204
</project>

‎sdk/aot/azure-aot-graalvm-support/pom.xml‎

Lines changed: 54 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,25 +85,76 @@
8585
</configuration>
8686
</plugin>
8787

88-
<!-- We must generate an empty javadoc JAR file to publish to Maven Central because this package does not contain any public sources -->
88+
<!-- START: Empty Java Doc -->
89+
<!-- The following code will generate an empty javadoc with just a README.md. This is necessary
90+
to pass the required checks on Maven. The way this works is by setting the classesDirectory
91+
to a directory that only contains the README.md, which we need to copy. If the classesDirectory
92+
is set to the root, where the README.md lives, it still won't have javadocs but the jar file
93+
will contain a bunch of files that shouldn't be there. The faux sources directory is deleted
94+
and recreated with the README.md being copied every time to guarantee that, when building locally,
95+
it'll have the latest copy of the README.md file.
96+
-->
97+
<plugin>
98+
<groupId>org.apache.maven.plugins</groupId>
99+
<artifactId>maven-javadoc-plugin</artifactId>
100+
<version>3.3.1</version> <!-- {x-version-update;org.apache.maven.plugins:maven-javadoc-plugin;external_dependency} -->
101+
<executions>
102+
<execution>
103+
<id>attach-javadocs</id>
104+
<goals>
105+
<goal>jar</goal>
106+
</goals>
107+
<configuration>
108+
<skip>true</skip>
109+
</configuration>
110+
</execution>
111+
</executions>
112+
</plugin>
89113
<plugin>
90114
<groupId>org.apache.maven.plugins</groupId>
91115
<artifactId>maven-jar-plugin</artifactId>
92116
<version>3.1.2</version> <!-- {x-version-update;org.apache.maven.plugins:maven-jar-plugin;external_dependency} -->
93117
<executions>
94118
<execution>
95-
<id>empty-javadoc-jar</id>
119+
<id>empty-javadoc-jar-with-readme</id>
96120
<phase>package</phase>
97121
<goals>
98122
<goal>jar</goal>
99123
</goals>
100124
<configuration>
101125
<classifier>javadoc</classifier>
102-
<classesDirectory>${basedir}/javadoc</classesDirectory>
126+
<classesDirectory>${project.basedir}/javadocTemp</classesDirectory>
103127
</configuration>
104128
</execution>
105129
</executions>
106130
</plugin>
131+
<plugin>
132+
<groupId>org.apache.maven.plugins</groupId>
133+
<artifactId>maven-antrun-plugin</artifactId>
134+
<version>1.8</version> <!-- {x-version-update;org.apache.maven.plugins:maven-antrun-plugin;external_dependency} -->
135+
<executions>
136+
<execution>
137+
<id>copy-readme-to-javadocTemp</id>
138+
<phase>prepare-package</phase>
139+
<configuration>
140+
<target>
141+
<echo>Deleting existing ${project.basedir}/javadocTemp</echo>
142+
<delete includeEmptyDirs="true" quiet="true">
143+
<fileset dir="${project.basedir}/javadocTemp"/>
144+
</delete>
145+
<echo>Copying ${project.basedir}/README.md to
146+
${project.basedir}/javadocTemp/README.md
147+
</echo>
148+
<copy file="${project.basedir}/README.md" tofile="${project.basedir}/javadocTemp/README.md"/>
149+
</target>
150+
</configuration>
151+
<goals>
152+
<goal>run</goal>
153+
</goals>
154+
</execution>
155+
</executions>
156+
</plugin>
157+
<!-- END: Empty Java Doc -->
107158
</plugins>
108159
</build>
109160
</project>

‎sdk/aot/ci.yml‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,4 +40,8 @@ extends:
4040
- name: azure-aot-graalvm-support-netty
4141
groupId: com.azure
4242
safeName: azureaotgraalvmsupportnetty
43-
43+
AdditionalModules:
44+
- name: azure-aot-graalvm-samples
45+
groupId: com.azure
46+
- name: azure-aot-graalvm-perf
47+
groupId: com.azure

0 commit comments

Comments
 (0)