-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Update codeowners and CI config for AOT #28604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
API change check for API changes are not detected in this pull request for |
|
API change check for API changes are not detected in this pull request for |
JimSuplizio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@srnagar this may or may not actually appease the MSDocs. Either way, having the readme instead of a pure empty javadoc is the right way to go.
|
|
||
| # Git Hub integration and bot rules | ||
| /.github/ @AlexGhiondea @jsquire | ||
| /.github/ @AlexGhiondea @jsquire |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlexGhiondea, @jsquire, do you want to scope this to the fabricbot.json file so you aren't pinged for review when CODEOWNERs change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alzimmermsft: Please do not change this. We need visibility on CODEOWNERS changes in order to keep the bot rules up to date with "Service Attention" contacts or when paths for PR labels change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, didn't realize it was tied closely to CODEOWNERS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, it is - and its currently a manual sync due to bot limitations.
This PR updates the codeowners for
sdk/aot/directory, includes perf and samples packages as additional modules and creates javadoc jar with README.