Skip to content

Conversation

@srnagar
Copy link
Member

@srnagar srnagar commented Apr 29, 2022

This PR updates the codeowners for sdk/aot/ directory, includes perf and samples packages as additional modules and creates javadoc jar with README.

@azure-sdk
Copy link
Collaborator

API change check for com.azure:azure-aot-graalvm-support

API changes are not detected in this pull request for com.azure:azure-aot-graalvm-support

@azure-sdk
Copy link
Collaborator

API change check for com.azure:azure-aot-graalvm-support-netty

API changes are not detected in this pull request for com.azure:azure-aot-graalvm-support-netty

Copy link
Contributor

@JimSuplizio JimSuplizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srnagar this may or may not actually appease the MSDocs. Either way, having the readme instead of a pure empty javadoc is the right way to go.


# Git Hub integration and bot rules
/.github/ @AlexGhiondea @jsquire
/.github/ @AlexGhiondea @jsquire
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlexGhiondea, @jsquire, do you want to scope this to the fabricbot.json file so you aren't pinged for review when CODEOWNERs change?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alzimmermsft: Please do not change this. We need visibility on CODEOWNERS changes in order to keep the bot rules up to date with "Service Attention" contacts or when paths for PR labels change.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, didn't realize it was tied closely to CODEOWNERS

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, it is - and its currently a manual sync due to bot limitations.

@srnagar srnagar merged commit a22a073 into Azure:main May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants