Skip to content

[AutoPR app] Update description for CORS policy properties #1942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
azure-sdk wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[AutoPR app] Update description for CORS policy properties #1942

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions schemas/2022-01-01-preview/Microsoft.App.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1447,7 +1447,7 @@
},
"certificateId": {
"type": "string",
"description": "Resource Id of the Certificate to be bound to this hostname."
"description": "Resource Id of the Certificate to be bound to this hostname. Must exist in the Managed Environment."
},
"name": {
"type": "string",
Expand Down Expand Up @@ -2811,8 +2811,7 @@
"maxReplicas": {
"oneOf": [
{
"type": "integer",
"default": "10"
"type": "integer"
},
{
"$ref": "https://schema.management.azure.com/schemas/common/definitions.json#/definitions/expression"
Expand Down Expand Up @@ -3105,7 +3104,7 @@
},
"runtimeSubnetId": {
"type": "string",
"description": "Resource ID of a subnet that Container App containers are injected into. This subnet must be in the same VNET as the subnet defined in infrastructureSubnetId. Must not overlap with any other provided IP ranges."
"description": "This field is deprecated and not used. If you wish to provide your own subnet that Container App containers are injected into, then you should leverage the infrastructureSubnetId."
}
},
"description": "Configuration properties for apps environment to join a Virtual Network"
Expand Down
16 changes: 6 additions & 10 deletions schemas/2022-03-01/Microsoft.App.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1447,7 +1447,7 @@
},
"certificateId": {
"type": "string",
"description": "Resource Id of the Certificate to be bound to this hostname."
"description": "Resource Id of the Certificate to be bound to this hostname. Must exist in the Managed Environment."
},
"name": {
"type": "string",
Expand Down Expand Up @@ -1573,8 +1573,7 @@
"enabled": {
"oneOf": [
{
"type": "boolean",
"default": false
"type": "boolean"
},
{
"$ref": "https://schema.management.azure.com/schemas/common/definitions.json#/definitions/expression"
Expand All @@ -1595,8 +1594,7 @@
"ignoreErrors": {
"oneOf": [
{
"type": "boolean",
"default": false
"type": "boolean"
},
{
"$ref": "https://schema.management.azure.com/schemas/common/definitions.json#/definitions/expression"
Expand Down Expand Up @@ -2167,8 +2165,7 @@
"allowInsecure": {
"oneOf": [
{
"type": "boolean",
"default": false
"type": "boolean"
},
{
"$ref": "https://schema.management.azure.com/schemas/common/definitions.json#/definitions/expression"
Expand Down Expand Up @@ -2837,8 +2834,7 @@
"maxReplicas": {
"oneOf": [
{
"type": "integer",
"default": "10"
"type": "integer"
},
{
"$ref": "https://schema.management.azure.com/schemas/common/definitions.json#/definitions/expression"
Expand Down Expand Up @@ -3135,7 +3131,7 @@
},
"runtimeSubnetId": {
"type": "string",
"description": "Resource ID of a subnet that Container App containers are injected into. This subnet must be in the same VNET as the subnet defined in infrastructureSubnetId. Must not overlap with any other provided IP ranges."
"description": "This field is deprecated and not used. If you wish to provide your own subnet that Container App containers are injected into, then you should leverage the infrastructureSubnetId."
}
},
"description": "Configuration properties for apps environment to join a Virtual Network"
Expand Down
26 changes: 15 additions & 11 deletions schemas/2022-06-01-preview/Microsoft.App.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1890,7 +1890,7 @@
},
"certificateId": {
"type": "string",
"description": "Resource Id of the Certificate to be bound to this hostname."
"description": "Resource Id of the Certificate to be bound to this hostname. Must exist in the Managed Environment."
},
"name": {
"type": "string",
Expand All @@ -1906,7 +1906,15 @@
"type": "object",
"properties": {
"certificatePassword": {
"type": "string",
"oneOf": [
{
"type": "string",
"pattern": "^(?:[A-Za-z0-9+\\/]{4})*(?:[A-Za-z0-9+\\/]{2}==|[A-Za-z0-9+\\/]{3}=)?$"
},
{
"$ref": "https://schema.management.azure.com/schemas/common/definitions.json#/definitions/expression"
}
],
"description": "Certificate password"
},
"certificateValue": {
Expand Down Expand Up @@ -2053,8 +2061,7 @@
"enabled": {
"oneOf": [
{
"type": "boolean",
"default": false
"type": "boolean"
},
{
"$ref": "https://schema.management.azure.com/schemas/common/definitions.json#/definitions/expression"
Expand Down Expand Up @@ -2114,8 +2121,7 @@
"ignoreErrors": {
"oneOf": [
{
"type": "boolean",
"default": false
"type": "boolean"
},
{
"$ref": "https://schema.management.azure.com/schemas/common/definitions.json#/definitions/expression"
Expand Down Expand Up @@ -2738,8 +2744,7 @@
"allowInsecure": {
"oneOf": [
{
"type": "boolean",
"default": false
"type": "boolean"
},
{
"$ref": "https://schema.management.azure.com/schemas/common/definitions.json#/definitions/expression"
Expand Down Expand Up @@ -3602,8 +3607,7 @@
"maxReplicas": {
"oneOf": [
{
"type": "integer",
"default": "10"
"type": "integer"
},
{
"$ref": "https://schema.management.azure.com/schemas/common/definitions.json#/definitions/expression"
Expand Down Expand Up @@ -3971,7 +3975,7 @@
},
"runtimeSubnetId": {
"type": "string",
"description": "Resource ID of a subnet that Container App containers are injected into. This subnet must be in the same VNET as the subnet defined in infrastructureSubnetId. Must not overlap with any other provided IP ranges."
"description": "This field is deprecated and not used. If you wish to provide your own subnet that Container App containers are injected into, then you should leverage the infrastructureSubnetId."
}
},
"description": "Configuration properties for apps environment to join a Virtual Network"
Expand Down
33 changes: 18 additions & 15 deletions schemas/2022-10-01/Microsoft.App.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,10 +408,6 @@
"2022-10-01"
]
},
"kind": {
"type": "string",
"description": "Kind of the Environment."
},
"location": {
"type": "string",
"description": "The geo-location where the resource lives"
Expand Down Expand Up @@ -1886,7 +1882,7 @@
"$ref": "https://schema.management.azure.com/schemas/common/definitions.json#/definitions/expression"
}
],
"description": "allow credential or not"
"description": "Specifies whether the resource allows credentials"
},
"allowedHeaders": {
"oneOf": [
Expand All @@ -1900,7 +1896,7 @@
"$ref": "https://schema.management.azure.com/schemas/common/definitions.json#/definitions/expression"
}
],
"description": "allowed HTTP headers"
"description": "Specifies the content for the access-control-allow-headers header"
},
"allowedMethods": {
"oneOf": [
Expand All @@ -1914,7 +1910,7 @@
"$ref": "https://schema.management.azure.com/schemas/common/definitions.json#/definitions/expression"
}
],
"description": "allowed HTTP methods"
"description": "Specifies the content for the access-control-allow-methods header"
},
"allowedOrigins": {
"oneOf": [
Expand All @@ -1928,7 +1924,7 @@
"$ref": "https://schema.management.azure.com/schemas/common/definitions.json#/definitions/expression"
}
],
"description": "allowed origins"
"description": "Specifies the content for the access-control-allow-origins header"
},
"exposeHeaders": {
"oneOf": [
Expand All @@ -1942,7 +1938,7 @@
"$ref": "https://schema.management.azure.com/schemas/common/definitions.json#/definitions/expression"
}
],
"description": "expose HTTP headers "
"description": "Specifies the content for the access-control-expose-headers header "
},
"maxAge": {
"oneOf": [
Expand All @@ -1953,7 +1949,7 @@
"$ref": "https://schema.management.azure.com/schemas/common/definitions.json#/definitions/expression"
}
],
"description": "max time client can cache the result"
"description": "Specifies the content for the access-control-max-age header"
}
},
"required": [
Expand Down Expand Up @@ -1981,7 +1977,7 @@
},
"certificateId": {
"type": "string",
"description": "Resource Id of the Certificate to be bound to this hostname."
"description": "Resource Id of the Certificate to be bound to this hostname. Must exist in the Managed Environment."
},
"name": {
"type": "string",
Expand All @@ -1997,7 +1993,15 @@
"type": "object",
"properties": {
"certificatePassword": {
"type": "string",
"oneOf": [
{
"type": "string",
"pattern": "^(?:[A-Za-z0-9+\\/]{4})*(?:[A-Za-z0-9+\\/]{2}==|[A-Za-z0-9+\\/]{3}=)?$"
},
{
"$ref": "https://schema.management.azure.com/schemas/common/definitions.json#/definitions/expression"
}
],
"description": "Certificate password"
},
"certificateValue": {
Expand Down Expand Up @@ -2205,8 +2209,7 @@
"ignoreErrors": {
"oneOf": [
{
"type": "boolean",
"default": false
"type": "boolean"
},
{
"$ref": "https://schema.management.azure.com/schemas/common/definitions.json#/definitions/expression"
Expand Down Expand Up @@ -4089,7 +4092,7 @@
},
"runtimeSubnetId": {
"type": "string",
"description": "Resource ID of a subnet that Container App containers are injected into. This subnet must be in the same VNET as the subnet defined in infrastructureSubnetId. Must not overlap with any other provided IP ranges."
"description": "This field is deprecated and not used. If you wish to provide your own subnet that Container App containers are injected into, then you should leverage the infrastructureSubnetId."
}
},
"description": "Configuration properties for apps environment to join a Virtual Network"
Expand Down
Loading