Skip to content

Feat/fix/sidebar context #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
May 20, 2023
Merged

Feat/fix/sidebar context #169

merged 32 commits into from
May 20, 2023

Conversation

@azouaoui-med
Copy link
Owner

@azouaoui-med azouaoui-med commented May 20, 2023

Description

Added

  • [Sidebar] Added collapsed prop
  • [Sidebar] Added toggled prop
  • [Sidebar] Added onBackdropClick prop
  • [Sidebar] Added onBreakPoint prop

Updated

  • Deprecated ProSidebarProvider and made it optional
  • Deprecated useProSidebar
  • Updated BreakPoint type to use all and deprecate always

Fixed

  • Fixed closeOnClick triggering close on nested SubMenu click
  • Fixed sidebar default states not being applied correctly when using ProSidebarProvider and useProSidebar
  • Fixed Menu's transitionDuration collision with Sidebar's transitionDuration

Type of change

  • Bug fix
  • New feature
  • Documentation update
  • Refactoring / enhancement

@azouaoui-med
chore: add comments
e82a5b3
@azouaoui-med
chore: code cleanup
ac465cb
@azouaoui-med
fix: closeOnClick triggers close on nested submenu
102fcb9
@azouaoui-med
docs: closeOnClick description enhancement
39d3649
@azouaoui-med
docs: add closeOnClick story
33b0e70
@azouaoui-med
docs: menuItemStyles type definition
6676794
@azouaoui-med
docs: react router active style example
778888c
@azouaoui-med
chore: todo comments
956d18b
@azouaoui-med
Merge branch 'master' of github.com:azouaoui-med/react-pro-sidebar
bfc1cab
@azouaoui-med
remove isomorphic effect
78a5b29
@azouaoui-med
update sidebar state handler
f216865
@azouaoui-med
breakpoint initial check
4d44391
@azouaoui-med
migrate collapsed context state
d528acf
@azouaoui-med
refactor: move slide handler to SubMenu component
4a6b4ae
@azouaoui-med
refactor: submenu open handler
a492404
@azouaoui-med
fix: submenu content position on default collapsed
9d885c9
@azouaoui-med
refactor level handler
64843b0
@azouaoui-med
refactor: migrate to new sidebar context
43bfe1c
@azouaoui-med
replace onToggle prop with onBackdropClick
4ad8138
@azouaoui-med
refactor useMediaQuery
15f6b96
@azouaoui-med
added onBreakPoint prop
293b023
@azouaoui-med
rename open casted prop
8b0be2b
@azouaoui-med
deprecate legacy context
5893c60
@azouaoui-med
fix transitionDuration collision
fe1a532
@azouaoui-med
update breakpoint handler
bac8847
@azouaoui-med
breakPoint type definition
9e6504a
@azouaoui-med
missing provider error update
9a001fb
@azouaoui-med
update storybook stories
3c32822
@azouaoui-med
chore: update lint rule
e649df6
@azouaoui-med
docs: update documentation & API table
b3d443a
@azouaoui-med azouaoui-med merged commit 6514b95 into master May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@azouaoui-med