add support link #609
Merged
add support link #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkjpryor
requested changes
Sep 19, 2024
roles/azimuth/defaults/main.yml
Outdated
| @@ -85,6 +85,7 @@ azimuth_metrics_tenant_metrics_url_template: >- | |||
| # The documentation URL | |||
| # By default, we use the generic Azimuth docs | |||
| azimuth_documentation_url: https://azimuth-cloud.github.io/azimuth-user-docs/ | |||
| azimuth_support_url: https://confluence.skatelescope.org/display/SRCSC/Azimuth+Support+on+Cambridge+Arcus | |||
There was a problem hiding this comment.
Similar to the Azimuth PR, this should not have a value by default.
|
Hello @mkjpryor, I changes made . Kindly review |
JohnGarbutt
reviewed
Nov 6, 2024
There was a problem hiding this comment.
This looks worth adding.
We might also want to tweak to the docs so it's clear this is an option? Maybe that is overkill. I will let @mkjpryor re-review this one.
mkjpryor
requested changes
Nov 12, 2024
roles/azimuth/defaults/main.yml
Outdated
| @@ -85,6 +85,7 @@ azimuth_metrics_tenant_metrics_url_template: >- | |||
| # The documentation URL | |||
| # By default, we use the generic Azimuth docs | |||
| azimuth_documentation_url: https://azimuth-cloud.github.io/azimuth-user-docs/ | |||
| azimuth_support_url: None | |||
There was a problem hiding this comment.
This isn't how you specify a null value in YAML - this variable will have the string "None" as its value. Please change this to one of the following:
azimuth_support_url:
azimuth_support_url: null
azimuth_support_url: ~The first method is preferred and is used elsewhere.
There was a problem hiding this comment.
ah, doh, I missed that, good point.
There was a problem hiding this comment.
Thanks @mkjpryor . Updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.