Change minimum versions of Node and eslint in integration tests #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node v16 is out of support. So we test against Node v18 and v20. eslint 7 was released 4 years ago so its fair to not actively test again eslint 6. Speculativiely adding eslint 9 tests but not sure if that will work
We weren't doing custom installations of different eslint versions so we were always only testing one eslint version! Added eslint-v9 test directory but it fails right now so not adding it to CI.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #83 +/- ##
=======================================
Coverage 82.35% 82.35%
=======================================
Files 1 1
Lines 51 51
=======================================
Hits 42 42
Misses 9 9 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node v16 is out of support. So we test against Node v18 and v20.
eslint 7 was released 4 years ago so its fair to not actively test again eslint 6. Speculativiely adding eslint 9 tests but not sure if that will work