Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impl FromStr for BlockPos & Vec #174

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Impl FromStr for BlockPos & Vec #174

merged 2 commits into from
Oct 21, 2024

Conversation

ShayBox
Copy link
Contributor

@ShayBox ShayBox commented Oct 21, 2024

This can parse X Y Z back into a BlockPos or Vec3 from the existing Display trait.

@ShayBox
Impl FromStr for BlockPos & Vec
4811410 
(cherry picked from commit 288db1c)
mat-1
mat-1 requested changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@mat-1 mat-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, though, could you write doc comments for the from_str implementations please (just a short sentence for each is fine)

mat-1
mat-1 approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@mat-1 mat-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@mat-1 mat-1 merged commit 5535877 into azalea-rs:main Oct 21, 2024
1 check passed
@ShayBox ShayBox deleted the FromStr-for-BlockPos&Vec3 branch October 21, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mat-1 mat-1 mat-1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShayBox @mat-1