Skip to content

fix codegen and broken packets to finish updating to 24w39a :D #1914

fix codegen and broken packets to finish updating to 24w39a :D

fix codegen and broken packets to finish updating to 24w39a :D #1914

Triggered via push October 17, 2024 01:03
Status Success
Total duration 4m 12s
Artifacts

check.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

36 warnings
empty line after doc comment: azalea/src/swarm/mod.rs#L550
warning: empty line after doc comment --> azalea/src/swarm/mod.rs:550:1 | 550 | / /// } 551 | | | |_ 552 | impl Swarm { | ---------- the comment documents this implementation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default = help: if the empty line is unintentional remove it
called `map(..).flatten()` on `Option`: azalea/src/pathfinder/simulation.rs#L159
warning: called `map(..).flatten()` on `Option` --> azalea/src/pathfinder/simulation.rs:159:14 | 159 | .map(|c| *c) | ______________^ 160 | | .flatten() | |______________________^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|c| *c)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten = note: `#[warn(clippy::map_flatten)]` on by default
first doc comment paragraph is too long: azalea/src/pathfinder/debug.rs#L7
warning: first doc comment paragraph is too long --> azalea/src/pathfinder/debug.rs:7:1 | 7 | / /// A component that makes bots run /particle commands while pathfinding to show 8 | | /// where they're going. This requires the bots to have server operator 9 | | /// permissions, and it'll make them spam *a lot* of commands. 10 | | /// 11 | | /// ``` | |_ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_long_first_doc_paragraph = note: `#[warn(clippy::too_long_first_doc_paragraph)]` on by default
the following explicit lifetimes could be elided: 'w, 's: azalea/src/nearest_entity.rs#L60
warning: the following explicit lifetimes could be elided: 'w, 's --> azalea/src/nearest_entity.rs:60:6 | 60 | impl<'w, 's, 'a, F> EntityFinder<'w, 's, F> | ^^ ^^ ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `#[warn(clippy::needless_lifetimes)]` on by default help: elide the lifetimes | 60 - impl<'w, 's, 'a, F> EntityFinder<'w, 's, F> 60 + impl<'a, F> EntityFinder<'_, '_, F> |
empty line after doc comment: azalea-client/src/raw_connection.rs#L24
warning: empty line after doc comment --> azalea-client/src/raw_connection.rs:24:5 | 24 | / /// Packets sent to this will be sent to the server. 25 | | | |_ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default = help: if the empty line is unintentional remove it help: if the documentation should include the empty line include it in the comment | 25 | /// |
first doc comment paragraph is too long: azalea-client/src/raw_connection.rs#L16
warning: first doc comment paragraph is too long --> azalea-client/src/raw_connection.rs:16:1 | 16 | / /// A component for clients that can read and write packets to the server. This 17 | | /// works with raw bytes, so you'll have to serialize/deserialize packets 18 | | /// yourself. It will do the compression and encryption for you though. | |_ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_long_first_doc_paragraph
first doc comment paragraph is too long: azalea-client/src/packet_handling/login.rs#L18
warning: first doc comment paragraph is too long --> azalea-client/src/packet_handling/login.rs:18:1 | 18 | / /// An event that's sent when we receive a login packet from the server. Note 19 | | /// that if you want to handle this in a system, you must add 20 | | /// `.before(azalea::packet_handling::login::process_packet_events)` to it 21 | | /// because that system clears the events. | |_ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_long_first_doc_paragraph
first doc comment paragraph is too long: azalea-client/src/movement.rs#L480
warning: first doc comment paragraph is too long --> azalea-client/src/movement.rs:480:1 | 480 | / /// An event sent by the server that sets or adds to our velocity. Usually 481 | | /// `KnockbackKind::Set` is used for normal knockback and `KnockbackKind::Add` 482 | | /// is used for explosions, but some servers (notably Hypixel) use explosions 483 | | /// for knockback. | |_ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_long_first_doc_paragraph = note: `#[warn(clippy::too_long_first_doc_paragraph)]` on by default
large size difference between variants: azalea-client/src/local_player.rs#L141
warning: large size difference between variants --> azalea-client/src/local_player.rs:141:1 | 141 | / pub enum HandlePacketError { 142 | | #[error("{0}")] 143 | | Poison(String), | | -------------- the second-largest variant contains at least 24 bytes 144 | | #[error(transparent)] ... | 149 | | Send(#[from] mpsc::error::SendError<AzaleaEvent>), | | ------------------------------------------------- the largest variant contains at least 232 bytes 150 | | } | |_^ the entire enum is at least 0 bytes | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant = note: `#[warn(clippy::large_enum_variant)]` on by default help: consider boxing the large fields to reduce the total size of the enum | 149 | Send(#[from] Box<mpsc::error::SendError<AzaleaEvent>>), | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
the following explicit lifetimes could be elided: 'a: azalea-protocol/src/lib.rs#L43
warning: the following explicit lifetimes could be elided: 'a --> azalea-protocol/src/lib.rs:43:6 | 43 | impl<'a> TryFrom<&'a str> for ServerAddress { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `#[warn(clippy::needless_lifetimes)]` on by default help: elide the lifetimes | 43 - impl<'a> TryFrom<&'a str> for ServerAddress { 43 + impl TryFrom<&str> for ServerAddress { |
the following explicit lifetimes could be elided: 'a: azalea-world/src/find_blocks.rs#L158
warning: the following explicit lifetimes could be elided: 'a --> azalea-world/src/find_blocks.rs:158:6 | 158 | impl<'a> Iterator for FindBlocks<'a> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 158 - impl<'a> Iterator for FindBlocks<'a> { 158 + impl Iterator for FindBlocks<'_> { |
first doc comment paragraph is too long: azalea-world/src/chunk_storage.rs#L44
warning: first doc comment paragraph is too long --> azalea-world/src/chunk_storage.rs:44:1 | 44 | / /// A single chunk in a world (16*?*16 blocks). This only contains the blocks 45 | | /// and biomes. You can derive the height of the chunk from the number of 46 | | /// sections, but you need a [`ChunkStorage`] to get the minimum Y 47 | | /// coordinate. | |_ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_long_first_doc_paragraph = note: `#[warn(clippy::too_long_first_doc_paragraph)]` on by default
the following explicit lifetimes could be elided: 'a: azalea-world/src/bit_storage.rs#L231
warning: the following explicit lifetimes could be elided: 'a --> azalea-world/src/bit_storage.rs:231:6 | 231 | impl<'a> Iterator for BitStorageIter<'a> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `#[warn(clippy::needless_lifetimes)]` on by default help: elide the lifetimes | 231 - impl<'a> Iterator for BitStorageIter<'a> { 231 + impl Iterator for BitStorageIter<'_> { |
manually reimplementing `div_ceil`: azalea-world/src/bit_storage.rs#L122
warning: manually reimplementing `div_ceil` --> azalea-world/src/bit_storage.rs:122:33 | 122 | let calculated_length = (size + values_per_long - 1) / values_per_long; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `size.div_ceil(values_per_long)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil = note: `#[warn(clippy::manual_div_ceil)]` on by default
first doc comment paragraph is too long: azalea-auth/src/sessionserver.rs#L125
warning: first doc comment paragraph is too long --> azalea-auth/src/sessionserver.rs:125:1 | 125 | / /// Ask Mojang's servers if the player joining is authenticated. 126 | | /// Included in the reply is the player's skin and cape. 127 | | /// The IP field is optional and equivalent to enabling 128 | | /// 'prevent-proxy-connections' in server.properties | |_ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_long_first_doc_paragraph = note: `#[warn(clippy::too_long_first_doc_paragraph)]` on by default help: add an empty line | 125 ~ /// Ask Mojang's servers if the player joining is authenticated. 126 + /// |
empty line after doc comment: azalea/src/swarm/mod.rs#L550
warning: empty line after doc comment --> azalea/src/swarm/mod.rs:550:1 | 550 | / /// } 551 | | | |_ 552 | impl Swarm { | ---------- the comment documents this implementation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default = help: if the empty line is unintentional remove it
called `map(..).flatten()` on `Option`: azalea/src/pathfinder/simulation.rs#L159
warning: called `map(..).flatten()` on `Option` --> azalea/src/pathfinder/simulation.rs:159:14 | 159 | .map(|c| *c) | ______________^ 160 | | .flatten() | |______________________^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|c| *c)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten = note: `#[warn(clippy::map_flatten)]` on by default
first doc comment paragraph is too long: azalea/src/pathfinder/debug.rs#L7
warning: first doc comment paragraph is too long --> azalea/src/pathfinder/debug.rs:7:1 | 7 | / /// A component that makes bots run /particle commands while pathfinding to show 8 | | /// where they're going. This requires the bots to have server operator 9 | | /// permissions, and it'll make them spam *a lot* of commands. 10 | | /// 11 | | /// ``` | |_ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_long_first_doc_paragraph = note: `#[warn(clippy::too_long_first_doc_paragraph)]` on by default
the following explicit lifetimes could be elided: 'w, 's: azalea/src/nearest_entity.rs#L60
warning: the following explicit lifetimes could be elided: 'w, 's --> azalea/src/nearest_entity.rs:60:6 | 60 | impl<'w, 's, 'a, F> EntityFinder<'w, 's, F> | ^^ ^^ ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `#[warn(clippy::needless_lifetimes)]` on by default help: elide the lifetimes | 60 - impl<'w, 's, 'a, F> EntityFinder<'w, 's, F> 60 + impl<'a, F> EntityFinder<'_, '_, F> |
empty line after doc comment: azalea-client/src/raw_connection.rs#L24
warning: empty line after doc comment --> azalea-client/src/raw_connection.rs:24:5 | 24 | / /// Packets sent to this will be sent to the server. 25 | | | |_ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default = help: if the empty line is unintentional remove it help: if the documentation should include the empty line include it in the comment | 25 | /// |
first doc comment paragraph is too long: azalea-client/src/raw_connection.rs#L16
warning: first doc comment paragraph is too long --> azalea-client/src/raw_connection.rs:16:1 | 16 | / /// A component for clients that can read and write packets to the server. This 17 | | /// works with raw bytes, so you'll have to serialize/deserialize packets 18 | | /// yourself. It will do the compression and encryption for you though. | |_ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_long_first_doc_paragraph
first doc comment paragraph is too long: azalea-client/src/packet_handling/login.rs#L18
warning: first doc comment paragraph is too long --> azalea-client/src/packet_handling/login.rs:18:1 | 18 | / /// An event that's sent when we receive a login packet from the server. Note 19 | | /// that if you want to handle this in a system, you must add 20 | | /// `.before(azalea::packet_handling::login::process_packet_events)` to it 21 | | /// because that system clears the events. | |_ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_long_first_doc_paragraph
first doc comment paragraph is too long: azalea-client/src/movement.rs#L480
warning: first doc comment paragraph is too long --> azalea-client/src/movement.rs:480:1 | 480 | / /// An event sent by the server that sets or adds to our velocity. Usually 481 | | /// `KnockbackKind::Set` is used for normal knockback and `KnockbackKind::Add` 482 | | /// is used for explosions, but some servers (notably Hypixel) use explosions 483 | | /// for knockback. | |_ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_long_first_doc_paragraph = note: `#[warn(clippy::too_long_first_doc_paragraph)]` on by default
large size difference between variants: azalea-client/src/local_player.rs#L141
warning: large size difference between variants --> azalea-client/src/local_player.rs:141:1 | 141 | / pub enum HandlePacketError { 142 | | #[error("{0}")] 143 | | Poison(String), | | -------------- the second-largest variant contains at least 24 bytes 144 | | #[error(transparent)] ... | 149 | | Send(#[from] mpsc::error::SendError<AzaleaEvent>), | | ------------------------------------------------- the largest variant contains at least 232 bytes 150 | | } | |_^ the entire enum is at least 0 bytes | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant = note: `#[warn(clippy::large_enum_variant)]` on by default help: consider boxing the large fields to reduce the total size of the enum | 149 | Send(#[from] Box<mpsc::error::SendError<AzaleaEvent>>), | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
the following explicit lifetimes could be elided: 'a: azalea-protocol/src/lib.rs#L43
warning: the following explicit lifetimes could be elided: 'a --> azalea-protocol/src/lib.rs:43:6 | 43 | impl<'a> TryFrom<&'a str> for ServerAddress { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `#[warn(clippy::needless_lifetimes)]` on by default help: elide the lifetimes | 43 - impl<'a> TryFrom<&'a str> for ServerAddress { 43 + impl TryFrom<&str> for ServerAddress { |
the following explicit lifetimes could be elided: 'a: azalea-world/src/find_blocks.rs#L158
warning: the following explicit lifetimes could be elided: 'a --> azalea-world/src/find_blocks.rs:158:6 | 158 | impl<'a> Iterator for FindBlocks<'a> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 158 - impl<'a> Iterator for FindBlocks<'a> { 158 + impl Iterator for FindBlocks<'_> { |
first doc comment paragraph is too long: azalea-world/src/chunk_storage.rs#L44
warning: first doc comment paragraph is too long --> azalea-world/src/chunk_storage.rs:44:1 | 44 | / /// A single chunk in a world (16*?*16 blocks). This only contains the blocks 45 | | /// and biomes. You can derive the height of the chunk from the number of 46 | | /// sections, but you need a [`ChunkStorage`] to get the minimum Y 47 | | /// coordinate. | |_ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_long_first_doc_paragraph = note: `#[warn(clippy::too_long_first_doc_paragraph)]` on by default
the following explicit lifetimes could be elided: 'a: azalea-world/src/bit_storage.rs#L231
warning: the following explicit lifetimes could be elided: 'a --> azalea-world/src/bit_storage.rs:231:6 | 231 | impl<'a> Iterator for BitStorageIter<'a> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `#[warn(clippy::needless_lifetimes)]` on by default help: elide the lifetimes | 231 - impl<'a> Iterator for BitStorageIter<'a> { 231 + impl Iterator for BitStorageIter<'_> { |
manually reimplementing `div_ceil`: azalea-world/src/bit_storage.rs#L122
warning: manually reimplementing `div_ceil` --> azalea-world/src/bit_storage.rs:122:33 | 122 | let calculated_length = (size + values_per_long - 1) / values_per_long; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `size.div_ceil(values_per_long)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil = note: `#[warn(clippy::manual_div_ceil)]` on by default
first doc comment paragraph is too long: azalea-auth/src/sessionserver.rs#L125
warning: first doc comment paragraph is too long --> azalea-auth/src/sessionserver.rs:125:1 | 125 | / /// Ask Mojang's servers if the player joining is authenticated. 126 | | /// Included in the reply is the player's skin and cape. 127 | | /// The IP field is optional and equivalent to enabling 128 | | /// 'prevent-proxy-connections' in server.properties | |_ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_long_first_doc_paragraph = note: `#[warn(clippy::too_long_first_doc_paragraph)]` on by default help: add an empty line | 125 ~ /// Ask Mojang's servers if the player joining is authenticated. 126 + /// |
clippy_check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
clippy_check
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/