suggested changes to simulation interface worlds #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Dąbrowski <[email protected]>
ayushgnv
reviewed
Apr 19, 2025
ayushgnv
reviewed
Apr 19, 2025
ayushgnv
approved these changes
Apr 19, 2025
Owner
ayushgnv
left a comment
ayushgnv
left a comment
There was a problem hiding this comment.
Thanks for making this PR. Added a few comments regarding some changes that may still be needed before this can be merged.
Signed-off-by: Adam Dąbrowski <[email protected]>
Author
|
Thank you for these suggestions! Changes applied, lets merge and continue the process on the main PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some suggestions to simulation interfaces, guided by the need to handle conceptual differences and some quality of life ideas.