fix: new lines in cells broke table format #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Amazing Idea. Im not sure if this should be just the default behaviour or we should be able to configure this. |
|
@ayonious do you think you could release this fix? |
|
🎉 This PR is included in version 2.12.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👀What is this pr about?
Fixes #438
🚀 Changes
Fixed
New lines within a cell would put a new line through the whole table, breaking formatting.
🖼 Screenshots
Before
┌────────────┬──────────────────────────────────────────┬──────────────────────────────────────────┐ │ foo │ bar │ baz │ ├────────────┼──────────────────────────────────────────┼──────────────────────────────────────────┤ habitant morbi tristique senectus et netus et │ * Cras ac ligula aliquet, ultrices erat │ │ │ malesuada fames ac turpis egestas. │ quis, laoreet lorem. * Mauris rutrum nisi et nisl │ │ │ Maecenas ut scelerisque felis. Etiam ut │ sollicitudin semper. * Nunc laoreet felis auctor │ │ │ leo fringilla lacus posuere dignissim │ diam aliquet semper. * Integer aliquet urna │ │ │ aliquet eu nulla. Etiam placerat ultricies │ imperdiet orci pulvinar, at vulputate │ │ │ sollicitudin. Maecenas ultrices feugiat │ ante consectetur. * Pellentesque a lectus porttitor, │ │ │ tempor. Nam non nisi vel diam tristique │ condimentum lacus non, venenatis lacus. │ │ │ commodo. Etiam sit amet nisi sagittis, │ │ │ │ fringilla tortor sed, efficitur nisl. │ │ │ │ Maecenas tincidunt lobortis dapibus. │ │ └────────────┴──────────────────────────────────────────┴──────────────────────────────────────────┘After
┌────────────┬──────────────────────────────────────────┬──────────────────────────────────────────┐ │ foo │ bar │ baz │ ├────────────┼──────────────────────────────────────────┼──────────────────────────────────────────┤ │ Sed dictum │ Pellentesque │ * Cras ac ligula aliquet, ultrices erat │ │ │ habitant morbi tristique senectus et │ quis, laoreet lorem. │ │ │ netus et malesuada fames ac turpis │ * Mauris rutrum nisi et nisl │ │ │ egestas. Maecenas ut scelerisque felis. │ sollicitudin semper. │ │ │ Etiam ut leo fringilla lacus posuere │ * Nunc laoreet felis auctor diam aliquet │ │ │ dignissim aliquet eu nulla. │ semper. │ │ │ │ * Integer aliquet urna imperdiet orci │ │ │ Etiam placerat ultricies sollicitudin. │ pulvinar, at vulputate ante consectetur. │ │ │ Maecenas ultrices feugiat tempor. Nam │ * Pellentesque a lectus porttitor, │ │ │ non nisi vel diam tristique commodo. │ condimentum lacus non, venenatis lacus. │ │ │ Etiam sit amet nisi sagittis, fringilla │ │ │ │ tortor sed, efficitur nisl. Maecenas │ │ │ │ tincidunt lobortis dapibus. │ │ └────────────┴──────────────────────────────────────────┴──────────────────────────────────────────┘