fix: Adding Better regex for ansi codes stripping from the string #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified regex to allow for more variations of ansi codes like '\x1b[38;5m', bolding, etc.
|
This is amazing! Thanks a lot! Could you also add some nice tests in console-utils.test.ts? |
ayonious
changed the title
ayonious
approved these changes
Feb 15, 2023
|
🎉 This PR is included in version 2.11.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified regex to allow for more variations of ansi codes like '\x1b[38;5m', bolding, etc.
👀What is this pr about?
Measurement of string width removes ansi escape codes for color, but only the ansi escape codes produced by the library. This change modifies the regex that strips escape codes for correct string width measurement to include more codes that can be inserted into the content text items by the caller.
🚀 Changes
Updated
Width measurement regex
🖼 Screenshots
before:
┌───┬────┬───┐
│ a │ c │ b │
├───┼────┼───┤
│ 1 │ 55 │ │
│ │ │ 1 │
└───┴────┴───┘
after:
┌───┬────┬───┐
│ a │ c │ b │
├───┼────┼───┤
│ 1 │ 55 │ │
│ │ │ 1 │
└───┴────┴───┘
👶 The naming of the PR
fix: ansi escape codes stripped better for measurement