Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added row separator option #372

Merged
merged 7 commits into from
Jun 12, 2021
Merged

feat: Added row separator option #372

merged 7 commits into from
Jun 12, 2021

Conversation

av-virlan
Copy link
Contributor

@av-virlan av-virlan commented Jun 7, 2021 •
edited by ayonious
Loading

👀What is this pr about?

This PR adds another option when adding rows to decide if the row should have a bottom border.
Rows with bottom border (except last row) trigger the add of another line for separation purpose.

🚀 Changes

Added

  • bottomBorder option to RowOptions
  • rowBottom style definition so you can control the separators

Fixed

  • made properties from RowOptions to be optional so you can specify only color or only border

Updated

🖼 Screenshots

Before After
image image

ayonious
ayonious requested changes Jun 8, 2021
View reviewed changes
Copy link
Owner

@ayonious ayonious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work. Left some points to fix.

src/models/internal-table.ts Outdated Show resolved Hide resolved
src/models/common.ts Outdated Show resolved Hide resolved
src/internalTable/internal-table-printer.ts Outdated Show resolved Hide resolved
@av-virlan av-virlan requested a review from ayonious June 11, 2021 19:23
@av-virlan av-virlan changed the title feat: Added 'bottomBorder' row option + support for row separator to improve readability feat: Added row separator option Jun 11, 2021
ayonious
ayonious approved these changes Jun 12, 2021
View reviewed changes
Copy link
Owner

@ayonious ayonious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some small issues but that I will fix in a later PR

@ayonious ayonious merged commit 63855ae into ayonious:master Jun 12, 2021
ayonious pushed a commit that referenced this pull request Aug 4, 2021
@semantic-release-bot
chore(release): 2.10.0 [skip ci]
0104df6 
# [2.10.0](v2.9.0...v2.10.0) (2021-08-04)

### Bug Fixes

* **row-separator:** make row separator optional ([#373](#373)) ([325db51](325db51))

### Features

* **row separator:** Added row separator option ([#372](#372)) ([63855ae](63855ae))
@ayonious
Copy link
Owner

ayonious commented Aug 4, 2021

🎉 This PR is included in version 2.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayonious ayonious ayonious approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@av-virlan @ayonious