test: improve assertion fail messages

PR-URL: nodejs/node#14949 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
ayojs · Aug 28, 2017 · 50d1b94 · 50d1b94
1 parent d9a1740
commit 50d1b94
Showing 1 changed file with 16 additions and 7 deletions.
diff --git a/test/parallel/test-stream-inheritance.js b/test/parallel/test-stream-inheritance.js
@@ -33,17 +33,26 @@ assert.ok(!(undefined instanceof Writable));
 
 // Simple inheritance check for `Writable` works fine in a subclass constructor.
 function CustomWritable() {
-  assert.ok(this instanceof Writable, 'inherits from Writable');
-  assert.ok(this instanceof CustomWritable, 'inherits from CustomWritable');
+  assert.ok(
+    this instanceof CustomWritable,
+    `${this} does not inherit from CustomWritable`
+  );
+  assert.ok(
+    this instanceof Writable,
+    `${this} does not inherit from Writable`
+  );
 }
 
 Object.setPrototypeOf(CustomWritable, Writable);
 Object.setPrototypeOf(CustomWritable.prototype, Writable.prototype);
 
 new CustomWritable();
 
-assert.throws(CustomWritable,
-              common.expectsError({
-                code: 'ERR_ASSERTION',
-                message: /^inherits from Writable$/
-              }));
+common.expectsError(
+  CustomWritable,
+  {
+    code: 'ERR_ASSERTION',
+    type: assert.AssertionError,
+    message: 'undefined does not inherit from CustomWritable'
+  }
+);