This repository has been archived by the owner on May 29, 2022. It is now read-only.
do not hardcode native modules list #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work. I didn't know about process.binding. Thanks for your contribution. I'll merge it. |
ayecue
added a commit
that referenced
this pull request
Oct 5, 2015
do not hardcode native modules list
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hardcoded list of native Node.js modules ties this module to a specific version of Node.js. (It's missing
v8and others in Node 4.1.1, for example.) This PR dynamically generates the list of native Node.js modules. Unfortunately, it uses the undocumentedprocess.binding()but it works on every version of Node I've tested it on (0.10.40 where it contains 40 modules, 0.12.7 where it contains 51 modules, and 4.1.1 where it contains 53 modules).